| sitter |
| Frameworks |
getmntent for samba returns fsname of the form "//server/folder" (same as mount)
It is not sufficient to use in udi as device name as it does not differenciate mounts sharing the same source but having different mount points.
BUG: 418906
FIXED-IN: 5.69
With a local cifs mount point:
Before
$ solid-hardware5 list | grep ourfiles
udi = '/org/kde/fstab///meven-synapse/ourfiles'
After
$ solid-hardware5 list | grep ourfiles
udi = '/org/kde/fstab///meven-synapse/ourfiles:/media/samba'
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/solid/devices/backends/fstab/fstabhandling.cpp | ||
|---|---|---|
| 127 | use QLatin1String | |
| src/solid/devices/backends/fstab/fstabhandling.cpp | ||
|---|---|---|
| 131 | Nitpick: QLatin1Char. | |
You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again 😂
Good stuff!
The comment and commit message are lacking required information. One should not have to go to the bug report to actually see why this is needed.
While the summary has the BR reference, the code comment is totally unclear.
How about the commit title "Ensure to differenciate mounts sharing the same source" -> it implies that before this, mounts sharing the same source where not differentiated. That already sounds pretty bad to me...