- User Since
- Jun 28 2015, 8:46 AM (267 w, 22 h)
May 16 2020
All painting of documents is done in points
Even for line thickness it doesn't make sense to enable it in general. the image will change if you zoom in and out.
May 15 2020
Nothing prevents Karbon from having a m_pixelUnit with ppi collected from a widget for user control
And that is why this proposal should be rejected as is
Apr 28 2020
Well you are definitely in the right class to make such changes.
My immidiate reaction is no.
Mar 13 2020
It is a no from me for exactly the reasons pino and ngraham bring up.
Nov 11 2019
To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow.
Nov 8 2019
Not strange for a normal list - but yes for headings it sounds wrong - and I think this is where you need to make the changes.
This looks scarily generic
Oct 25 2019
All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case
Oct 22 2019
I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases
Oct 21 2019
As far as I'm concerned you may push to rtf importer at your own discretion
Sep 14 2019
Looks simple enough to me too - someone please push
Jul 19 2019
btw For such small fixes we don't usually require review
Feb 28 2019
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects
That's not to say that the virtual canvas should not be exportable at all: you'd want to be able to include it when generating a PDF (SVG, JPG, etc) format version for use in on-screen only presentations. Of course you could just add a backdrop layer in that case.
I'm not aware that Karbon has the equivalent of a slide/page design feature where you can define how each page will look. That could look be used to be achieve what I describe here but in Karbon that layer should probably not be printed by default (just like it isn't in presentation apps, IIRC).
Feb 26 2019
Feb 25 2019
totally agree about not theme'ing canvas
Feb 13 2019
I definitely don't want this docker default on, but if as you say it's default off then i guess your change is okay - i'll take your word for it
Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email
Feb 12 2019
I like it
Jan 30 2019
regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check
Jan 23 2019
Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it.
Yes that description helped a lot, and you are doing great. Keep up the good work :)
Could you please describe what you have done and why
Jan 22 2019
Jan 15 2019
Jan 8 2019
Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed
Dec 18 2018
good investigative work, but I fear those tests are way too simple to dare apply the patch.
Dec 17 2018
And has anyone been able to produce a smaller 1 page example of the document - we are stumbling blindly here.
Do we have an odf snippet of the table that gives the problem?
Still not the description i was looking for. I want to know what the extreme case is and what the resulting document should look like when we give up:
No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words
Dan I like your diff better - I don't think it's completely there but it's a better starting point
Dec 14 2018
it's not wrong to break off, because normally it should then try again with this row on the following page where there is more room. so this change is wrong and will break other cases
Nov 5 2018
Oct 22 2018
As I recall it was one of the files in the huge dataset - there should be a bug on it
Yes as i recall that code was made to handle masks being exported correctly for OpenOffice or LO - I'd strongly prefer it not being thrown away like that
Sep 26 2018
Ahh well in that case I don't mind and the words code looks clean enough - I'll let someone else review the components
'm sorry but the background should not be settable - it's a document property at best and in fact paper is mostly white, so shouldn't even be settable
Sep 24 2018
Sep 17 2018
Sep 16 2018
Bah I can't remember this, but page anchored shapes don't have anchors as such, so I'm wondering what exactly is this writing to file?
Sep 13 2018
No idea either - jaroslaw was the original author so maybe he can take a look
Sep 12 2018
I am more thinking of this place:
The idea is that if we are at the beginning of a new page we don't get in here (virginpage is true)
so we only reset if we are somewhere down on a page meaning we wil have more space to try on next time around
But we should reset if the only thing we fitted was the table header as a table headerrow should never be the only thing on a page
Sep 11 2018
Sep 10 2018
No Idea about the code, but in general I have no problem with sheets respecting the palette
Aug 31 2018
I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working
Aug 29 2018
And none of that contradicts me saying it's not a general feature we want, but at most for Karbon, and that since we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway
I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it
discard as a general solution - it doesn't make close to any sense for other than karbon when used as a tool to generate pixmaps in the end, and even then as I said it's a bad idea for various reasons
Aug 28 2018
The problem here is if they think they can place a line on a specific pixel position - we don't store coords as pixels - so it will not end being rendered to a specific pixel anyway - we will just end up with users not getting what they think they get, even in such a case as you describe
Yes, that is exactly how they could use it but, I think we are doing a disservice by offering such an option- there is no way an author can know the destination resolution and it will only apply to one destination.
What is the purpose of showing pixel units in general - pixels is not really a unit except in very specific cases - I'd saythis is very very wrong
Jul 30 2018
given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16, no
Don't know what the last is supposed to be but it should probably have the same treatment
Jul 22 2018
except that its 1, 1½, 2 and not 1,2,3 then it looks good
yes and line 233-235 in the same file - fix that and we are ready to push
Jul 21 2018
in plugins/textshape/dialogs there is a file that handles line height (can't remember which exactly)
Jun 2 2018
So now we are just missing the texttool ui changes
May 30 2018
Okay I basically believe you are right, but before I accept I ask you to make the corresponding changes in
I have my linux partiotion working again, so I'l take a look this weekend - is there a bug number and a test document somewhere ?
May 28 2018
This is not correct
Feb 9 2018
I have npt had time to try it out myself - and since you didn't make the test i asked for i have nothing new to tell
Jan 14 2018
Ok please make the following test:
create 10 lines of text in LO see where the text ends change the lines to 101% and see it becomes just a little bit higher and not lower
Jan 8 2018
It looks indeed like the descend of the line is not used when figuring out the row height - try doubling the font size and see if the cut is still everything below the baseline?
Hmm the line is inside a table, maybe that is what goes wrong - unfortunately the code is not easy to understand, but at least you can try and see why the value is different
No my linux installation has malfunctioned - could you please add some screenshots so i can see what the problem is more specifically?
Jan 4 2018
can you please supply a test document then - is there a bug number?
Dec 29 2017
see KoTextLayoutArea_paint.cpp line 250
Yes you are more than welcome to try and fix the drawing - however the drawing is done like it is due to an issue with hoe qt renders compare to how it's supposed to look., so if we can fix both the original problem and the new without breaking anything else i'm all for fixing it
Ok - good work
Dec 28 2017
It's not a proper fix no - the height is correct - it's when drawing we have a problem.
The lines below will be drawn on top, and due to some other problem drawing lines will always clear the area first thus cutting away some of the text
Aug 21 2017
I like what you have done
Aug 14 2017
looks good to me
Aug 11 2017
But afaics the whole doc will be spellchecked, as the code iterates over
Aug 10 2017
Jul 22 2017
No need to review these very simple changes - just make sure you test before pushing
Jan 24 2017
Jan 18 2017
Jan 9 2017
Moving on I'd like to remove that docker in favor of having the create tool always visible and show the "add shape" stuff as the option widget of the tool
Jan 6 2017
it has my blessing then but i'll let mecir give the final vote
I doubt words will start using these indeed but still wouldn't they make sense for sheets, and if so i think it makes more sense for the tests to not fail
Dec 10 2016
Dec 6 2016
yeah it's been like this sence 2.x series so nothing that needs to be fixed before release - also I plan on improving the placing UI - but have been focusing on bugs for a while
Well it can be changed by the user or do you suggest that we change the default ?
Nov 30 2016
Outside my knowledge area but would approve
Nov 24 2016
ah ok yes then that should be fine
templates that the user might have created comes to mind
Nov 23 2016
ok let us try it out