boemann (Camilla Boemann)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 28 2015, 8:46 AM (217 w, 21 h)
Availability
Available

Recent Activity

Jul 19 2019

boemann accepted D22545: Add missing include QDate.

btw For such small fixes we don't usually require review

Jul 19 2019, 10:08 AM · Calligra: 3.0

Feb 28 2019

boemann added a comment to D19216: Karbon: Enable multi page capability.
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

This hasn't been sitting right with me and I finally realised why.

That statement is true when you work with a real canvas and draw/paint/whatever directly onto that. If you take a grid paper the grid will become part of your art, but does Karbon print the grid which you can have it show (except possibly via an option)?

In drawing applications, the canvas is NOT part of your art, but simulates the canvas you'll be printing on. It's a backdrop layer that sits behind/below the lowest layer you can draw on. If you plan to print on a coloured piece of paper, or one with a canvassy texture, you'll probably want to adapt your virtual canvas so you can incorporate the physical canvas properties into your design. But you don't want that virtual canvas to print as that would be a waste of toner at best...

That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

That's not to say that the virtual canvas should not be exportable at all: you'd want to be able to include it when generating a PDF (SVG, JPG, etc) format version for use in on-screen only presentations. Of course you could just add a backdrop layer in that case.

I'm not aware that Karbon has the equivalent of a slide/page design feature where you can define how each page will look. That could look be used to be achieve what I describe here but in Karbon that layer should probably not be printed by default (just like it isn't in presentation apps, IIRC).

Feb 28 2019, 11:18 AM · Calligra: 3.0

Feb 26 2019

boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

no

Feb 26 2019, 7:11 AM · Calligra: 3.0

Feb 25 2019

boemann added a comment to D19216: Karbon: Enable multi page capability.

totally agree about not theme'ing canvas

Feb 25 2019, 11:52 AM · Calligra: 3.0

Feb 13 2019

boemann accepted D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 9:09 PM · Calligra: 3.0
boemann accepted D18843: Activate stencils docker in all apps.

I definitely don't want this docker default on, but if as you say it's default off then i guess your change is okay - i'll take your word for it

Feb 13 2019, 8:34 AM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 3:55 AM · Calligra: 3.0

Feb 12 2019

boemann accepted D18963: Improve KoModeBox display in horizontal Mode.

I like it

Feb 12 2019, 3:57 PM · Calligra: 3.0

Jan 30 2019

boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check

Jan 30 2019, 10:08 AM · Calligra: 3.0

Jan 23 2019

boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it.

Jan 23 2019, 1:23 PM · Calligra: 3.0
boemann added a reviewer for D18466: Fixed calligra crashing when opening remote document: danders.
Jan 23 2019, 1:16 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Yes that description helped a lot, and you are doing great. Keep up the good work :)

Jan 23 2019, 1:14 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Could you please describe what you have done and why

Jan 23 2019, 12:54 PM · Calligra: 3.0

Jan 22 2019

boemann accepted D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 9:10 AM · Calligra: 3.0

Jan 15 2019

boemann added a comment to D18095: Add new table layout unit tests.

absolutely

Jan 15 2019, 11:04 AM · Calligra: 3.0

Jan 8 2019

boemann added a comment to D18095: Add new table layout unit tests.

Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed

Jan 8 2019, 1:29 PM · Calligra: 3.0

Dec 18 2018

boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

good investigative work, but I fear those tests are way too simple to dare apply the patch.

Dec 18 2018, 9:13 AM · Calligra: 3.0

Dec 17 2018

boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

And has anyone been able to produce a smaller 1 page example of the document - we are stumbling blindly here.
Do we have an odf snippet of the table that gives the problem?

Dec 17 2018, 12:11 PM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Still not the description i was looking for. I want to know what the extreme case is and what the resulting document should look like when we give up:

Dec 17 2018, 12:08 PM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words

Dec 17 2018, 11:36 AM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Dan I like your diff better - I don't think it's completely there but it's a better starting point

Dec 17 2018, 11:08 AM · Calligra: 3.0

Dec 14 2018

boemann added a comment to F6473096: x.diff.

it's not wrong to break off, because normally it should then try again with this row on the following page where there is more room. so this change is wrong and will break other cases

Dec 14 2018, 11:42 AM

Nov 5 2018

boemann accepted D16679: Words: Fix interop problem with LO/OO.
Nov 5 2018, 12:01 PM · Calligra: 3.0

Oct 22 2018

boemann added a comment to D16367: EnhancedPathShape: Shape is moved/resized on save/load.

As I recall it was one of the files in the huge dataset - there should be a bug on it

Oct 22 2018, 3:44 PM · Calligra: 3.0
boemann added a comment to D16367: EnhancedPathShape: Shape is moved/resized on save/load.

Yes as i recall that code was made to handle masks being exported correctly for OpenOffice or LO - I'd strongly prefer it not being thrown away like that

Oct 22 2018, 10:56 AM · Calligra: 3.0

Sep 26 2018

boemann added a comment to D15775: Make the item background color and page cache properties available from View component.

Ahh well in that case I don't mind and the words code looks clean enough - I'll let someone else review the components

Sep 26 2018, 8:50 PM · Calligra: 3.0
boemann added a comment to D15775: Make the item background color and page cache properties available from View component.

'm sorry but the background should not be settable - it's a document property at best and in fact paper is mostly white, so shouldn't even be settable

Sep 26 2018, 6:13 PM · Calligra: 3.0

Sep 24 2018

boemann accepted D15728: Try to avoid segfaults on shape factory not found.
Sep 24 2018, 1:26 PM · Calligra: 3.0

Sep 17 2018

boemann accepted D15549: Words: Save anchor info also for page-anchored shapes.
Sep 17 2018, 8:10 AM · Calligra: 3.0

Sep 16 2018

boemann added a comment to D15549: Words: Save anchor info also for page-anchored shapes.

Bah I can't remember this, but page anchored shapes don't have anchors as such, so I'm wondering what exactly is this writing to file?

Sep 16 2018, 9:04 AM · Calligra: 3.0

Sep 13 2018

boemann added a comment to D15412: [filters] Extend table lifetime.

No idea either - jaroslaw was the original author so maybe he can take a look

Sep 13 2018, 7:52 AM · Calligra: 3.0

Sep 12 2018

boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

I am more thinking of this place:

Sep 12 2018, 10:39 AM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

The idea is that if we are at the beginning of a new page we don't get in here (virginpage is true)
so we only reset if we are somewhere down on a page meaning we wil have more space to try on next time around
But we should reset if the only thing we fitted was the table header as a table headerrow should never be the only thing on a page

Sep 12 2018, 6:26 AM · Calligra: 3.0

Sep 11 2018

boemann added inline comments to D15428: [textlayout] Don't enter infinite loop when table is misfit.
Sep 11 2018, 8:08 PM · Calligra: 3.0

Sep 10 2018

boemann added a comment to D15403: {Style] Default sheets to white background.

No Idea about the code, but in general I have no problem with sheets respecting the palette

Sep 10 2018, 3:57 PM · Calligra: 3.0

Aug 31 2018

boemann accepted D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537.

I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working

Aug 31 2018, 8:25 AM · Calligra: 3.0

Aug 29 2018

boemann added a comment to D15111: [KoUnit] Let's show pixel units.

And none of that contradicts me saying it's not a general feature we want, but at most for Karbon, and that since we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway

Aug 29 2018, 2:48 PM · Calligra: 3.0
boemann added a comment to D15103: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>.

I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it

Aug 29 2018, 2:42 PM · Calligra: 3.0
boemann added a comment to D15111: [KoUnit] Let's show pixel units.

discard as a general solution - it doesn't make close to any sense for other than karbon when used as a tool to generate pixmaps in the end, and even then as I said it's a bad idea for various reasons

Aug 29 2018, 2:14 PM · Calligra: 3.0

Aug 28 2018

boemann added a comment to D15111: [KoUnit] Let's show pixel units.

The problem here is if they think they can place a line on a specific pixel position - we don't store coords as pixels - so it will not end being rendered to a specific pixel anyway - we will just end up with users not getting what they think they get, even in such a case as you describe

Aug 28 2018, 10:44 AM · Calligra: 3.0
boemann added a comment to D15111: [KoUnit] Let's show pixel units.

Yes, that is exactly how they could use it but, I think we are doing a disservice by offering such an option- there is no way an author can know the destination resolution and it will only apply to one destination.

Aug 28 2018, 10:36 AM · Calligra: 3.0
boemann added a comment to D15111: [KoUnit] Let's show pixel units.

What is the purpose of showing pixel units in general - pixels is not really a unit except in very specific cases - I'd saythis is very very wrong

Aug 28 2018, 9:14 AM · Calligra: 3.0

Jul 30 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16, no
Don't know what the last is supposed to be but it should probably have the same treatment

Jul 30 2018, 6:21 AM · Calligra: 3.0

Jul 22 2018

boemann accepted D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Thanks

Jul 22 2018, 4:01 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

except that its 1, 1½, 2 and not 1,2,3 then it looks good

Jul 22 2018, 3:30 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

yes and line 233-235 in the same file - fix that and we are ready to push

Jul 22 2018, 11:30 AM · Calligra: 3.0

Jul 21 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

in plugins/textshape/dialogs there is a file that handles line height (can't remember which exactly)

Jul 21 2018, 5:37 PM · Calligra: 3.0

Jun 2 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

So now we are just missing the texttool ui changes

Jun 2 2018, 7:35 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

no just:

Jun 2 2018, 7:25 PM · Calligra: 3.0

May 30 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Okay I basically believe you are right, but before I accept I ask you to make the corresponding changes in
textshape/dialogs/ParagraphIndentSpacing.cpp

May 30 2018, 4:52 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

I have my linux partiotion working again, so I'l take a look this weekend - is there a bug number and a test document somewhere ?

May 30 2018, 11:06 AM · Calligra: 3.0

May 28 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

This is not correct

May 28 2018, 6:20 PM · Calligra: 3.0

Feb 9 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

I have npt had time to try it out myself - and since you didn't make the test i asked for i have nothing new to tell

Feb 9 2018, 10:20 PM · Calligra: 3.0

Jan 14 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Ok please make the following test:

create 10 lines of text in LO
see where the text ends
change the lines to 101% and see it becomes just a little bit higher and not lower
Jan 14 2018, 3:35 PM · Calligra: 3.0

Jan 8 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

It looks indeed like the descend of the line is not used when figuring out the row height - try doubling the font size and see if the cut is still everything below the baseline?

Jan 8 2018, 9:27 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Hmm the line is inside a table, maybe that is what goes wrong - unfortunately the code is not easy to understand, but at least you can try and see why the value is different

Jan 8 2018, 9:24 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

No my linux installation has malfunctioned - could you please add some screenshots so i can see what the problem is more specifically?

Jan 8 2018, 8:51 PM · Calligra: 3.0

Jan 4 2018

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

can you please supply a test document then - is there a bug number?

Jan 4 2018, 5:43 AM · Calligra: 3.0

Dec 29 2017

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

see KoTextLayoutArea_paint.cpp line 250

Dec 29 2017, 2:52 PM · Calligra: 3.0
boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Yes you are more than welcome to try and fix the drawing - however the drawing is done like it is due to an issue with hoe qt renders compare to how it's supposed to look., so if we can fix both the original problem and the new without breaking anything else i'm all for fixing it

Dec 29 2017, 2:50 PM · Calligra: 3.0
boemann accepted D9497: [textlayout] Do not enter infinite loop when line rect is not valid.

Ok - good work

Dec 29 2017, 2:48 PM · Calligra: 3.0

Dec 28 2017

boemann added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

It's not a proper fix no - the height is correct - it's when drawing we have a problem.
The lines below will be drawn on top, and due to some other problem drawing lines will always clear the area first thus cutting away some of the text

Dec 28 2017, 9:13 PM · Calligra: 3.0
boemann requested changes to D9497: [textlayout] Do not enter infinite loop when line rect is not valid.
Dec 28 2017, 9:09 PM · Calligra: 3.0

Aug 21 2017

boemann accepted D7449: Spellcheck: Improve markup of missspelled words when dropcaps is used.

I like what you have done

Aug 21 2017, 5:01 PM · Calligra: 3.0

Aug 14 2017

boemann added a comment to D7303: SpellCheck: Fix markup rebasing when simple edits are done (one char added).

looks good to me

Aug 14 2017, 10:39 AM · Calligra: 3.0

Aug 11 2017

boemann added a comment to D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added).

But afaics the whole doc will be spellchecked, as the code iterates over
all blocks.

Aug 11 2017, 9:23 AM · Calligra: 3.0

Aug 10 2017

boemann added a comment to D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added).

Not quite

Aug 10 2017, 12:54 PM · Calligra: 3.0

Jul 22 2017

boemann accepted D6844: clazy fixes for kostore.

No need to review these very simple changes - just make sure you test before pushing

Jul 22 2017, 8:07 PM · Calligra: 3.0

Jan 24 2017

boemann accepted D4265: Default tool: Only create move command for shape(s) that has actually moved.

monospaced text

Jan 24 2017, 10:20 AM · Calligra: 3.0, KEXI
boemann accepted D4266: Default tool: Skip first move event to avoid accidental move during mouse button press.
Jan 24 2017, 10:18 AM · Calligra: 3.0, KEXI

Jan 18 2017

boemann accepted D3990: Numberstyles: Comment out not used format methods.
Jan 18 2017, 2:00 PM · Calligra: 3.0, KEXI

Jan 9 2017

boemann added a comment to T4851: Add shape docker: shape ordering.

Moving on I'd like to remove that docker in favor of having the create tool always visible and show the "add shape" stuff as the option widget of the tool

Jan 9 2017, 1:10 PM · Calligra: 3.0

Jan 6 2017

boemann added a comment to D3990: Numberstyles: Comment out not used format methods.

it has my blessing then but i'll let mecir give the final vote

Jan 6 2017, 8:51 AM · Calligra: 3.0, KEXI
boemann added a comment to D3990: Numberstyles: Comment out not used format methods.

I doubt words will start using these indeed but still wouldn't they make sense for sheets, and if so i think it makes more sense for the tests to not fail

Jan 6 2017, 8:37 AM · Calligra: 3.0, KEXI

Dec 10 2016

boemann accepted D3632: Words: Fix crash when adding connected text frame.

good work

Dec 10 2016, 7:18 PM · Calligra: 3.0, KEXI

Dec 6 2016

boemann added a comment to T4824: Words inline shape positioning.

yeah it's been like this sence 2.x series so nothing that needs to be fixed before release - also I plan on improving the placing UI - but have been focusing on bugs for a while

Dec 6 2016, 10:57 AM · Calligra: 3.0
boemann added a comment to T4824: Words inline shape positioning.

Well it can be changed by the user or do you suggest that we change the default ?

Dec 6 2016, 9:19 AM · Calligra: 3.0

Nov 30 2016

boemann added a comment to D3546: i18n: Add unit tests for string extractions.

Outside my knowledge area but would approve

Nov 30 2016, 5:30 PM · Calligra: 3.0, KEXI

Nov 24 2016

boemann added a comment to D3485: Words: Migrate from kde4 locations to kf5 locations.

ah ok yes then that should be fine

Nov 24 2016, 12:24 PM · Calligra: 3.0, KEXI
boemann added a comment to D3485: Words: Migrate from kde4 locations to kf5 locations.

templates that the user might have created comes to mind

Nov 24 2016, 12:14 PM · Calligra: 3.0, KEXI

Nov 23 2016

boemann accepted D3377: Words: redo "Change Shape Properties" command on every redo, not only first time.
Nov 23 2016, 10:10 PM · Calligra: 3.0, KEXI
boemann accepted D3468: Text layout: Fix crash due to use of invalid FrameIterator.

ok let us try it out

Nov 23 2016, 10:08 PM · Calligra: 3.0, KEXI

Nov 22 2016

boemann accepted D3455: ChartShape: Fix crash due to accessing stale pointers.
Nov 22 2016, 7:11 PM · Calligra: 3.0, KEXI

Nov 17 2016

boemann added a comment to D3401: Add a calligra 2 -> 3 migration class.

Great work ! havn't got any data to test with, but if you think it works i'm fine with pushing

Nov 17 2016, 4:27 PM · Calligra: 3.0, KEXI

Nov 16 2016

boemann added a comment to D3377: Words: redo "Change Shape Properties" command on every redo, not only first time.

That is a very scary thing to play with so I cant approve just like that - will have to test thoroughly later

Nov 16 2016, 10:11 AM · Calligra: 3.0, KEXI

Nov 7 2016

boemann accepted D3270: Words: Do not open a "Connect Text Frame" pane to non-text shapes.

Looks good

Nov 7 2016, 1:52 PM · Calligra: 3.0, KEXI

Sep 10 2016

boemann committed R108:79cb9aeba80c: Try to do the same fix for kwin (authored by boemann).
Try to do the same fix for kwin
Sep 10 2016, 5:47 AM
boemann committed R108:03a6e758b02a: Improved Oxygen window decoration - in composite it takes advantage of the new… (authored by boemann).
Improved Oxygen window decoration - in composite it takes advantage of the new…
Sep 10 2016, 5:45 AM
boemann committed R108:a2f75626222d: fix so that buttons also have correct bg color when colors are active !=… (authored by boemann).
fix so that buttons also have correct bg color when colors are active !=…
Sep 10 2016, 5:42 AM
boemann committed R108:939eabb94929: save memery by drawing directly onto screen and use the helper routine to… (authored by boemann).
save memery by drawing directly onto screen and use the helper routine to…
Sep 10 2016, 5:42 AM
boemann committed R108:94148e485fab: don't say we suppport Above and below others when we don't (authored by boemann).
don't say we suppport Above and below others when we don't
Sep 10 2016, 5:41 AM
boemann committed R108:7d867bec7297: Remove David Johnson from the copyright list as there isn't a single line of… (authored by boemann).
Remove David Johnson from the copyright list as there isn't a single line of…
Sep 10 2016, 5:40 AM
boemann committed R108:44254404d3eb: Use helper version of frame drawing (shared code with the style) (authored by boemann).
Use helper version of frame drawing (shared code with the style)
Sep 10 2016, 5:40 AM
boemann committed R108:1eab007b6dcf: Fix the problem of the window bg being drawn wrongly until the window is… (authored by boemann).
Fix the problem of the window bg being drawn wrongly until the window is…
Sep 10 2016, 5:40 AM
boemann committed R108:add504f45e65: Don't draw resize handles on windows that aren't resizable (authored by boemann).
Don't draw resize handles on windows that aren't resizable
Sep 10 2016, 5:40 AM
boemann committed R108:7ea8a8723263: Add a more distinctive outline to windows, making it easier to tell two… (authored by boemann).
Add a more distinctive outline to windows, making it easier to tell two…
Sep 10 2016, 5:39 AM
boemann committed R108:b0546e1c4cbf: Add hover effect to win deco buttons (authored by boemann).
Add hover effect to win deco buttons
Sep 10 2016, 5:38 AM
boemann committed R108:ef49ea5acfb7: Add dividing line below titlebar Fiddle with metrics of buttons ad text a bit… (authored by boemann).
Add dividing line below titlebar Fiddle with metrics of buttons ad text a bit…
Sep 10 2016, 5:38 AM
boemann committed R108:0751e36c91dc: Paint buttons of inactive windows different too Prepare for caching of those… (authored by boemann).
Paint buttons of inactive windows different too Prepare for caching of those…
Sep 10 2016, 5:38 AM
boemann committed R108:e39cbc096d61: Fix closebutton not being clickable by moving the mouse to the corner in… (authored by boemann).
Fix closebutton not being clickable by moving the mouse to the corner in…
Sep 10 2016, 5:38 AM