Differential D29224

[Task Manager] Avoid crash with QStringBuilder
ClosedPublic
Actions

Authored by broulik on Apr 27 2020, 11:22 AM.

Details

Reviewers
fvogt
anthonyfieroni
davidedmundson
Group Reviewers
Plasma
Commits
R119:0eba5453b9d4: [Task Manager] Avoid crash with QStringBuilder
Summary

The lambda returns a QStringBuilder which contains dangling references, see also QTBUG-47066

BUG: 420452
FIXED-IN: 5.18.5

Test Plan

5.18
Compiles

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 27 2020, 11:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 27 2020, 11:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 27 2020, 11:22 AM
anthonyfieroni accepted this revision.Apr 27 2020, 11:27 AM
This revision is now accepted and ready to land.Apr 27 2020, 11:27 AM
davidedmundson accepted this revision.Apr 27 2020, 11:40 AM
Closed by commit R119:0eba5453b9d4: [Task Manager] Avoid crash with QStringBuilder (authored by broulik). · Explain WhyApr 27 2020, 12:12 PM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Apr 27 2020, 3:18 PM

Good catch :)

Revision Contents
Changeset List

Diff 81335

View Options

applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp

Loading...