KHtml was only used for dom manipulation. Use instead QDom
Details
Details
- Reviewers
- None
- Group Reviewers
Calligra: 3.0 - Maniphest Tasks
- T11542: Remove KHTML
Compile, but I need to figure out why before and after this change the filter doesn't work.
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19437 Build 19455: arc lint + arc unit
Comment Actions
Just a quick tip, when posting things that are a work in progress as a diff (which, incidentally, is a great idea, both in general, and this!), adding "[WIP]" to the beginning of the diff's title is very handy, both for your own tracking, and for those going through the review lists :) (also just realised who you are, so i'm thinking you proooobably already know that ;) )
| filters/sheets/html/htmlimport.h | ||
|---|---|---|
| 58–59 | const ref here? | |
This comment was removed by anthonyfieroni.
Comment Actions
I forgot about this diff. Now that I looked again I found a flaw in the migrations: QDomDocument only supports valid XML files but there are valid HTML files that aren't valid XML files. So probably QDomDocument is not a solution :(