[RFC]: WIP: Make mobile broadband actually functional
Needs ReviewPublic
Actions

Authored by bshah on Mar 23 2020, 10:38 AM.

Details

Reviewers

jgrulich

Summary

Previously it was totally not-functional

Test Plan

currently still need to actually connect to APN

Repository

R116 Plasma Network Management Applet

Branch

bshah/mobile-broadband

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24096
Build 24114: arc lint + arc unit

Restricted Application added a reviewer: jgrulich. · View Herald Transcript

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bshah requested review of this revision.Mar 23 2020, 10:38 AM

broulik added inline comments.

libs/editor/mobileproviders.h
31	Needs `Q_OBJECT` macro
38	`explicit MobileProviders(QObject *parent = nullptr);`
mobile/broadband/mobilebroadbandsettings.cpp
109	`return QString();`
mobile/broadband/mobilebroadbandsettings.h
39	`const`
mobile/broadband/package/contents/ui/main.qml
70	You sure you want to use a `Repeater` for this? Or how large can that list become?
76	Doesn't this have to be bound to something?
77	Use `onToggled`
79	This is QML, not C++ :)

anthonyfieroni added inline comments.

mobile/broadband/package/contents/ui/main.qml
63–67	This should work enabled: mobileDataCheckbox.enabled checked : enabled
79	Yeah, use `console.log` for that.

		Path
M		libs/declarative/CMakeLists.txt (2 lines)
M		libs/declarative/qmlplugins.cpp (4 lines)
M		libs/editor/mobileproviders.h (26 lines)
M		libs/editor/mobileproviders.cpp (3 lines)
M		mobile/broadband/mobilebroadbandsettings.h (2 lines)
M		mobile/broadband/mobilebroadbandsettings.cpp (27 lines)
D	M	mobile/broadband/package/contents/ui/MobileSettings.qml (82 lines)
M		mobile/broadband/package/contents/ui/main.qml (54 lines)

Commit	Tree	Parents	Author	Summary	Date
1baf82e13cee	caff1b6a0d7a	6ce15f86b976	Bhushan Shah	[mobile/broadband] list APN for current provider of SIM (Show More…)	Mar 23 2020, 8:05 AM
6ce15f86b976	0d47289dc193	9ccad7eb96f9	Bhushan Shah	libs: make it possible to access MobileProviders from the qml (Show More…)	Mar 23 2020, 8:05 AM