[RFC]: WIP: Make mobile broadband actually functional
Needs ReviewPublic

Authored by bshah on Mon, Mar 23, 10:38 AM.

Details

Reviewers
jgrulich
Summary

Previously it was totally not-functional

Test Plan

currently still need to actually connect to APN

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
bshah/mobile-broadband
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24096
Build 24114: arc lint + arc unit
bshah created this revision.Mon, Mar 23, 10:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Mar 23, 10:38 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.Mon, Mar 23, 10:38 AM
broulik added inline comments.
libs/editor/mobileproviders.h
31

Needs Q_OBJECT macro

38

explicit MobileProviders(QObject *parent = nullptr);

mobile/broadband/mobilebroadbandsettings.cpp
109

return QString();

mobile/broadband/mobilebroadbandsettings.h
39

const

mobile/broadband/package/contents/ui/main.qml
70

You sure you want to use a Repeater for this? Or how large can that list become?

76

Doesn't this have to be bound to something?

77

Use onToggled

79

This is QML, not C++ :)