Differential D17462

Close Yakuake window when it loses focus under Wayland
Needs ReviewPublic
Actions

Authored by madcatx on Dec 9 2018, 9:33 PM.

Details

Reviewers
hein
Summary

Currently, if Yakuake loses focus when the user clicks away from the main window the window stays open even when the "Keep open" option is switched off. This happens only under Wayland, X11 behaves correctly.

Yakuake seems to be built a lot around X11-specific behavior. This is the only way I could think of that works correctly with Wayland.

Diff Detail

Repository
R369 Yakuake
Lint
Lint Skipped
Unit
Unit Tests Skipped
madcatx requested review of this revision.Dec 9 2018, 9:33 PM
madcatx created this revision.
madcatx added a comment.Dec 21 2018, 11:36 AM

Did this just get lost in the pipe or should I consider the patch rejected?

Just FTR, I have been using this for two weeks now every day and it works fine.

anthonyfieroni added a subscriber: anthonyfieroni.Jun 23 2020, 5:27 PM
anthonyfieroni added inline comments.
app/mainwindow.cpp
1022

I don't think it's needed.

1049

omit wid == 0 on Wayland it is.

anthonyfieroni added a comment.Jun 23 2020, 5:29 PM

New patches go in https://invent.kde.org/ You can fork https://invent.kde.org/utilities/yakuake apply patch and make pull request.

ognarb added a subscriber: ognarb.Jun 29 2020, 11:46 AM
In D17462#675576, @anthonyfieroni wrote:

New patches go in https://invent.kde.org/ You can fork https://invent.kde.org/utilities/yakuake apply patch and make pull request.

this patch is from 2018, so it's not new.

Revision Contents
Changeset List

PathPackages
Mapp/mainwindow.h (2 lines)
Mapp/mainwindow.cpp (14 lines)

Diff 47217

View Options

app/mainwindow.h

Loading...
View Options

app/mainwindow.cpp

Loading...