In D20797#455651, @ngraham wrote:

Why doesn't mouse wheel scrolling with with ScrollView?

Tried it out, looks good and is efficient.

In D19797#455008, @ngraham wrote:

Oh whoops, I had completely forgotten that you already had this revision open, sorry :(

Seems to make more sense for when the full path is shown, but my intuition is that right elision is more useful when it's just the folder name being shown.

Sidenote: units.smallSpacing wasn't a good solution, it ended up being 5 pixels wide on my laptop and 4 pixels wide on my PC. 4 pixels works consistently on both machines, and with various resolutions and scaling.

I'll land this tomorrow night (in 24hrs) since it's a prerequisite for fixing the PoTD plugin.

In D20672#452757, @ngraham wrote:

Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.

Makes more sense.

Nice! The last label is getting cut off for me with the default window size, but not sure what could be done about it.

Some other comments:

In D20612#452054, @GB_2 wrote:

In D20612#451981, @ngraham wrote:

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Just use implicitWidth and implicitHeight.

Here's what works:

Looks like you'll need to use twinFormLayouts. One unfortunate thing is you can't go "ha, I'll have all the layouts adjust to this specific one (with the longest label)". You'll need to have them all interlinked with one another because label length can change based on translation.

In D20577#450880, @ngraham wrote:

Thanks @filipf. I really, really like Elisa, and the code is very high quality, but with adequate low hanging UI fruit. It's a VDG hacker's dream come true. :)

add authorship info, @GB_2 you can do the same

In D19077#450746, @GB_2 wrote:

Fix "No Preview" icon

set sourceSize width and height (wow that's even better than mipmap)

Also the scaled down image quality isn't that great, can I use mipmap?

somewhat smarter code

I don't think it's my place to review this, but wanted to say I've been testing out Elisa these past few days and also felt like the sidebar text size would be better if it were smaller. Looks really nice in the screenshot!

In D19077#450657, @ngraham wrote:

I think that looks great!

No preview thumbnail looks like this:

• add a dummy "No preview available" rectangle when there is no preview image
• adjust shadows to mimick GridDelegate

+1 on making the OSD more efficient, I think it's the right direction to be going in.

@mart before you suggested we should do something like:

Huge improvement, Nate, and an excellent find. The rest of the reviewers can also have a look at my before and after photos for more proof:

Works as desired and is more efficient than anchoring to parent.right and then adding symmetrical units.smallSpacing * 6 right margin (since that's how the arrow is already anchored).

Looks good to me.

So what I'm seeing is that the gradient has been toned down, which also results in a slight color change in general. FWIW I like the older version more because the new one seems flat(ter) in comparison. Not too long ago someone in VDG actually remarked that the official logo is kind of flat so if possible it would be cool IMO if we could add a gradient to it and keep these icons the way they are.

Figured it out. We'll just export a formLayout alias property in all the individual plugins and everything will work.

twinFormLayouts: main.currentItem will stop working as soon as the wallpaper plugin in anything more complicated than having a single form layout. How do I specify that, yes, I want the currentItem, but only the form layout in that file?

This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything seems symmetric at least.

Hey @trmdi rooty's not participating in KDE at this point so he won't be able to do the review.

@hein what's your opinion on reducing the margins?

In D20257#443626, @ngraham wrote:

Yep, looks like the correct solution to me. Nice find!

apparently anchoring the stack view wasn't the only solution; settings spacing to 0 achieves the same result and doesn't spew out an "anchors in a layout" error

I know I'm not supposed to anchor items in a layout but this was the only solution I could find for now.

Is this actually what's been causing the following problem?

attempt to allow for commandeering of the revision

In D19209#443418, @GB_2 wrote:

@rooty Can you please reopen this?

In D20144#442451, @GB_2 wrote:

In D20144#441802, @ngraham wrote:

Hmm, the separator line feels like a bit much to me. How about just units.largeSpacing or units.gridUnit between them?

This is it without separator, I personally think it looks weird with that gap:

Let's see what others think.

In D19591#442740, @cfeck wrote:

Where is the check that this is done only for lossy formats? Here, PNG is saved uncompressed after this change.

Just throwing out another possible solution: the PlasmaComponents Highlight thingy:

In D19873#442385, @hein wrote:

Looks solid to me. Is your concern re vertical spacing still valid?

In D19822#442584, @ngraham wrote:

Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and conventional, I would recommend using the typical effect. :)

I think it would be good if someone from Plasma could have a look if this is okay, I did do a lot of modifications.

.

git...

rebase

In D19077#442288, @GB_2 wrote:

I like B too.
BTW, can "Background:" and the background selection button be centered like in a form layout?

In D19077#442281, @GB_2 wrote:

Ping

Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is:

Good fix, the lack of implicitHeight was leading to confusion before if there are even any wallpapers present.

In D19822#439336, @filipf wrote:

As for options overload, based on the reasoning above and the fact that we've recently split up the options and that we have space, I don't agree that this should be approached through the prism of UI clutter.

"We had so many options we went from one page to two pages, so now we can add more options!" :-)

Would something like this work?

In D19822#439568, @ngraham wrote:

In D19822#439567, @faridb wrote:

In D19822#439396, @ngraham wrote:

it would be nice if the "playing audio" icon itself changed to reflect the current status.

The icon already shows the current status:

Well... sort of. :) What I meant (and should have clearly stated the first time) was that it should use the audio-volume-muted icon when muted, rather than just becoming semi-transparent.

Yeah you want to ignore virtual devices or I guess this audio effects for eaxmple app would trigger the indicator?

I made the suggestion to have an option not because there might be something wrong with the feature, but because there is a subset of users who have a harder time finding their way around the UI - the non-tech say people and/or (now that I think of it) perhaps those with impaired vision who might not register the changed icon.

In D20066#439214, @zzag wrote:

Windows has this shortcut by default

Win+D?