Elide tab titles left so key information at the end of the string doesn't get cut off
ClosedPublic

Authored by ngraham on Apr 19 2019, 4:29 PM.

Details

Summary

Tab Titles currently elide right. Generally the more useful information is at the right
side of the string--even more so when full paths are being used.

BUG: 406569
FIXED-IN: 19.04.2

Test Plan
  • No change when tab titles don't get elided
  • When tabs show the full path and titles are elided, they're now useful:
  • When tabs don't show the full path and are elided, they're elided on the other side which seems maybe a tiny bit better, but at least no worse:

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 19 2019, 4:29 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 19 2019, 4:29 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 19 2019, 4:29 PM
filipf added a subscriber: filipf.Apr 19 2019, 4:40 PM

Seems to make more sense for when the full path is shown, but my intuition is that right elision is more useful when it's just the folder name being shown.

And looking at my folders I also get the same vague impression. Example: I have a folder called "Comparative Analysis" and another one called "Discourse Analysis". I need the first word or at least bits of it to distinguish between the folders, whereas having "...Analysis" wouldn't work out.

ngraham planned changes to this revision.Apr 19 2019, 4:46 PM

Yeah, that makes sense. I'll make it only elide left when showing the full path.

ngraham updated this revision to Diff 57958.May 12 2019, 10:50 PM

Only elide left when showing full paths

Ready for re-review now.

elvisangelaccio accepted this revision.May 19 2019, 9:32 AM
elvisangelaccio added a subscriber: elvisangelaccio.

Don't forget to bump the fixed-in to 19.04.2 ;)

This revision is now accepted and ready to land.May 19 2019, 9:32 AM
ndavis added a subscriber: ndavis.EditedMay 19 2019, 7:07 PM

Can you elide up to the forward slash and not after unless there is no room? Like this:

I just think that looks better.

ngraham edited the summary of this revision. (Show Details)May 20 2019, 1:10 PM

Can you elide up to the forward slash and not after unless there is no room? Like this:

I just think that looks better.

Not easily, I'm afraid. Maybe material for a follow-up patch.

This revision was automatically updated to reflect the committed changes.