rooty (Root)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 21 2018, 12:02 AM (30 w, 3 d)
Availability
Available

Recent Activity

Yesterday

rooty added a comment to D18379: Add tools icon.

nice, +1

Sat, Jan 19, 10:15 AM · Frameworks

Fri, Jan 18

rooty added a comment to D18377: Update blur to be more natural.

a definite +1

Fri, Jan 18, 11:46 PM · KWin

Thu, Jan 17

rooty added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

Hey if in any way possible: **medInria**
It's an up and coming medical imaging platform.

Thu, Jan 17, 10:28 PM · KDE Promo
rooty added a comment to T10325: 5.16 Login screen redesign.

We do have our own style though. How do you guys feel about just improving on the current design, because unlike any other OS or desktop environment I've used so far (including Windows that requires an extra swipe, macOS that has its date and time tucked away, gdm/deepin that don't seem to entertain the notion at all), our current login screen doubles as a lock screen already (hence there's no need for the wallpaperfader either). Something along the lines of:

Thu, Jan 17, 3:30 AM · Plasma, VDG

Tue, Jan 15

rooty added a comment to T10325: 5.16 Login screen redesign.

hey guys i have a relatively simple question

Tue, Jan 15, 3:58 AM · Plasma, VDG

Sun, Jan 13

rooty added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

After much discussion in the VDG room, we decided to put this on hold and revisit it for 5.16. The problem here is that we're worried that this change won't be enough to stop people from wanting to redesign it yet again, and we don't want to produce change fatigue here. We're going to focus on producing a timeless design that's good enough that nobody wants to redesign it anymore, which is ultimately the best sign that you have the design right.

Sun, Jan 13, 9:40 PM · Plasma
rooty added a comment to T8871: Systematic KCM reorganisation.

Cool. So essentially, all my proposal does is take everything currently under the "Look and Feel" section and put it at the top level. Not so radical after all! :)

Sun, Jan 13, 7:14 PM · Plasma: KCM Redesign, VDG
rooty added a comment to T8871: Systematic KCM reorganisation.

no i meant, will we be left with a sidebar saying only Icons
hence Icons Icons :D

Sun, Jan 13, 7:13 PM · Plasma: KCM Redesign, VDG
rooty added a comment to T8871: Systematic KCM reorganisation.

can we? delete the section Emoticons before the merging? is that doable?

Sun, Jan 13, 7:11 PM · Plasma: KCM Redesign, VDG
rooty added a comment to T8871: Systematic KCM reorganisation.

So in reality, this would be the proposal if we were to do it today:

Sun, Jan 13, 7:10 PM · Plasma: KCM Redesign, VDG
rooty added a comment to T8871: Systematic KCM reorganisation.

So for the appearance category, here's my proposal:

Appearance
==========
- Global Theme
- Plasma Style
- Application Style
- Fonts
- Icons
- Colors
- Cursors
- Window Decorations
- Splash Screen
Sun, Jan 13, 7:06 PM · Plasma: KCM Redesign, VDG

Sat, Jan 12

rooty added a comment to D18206: Improve the Look and Feel KCM.

+1 from me
if you want you could drop the article by the way and make it "Choose Look and Feel theme"
it's like "Configure Network Settings" vs "Configure the Network Settings"

Sat, Jan 12, 5:37 PM · Plasma

Fri, Jan 11

rooty added a comment to D17975: [Notifications] Add padding to notifications.

I believe you'll need to file a sysadmin ticket to get that changed.

Fri, Jan 11, 6:43 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

@rooty if you want to re-apply for a commit account, I'll approve it.

Fri, Jan 11, 5:44 PM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Use units.smallSpacing for padding consistently except when bodyText.lineCount > 1, spruce things up

Fri, Jan 11, 12:25 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

You were right! Thank you so much, it was so much easier when I started thinking about it as a math problem rather than a design problem. I'm going to upload another diff, I hope this one stands up to scrutiny.

Fri, Jan 11, 12:24 PM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Fix lower border cutoff for fonts > 10 pt

Fri, Jan 11, 12:08 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

How do we get the icon size to increase in proportion to increasing font size

See units.cpp in plasma-framework. It's complex. I don't think that's a relevant topic you need to go down

Fri, Jan 11, 12:04 AM · Plasma

Thu, Jan 10

rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Correct padding with just icon + heading + no text, make icon padding even for 10 pt sized fonts other than Noto Sans

Thu, Jan 10, 11:50 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

^ Yes, it's important to note that additional (and unwanted) padding underneath the icon can happen with master, while this patch can add the same above the icon. From my layman's understanding, there is nothing solid and absolute values are based on.

Thu, Jan 10, 10:32 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

With this patch:

Thu, Jan 10, 8:49 PM · Plasma
rooty added a comment to D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications.

Visibility restored to public per request of the Community.

Thu, Jan 10, 7:28 PM
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Is there a way to give the icon itself padding? I've been using anchors but there's nothing I can think of to anchor it to? If I anchor it to the notification text in any way, I can add a margin, sure, but it gets stretched out beyond belief if there's too much text.

Thu, Jan 10, 3:55 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

There is one small problem, with almost every version I've submitted so far.
The padding above the icon and below the icon is the same (7 px with 1x scaling) if Noto Sans is used as the default font, which is basically perfect.

Thu, Jan 10, 2:12 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Remove unnecessary comments

Thu, Jan 10, 2:07 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Use margin in bottomPart instead

Thu, Jan 10, 2:07 AM · Plasma
rooty abandoned D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications.

Another arcanist blunder, my apologies

Thu, Jan 10, 2:03 AM
rooty removed a project from D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications: Plasma.
Thu, Jan 10, 2:02 AM
rooty changed the visibility for D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications.
Thu, Jan 10, 2:02 AM
rooty requested review of D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications.
Thu, Jan 10, 2:02 AM
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Hey @davidedmundson I know I'm a little late but should I use your suggestion instead? I just figured out how to do it using Layout.bottomMargin :D

Thu, Jan 10, 1:12 AM · Plasma

Wed, Jan 9

rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Change certain integers to decimals for more even padding; fix padding in heading-only notifications

Wed, Jan 9, 9:13 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

@broulik If the consensus is that the notifications should stay "tight" (no padding), I'd very much prefer to add padding to the left and right of the icon (it's really stuck-on right now), and to push the notification icon down a bit if there's a bodyText.lineCount > 1 to prevent the icon from towering over the heading.

Wed, Jan 9, 11:48 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

FWIW if I backport the spacings and margins prior to D3560 it works great for me. The symmetry around the icon is better than with this diff. (only NotificationItem.qml is modified)

This diff:

Old:

Wed, Jan 9, 11:39 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

We explicitly removed the padding in Plasma 5.9 to reduce popup sizes, this effectively reverts this decision…

Wed, Jan 9, 11:32 AM · Plasma
rooty updated the diff for D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels.

Fix blunder and bring back search field, place "Search..." in search field

Wed, Jan 9, 3:39 AM · Frameworks
rooty added a comment to D17975: [Notifications] Add padding to notifications.

BTW, if you want a neater solution: (though consider this optional)
Instead, use Layout.topMargin on the titleBar and Layout.bottomMargin on the lowerPart.

Wed, Jan 9, 2:28 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

I wouldn't want the attitude of "breaking other themes is unfortunate, but.." becoming a pattern because openness to customization is our main selling point.

Wed, Jan 9, 12:21 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

@davidedmundson I've tried using

Wed, Jan 9, 12:10 AM · Plasma

Tue, Jan 8

rooty added a comment to D17975: [Notifications] Add padding to notifications.

I'd much rather if there was some padding added in Breeze and then you only fix the wrong spacing to right of the notification. Even if that wouldn't work, I don't get the sense we've fully explored other solutions yet.

Tue, Jan 8, 11:54 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

why every notification width is too wide
why its not resize depends on the content on it with some little padding

Tue, Jan 8, 11:32 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Wouldn't it be better to somehow add padding globally?

Tue, Jan 8, 11:31 PM · Plasma
rooty retitled D17975: [Notifications] Add padding to notifications from [WIP, Notifications] Add padding to notifications to [Notifications] Add padding to notifications.
Tue, Jan 8, 10:49 PM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

This is no longer WIP, right?

Tue, Jan 8, 10:49 PM · Plasma
rooty added a comment to D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.

wow scrolling down took a while haha
sure fine with me, crop em (except for Lake Bled?)

Tue, Jan 8, 12:36 PM · Plasma
rooty added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

a thousand times yes... this is amazing

Tue, Jan 8, 3:22 AM · Plasma
rooty updated the test plan for D17975: [Notifications] Add padding to notifications.
Tue, Jan 8, 1:43 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Could you update the images in the Summary section instead of posting new ones in comments? The visual history of the patch is not really important to preserve, and having the images on top always be current makes reviewing it much easier. Thanks!

Tue, Jan 8, 1:34 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

I removed "0.75 * units.smallSpacing" because it's not an integer - the result is that the margins are slightly uneven, but considering they weren't ever entirely even, and the difference between the margins gets more pronounced with increasing font size (and scaling factor), but isn't noticeable, maybe it's a nonissue?

Tue, Jan 8, 1:31 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Use integers/halves and line counts

Tue, Jan 8, 1:29 AM · Plasma

Mon, Jan 7

rooty added a comment to D17975: [Notifications] Add padding to notifications.

Hey guys, I feel silly asking this but I'm using a different computer right now - how do I get this computer's arcanist to lock onto and update this diff (instead of creating an entirely new diff...)?

Mon, Jan 7, 11:50 PM · Plasma
rooty added a comment to D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.

Still not sure if we should have also included the grassland

Mon, Jan 7, 10:17 PM · Plasma
rooty added inline comments to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Mon, Jan 7, 9:31 PM · Frameworks
rooty added inline comments to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Mon, Jan 7, 5:47 PM · Frameworks
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Mon, Jan 7, 5:47 PM · VDG, Plasma
rooty added a task to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:47 PM · Frameworks
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18048: [Connections] Add search ellipsis to network connection search.
Mon, Jan 7, 5:47 PM · VDG, Plasma
rooty added a task to D18048: [Connections] Add search ellipsis to network connection search: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:47 PM · Plasma
rooty added a task to D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:47 PM · Plasma
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time.
Mon, Jan 7, 5:47 PM · VDG, Plasma
rooty added a task to D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:47 PM · Frameworks
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels.
Mon, Jan 7, 5:47 PM · VDG, Plasma
rooty added a task to D18045: [kio] Add ellipsis to search label in Cookies section: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:46 PM · Frameworks
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18045: [kio] Add ellipsis to search label in Cookies section.
Mon, Jan 7, 5:46 PM · VDG, Plasma
rooty added a revision to T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG: D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG.
Mon, Jan 7, 5:46 PM · VDG, Plasma
rooty added a task to D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG.
Mon, Jan 7, 5:46 PM · Plasma
rooty added reviewers for D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG: VDG, Plasma, plasma-devel.
Mon, Jan 7, 5:45 PM · Plasma
rooty added reviewers for D18045: [kio] Add ellipsis to search label in Cookies section: VDG, Plasma, kde-frameworks-devel.
Mon, Jan 7, 5:45 PM · Frameworks
rooty added reviewers for D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels: VDG, Plasma, kde-frameworks-devel.
Mon, Jan 7, 5:45 PM · Frameworks
rooty added reviewers for D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time: VDG, Plasma.
Mon, Jan 7, 5:45 PM · Plasma
rooty added reviewers for D18048: [Connections] Add search ellipsis to network connection search: VDG, Plasma.
Mon, Jan 7, 5:44 PM · Plasma
rooty added reviewers for D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector: VDG, Plasma, kde-frameworks-devel.
Mon, Jan 7, 5:44 PM · Frameworks
rooty requested review of D18048: [Connections] Add search ellipsis to network connection search.
Mon, Jan 7, 5:24 PM · Plasma
rooty requested review of D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time.
Mon, Jan 7, 5:23 PM · Plasma
rooty requested review of D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels.
Mon, Jan 7, 5:14 PM · Frameworks
rooty requested review of D18045: [kio] Add ellipsis to search label in Cookies section.
Mon, Jan 7, 5:10 PM · Frameworks
rooty added a comment to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.

I don't think so, next time when you can push this type of change (ellipsis) directly, there is a task about it if you know.

Mon, Jan 7, 5:09 PM · Frameworks
rooty requested review of D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG.
Mon, Jan 7, 5:08 PM · Plasma
rooty added a comment to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.

+1

Mon, Jan 7, 5:04 PM · Frameworks
rooty requested review of D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Mon, Jan 7, 4:59 PM · Frameworks
rooty added a comment to D17906: [kirigami] Do not use light font styles for headings (2/3).
In D17906#388052, @mart wrote:

can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger?

Mon, Jan 7, 2:44 PM · Kirigami

Sun, Jan 6

rooty added a comment to D17975: [Notifications] Add padding to notifications.

@davidedmundson Is there anything I can put in the code to get the icons to scale properly? this is a screenshot of master (not this patch):

Sun, Jan 6, 9:05 AM · Plasma

Sat, Jan 5

rooty added a comment to T10220: Improve the default selection of photographic wallpapers.

What about cropping the images to a 5k or 4k resolution?

I tested with the Bled wallpaper, which is fairly oddly dimensioned, and it wasn't important. It still scaled great to 16:9. I think we can just leave the pictures at their max. size.

Besides, enforcing strict 5k or 4k resolution would lead to unfortunate actions such as having to shrink Bled to 4k size since it's dimensions are 5426x2713 and 5k is 5120×2880.

Sat, Jan 5, 11:58 PM · Breeze, Plasma, VDG
rooty added a comment to T10220: Improve the default selection of photographic wallpapers.

Yeah and the thumbnails that Plasma creates are actually scaled the way they are on the desktop.

Sat, Jan 5, 11:52 PM · Breeze, Plasma, VDG
rooty renamed T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible from Make KCMs consistent and apply the KDE HIG on them as much as possible to Make KCMs consistent and apply the KDE HIG to them as much as possible.
Sat, Jan 5, 2:30 PM · VDG
rooty added a comment to D17975: [Notifications] Add padding to notifications.

A bit more padding is good!

  1. Making this pixel-perfect with every combination of font and font size is going to be impossible sadly. With that in mind, the most elegant design is one that makes this not a problem, because it doesn't have to be pixel-perfect and all the baselines are at least aligned.
Sat, Jan 5, 4:54 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Change shift in height of notification to an integer

Sat, Jan 5, 3:41 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Can you clarify what the ultimate visual goal here? Clearly defining that might help to tighten up your code and thought process.

Also, what remaining issues make this WIP? I find that the Phabricator NOTE: markup works well for this. See https://secure.phabricator.com/book/phabricator/article/remarkup/

Sat, Jan 5, 3:26 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Add margins to the right of the buttons on the right border

Sat, Jan 5, 1:25 AM · Plasma
rooty updated the test plan for D17975: [Notifications] Add padding to notifications.
Sat, Jan 5, 1:24 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.

Okay, so I figured out how to add padding to the buttons as well, by adding a right margin to the mainLayout part (hence the deleted comment describing how I couldn't figure it out, my bad):

Sat, Jan 5, 1:23 AM · Plasma
rooty added reviewers for D17975: [Notifications] Add padding to notifications: VDG, Plasma, ngraham.
Sat, Jan 5, 12:55 AM · Plasma
rooty added a comment to D17975: [Notifications] Add padding to notifications.
Sat, Jan 5, 12:55 AM · Plasma
rooty updated the diff for D17975: [Notifications] Add padding to notifications.

Correct spelling

Sat, Jan 5, 12:33 AM · Plasma
rooty updated the test plan for D17975: [Notifications] Add padding to notifications.
Sat, Jan 5, 12:32 AM · Plasma
rooty requested review of D17975: [Notifications] Add padding to notifications.
Sat, Jan 5, 12:31 AM · Plasma

Fri, Jan 4

rooty added a comment to D17884: [effects] Enable touchpoints by default.

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

It had been like that for several years and nobody cares so far. Let's not make a fuzz about nothing.

Fri, Jan 4, 10:09 PM · KWin
rooty added a comment to T10190: (Re)define modes when editing panels and widgets.

We can actually do this by having two modes, Edit and Locked, without an Unlocked intermediate. You enter Edit and that unlocks things automatically, and once you're done you close it (and the elements lock automatically).

Fri, Jan 4, 12:11 AM · VDG, Plasma
rooty added a comment to M144: New panel right click context menu.

I like the idea but how do you feel about listing them as:

Fri, Jan 4, 12:02 AM · VDG, Plasma

Thu, Jan 3

rooty added a comment to T10220: Improve the default selection of photographic wallpapers.

I think they came out looking quite nice after being cropped. :D

Thu, Jan 3, 10:25 PM · Breeze, Plasma, VDG