Fix incorrect vertical spacing between main layout and individual wallpaper plugins
ClosedPublic

Authored by filipf on Thu, Apr 4, 10:07 PM.

Details

Summary

As elaborated in D19873 the vertical spacing between the master form layout and a specific wallpaper plugin was always too big. By setting the main column layout's spacing the 0 we avoid the added vertical space.

Test Plan

Before:

After:

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Thu, Apr 4, 10:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Apr 4, 10:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Thu, Apr 4, 10:07 PM
filipf retitled this revision from Fix incorrent vertical spacing between main layout and individual wallpaper plugins to Fix incorrect vertical spacing between main layout and individual wallpaper plugins.Thu, Apr 4, 10:09 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: hein, mart, Plasma, ngraham.
filipf edited the test plan for this revision. (Show Details)

I know I'm not supposed to anchor items in a layout but this was the only solution I could find for now.

filipf updated this revision to Diff 55443.Thu, Apr 4, 10:37 PM

apparently anchoring the stack view wasn't the only solution; settings spacing to 0 achieves the same result and doesn't spew out an "anchors in a layout" error

filipf edited the summary of this revision. (Show Details)Thu, Apr 4, 10:38 PM
ngraham accepted this revision.Fri, Apr 5, 1:55 AM

Yep, looks like the correct solution to me. Nice find!

This revision is now accepted and ready to land.Fri, Apr 5, 1:55 AM

Yep, looks like the correct solution to me. Nice find!

One step closer to perfection!

I think it's the correct solution as well. Maybe to elaborate better for the other reviewers:

We have 2 Kirigami form layouts within a column layout. The Kirigami layouts have their own spacing. However, the column layout adds unwanted spacing between the two form layouts because by default it's spacing is set to 5. To have the two form layouts seamlessly join with one another, we then just need to remove the column layout's spacing; the form layouts' spacing will suffice.

davidedmundson accepted this revision.Fri, Apr 5, 11:37 AM
This revision was automatically updated to reflect the committed changes.