Shows a System Tray icon when the microphone is being used.
It also indicates the default microphone volume as well as middle click to mute and wheel for adjusting the volume.
The microphone icon only shows muted when *all* microphones are muted.
Details
- Reviewers
drosca ngraham - Group Reviewers
Plasma VDG - Commits
- R115:2d82429e5299: Add microphone indicator
Tried both alsa and pulseaudio apps, everything I tried ended up spawning an indicator.
Didn't manage to read raw from /dev/snd/...
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
What happens if 2 applications are using it? Maybe it would make sense to include the application icon as an overlay?
What happens if 2 applications are using it?
It shows "foo, bar are using the microphone"
Maybe it would make sense to include the application icon as an overlay?
For the tooltip, maybe.
Looks good.
Personally I would work directly with the SourceOutputMap (and maybe duplicate it as list here in MicrophoneIndicator) instead of working with the models. I'm not saying that it's wrong / you should change it though, just a note.
src/qml/microphoneindicator.cpp | ||
---|---|---|
43 | Just ignore virtual streams? We only care about real devices here. | |
199 | newline | |
203 | qAsConst(m_mutedIndices) | |
254 | newline | |
275 | Yes, this should never be empty. | |
src/qml/plugin.cpp | ||
67 | Any reason why you used singleton? |
Yeah you want to ignore virtual devices or I guess this audio effects for eaxmple app would trigger the indicator?
src/qml/plugin.cpp | ||
---|---|---|
67 | So that we don't end up with multiple Status Notifier Items. This makes the indicator shared between all applets |