[fifteen-puzzle] Modernize settings window
AbandonedPublic

Authored by filipf on Mar 15 2019, 11:02 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Summary

Fifteen-clock's configuration window is ported to QQC2 and Kirigami.FormLayout. Setting are reorganized in a way that makes more sends. Enabled properties have also been added because some options are irrelevant when others are used.

Test Plan

Before:

After:

Everything worked.

Diff Detail

Repository
R114 Plasma Addons
Branch
modernize-15clock-settings (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9645
Build 9663: arc lint + arc unit
filipf created this revision.Mar 15 2019, 11:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2019, 11:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 15 2019, 11:02 PM
filipf edited the summary of this revision. (Show Details)Mar 15 2019, 11:04 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
filipf updated this revision to Diff 53983.Mar 15 2019, 11:29 PM

forgot anchors again

+1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me.

This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe?

filipf retitled this revision from [fifteen-clock] Modernize settings window to [fifteen-puzzle Modernize settings window.Mar 16 2019, 5:03 PM
filipf retitled this revision from [fifteen-puzzle Modernize settings window to [fifteen-puzzle] Modernize settings window.

+1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me.

This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe?

So something like this?

But TBH I don't like how Kirigami section headings are positioned (how left they are) when using FormData.label. They also probably get extended much more with German translations. It's nicer IMO when using labels in a row layout instead:

rooty added a subscriber: rooty.Mar 16 2019, 5:15 PM

I'm not sure - the sections are so small the headings make it sound redundant (Numbers, Show numbers, Number color), I'd add spaces instead.

Size: 4

[checkbox] Show numbers
Number color:

Piece color:
[checkbox] Use custom image for pieces
--path--

Implicit could work (Numbers --- Show? Color?) but explicit might be better.

filipf abandoned this revision.Tue, Apr 23, 7:56 AM

Oh whoops, I had completely forgotten that you already had this revision open, sorry :(

Oh whoops, I had completely forgotten that you already had this revision open, sorry :(

No prob, I should have been done with it sooner :P