Make location of "Lock Widgets" and "Remove Panel" buttons more obvious
ClosedPublic

Authored by GB_2 on Mar 31 2019, 5:04 PM.

Details

Summary

BUG: 406079

Move these two buttons to the left/top of the panel edit mode toolbar.

Horizontal:

Vertical:

Test Plan

Open the panel edit mode.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Mar 31 2019, 5:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2019, 5:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Mar 31 2019, 5:04 PM
GB_2 edited the summary of this revision. (Show Details)Mar 31 2019, 5:21 PM

+1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right next to Lock Widgets, which is non-destructive. Seems like it would be easy to mis-click and accidentally blow away your panel--especially on touch. At a minimum I would recommend adding some padding between it and adjacent non-destructive buttons. And maybe Lock Widgets should be moved over to the right side. Thoughts?

GB_2 added a comment.Mar 31 2019, 6:52 PM

+1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right next to Lock Widgets, which is non-destructive. Seems like it would be easy to mis-click and accidentally blow away your panel--especially on touch. At a minimum I would recommend adding some padding between it and adjacent non-destructive buttons. And maybe Lock Widgets should be moved over to the right side. Thoughts?

I'm not sure about moving Lock Widgets to the other side. When horizontal, the 4 buttons on the right/bottom will take up a lot of space, especially in wordy languages or when using a small screen resolution, causing them to be changed into icons only buttons, which we should avoid. 4 buttons on one side and 1 on the other side would also look quite unbalanced.

Maybe just switch the buttons' positions and add a spacer between them, then?

GB_2 added a comment.EditedMar 31 2019, 7:03 PM

Maybe just switch the buttons' positions and add a spacer between them, then?

I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of those 2 buttons, you can accidentally remove the panel when trying to close the panel edit mode (vertical) or trying to resize the panel (horizontal).
One thing to note though, you can always click undo after removing the panel ;-)

Hmm, maybe well then just with a spacer between them then?

GB_2 updated this revision to Diff 55225.Apr 1 2019, 7:13 PM

Add separator and spacer between the two buttons

GB_2 edited the summary of this revision. (Show Details)Apr 1 2019, 7:20 PM

Hmm, the separator line feels like a bit much to me. How about just units.largeSpacing or units.gridUnit between them?

Hmm, the separator line feels like a bit much to me. How about just units.largeSpacing or units.gridUnit between them?

This is it without separator, I personally think it looks weird with that gap:


Let's see what others think.

filipf added a comment.Apr 3 2019, 2:48 PM
In D20144#442451, @GB_2 wrote:

Hmm, the separator line feels like a bit much to me. How about just units.largeSpacing or units.gridUnit between them?

This is it without separator, I personally think it looks weird with that gap:


Let's see what others think.

+1 for the idea of the patch

Gap - looks weird to me as well

Separator - it's okay IMO

If we really wanted to be sure we could have a confirmation dialog for deleting the panel, although the Undo button you get in a notification somewhat lessens the need for it.

ngraham accepted this revision.Apr 3 2019, 3:08 PM

All right, all right, let's go with the separator. :)

This revision is now accepted and ready to land.Apr 3 2019, 3:08 PM
This revision was automatically updated to reflect the committed changes.