faridb (Farid Boudedja)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 29 2018, 1:12 PM (76 w, 2 d)
Availability
Available

Recent Activity

Aug 21 2019

faridb committed R596:39a18829d0d7: Hide writing progress when KAuth job finishes with error (authored by faridb).
Hide writing progress when KAuth job finishes with error
Aug 21 2019, 8:24 PM
faridb committed R596:8bc2c9c4e063: Fix success message not showing at the end of writing (authored by faridb).
Fix success message not showing at the end of writing
Aug 21 2019, 8:24 PM
faridb committed R596:89b6f9853240: Merge master branch from cgit (authored by faridb).
Merge master branch from cgit
Aug 21 2019, 1:45 PM
faridb committed R596:1dfd8afffe6c: Clean usb drive combobox code (authored by faridb).
Clean usb drive combobox code
Aug 21 2019, 1:45 PM
faridb committed R596:f1f62233c53a: Update project version (authored by faridb).
Update project version
Aug 21 2019, 1:45 PM
faridb committed R596:059cdcf57ea8: Remove test application (authored by faridb).
Remove test application
Aug 21 2019, 1:45 PM
faridb committed R596:dec905173f38: Add missing copyright headers (authored by faridb).
Add missing copyright headers
Aug 21 2019, 1:45 PM
faridb committed R596:51030c3e956a: Show placeholder text if no USB drive is plugged in (authored by faridb).
Show placeholder text if no USB drive is plugged in
Aug 21 2019, 1:45 PM
faridb committed R596:95c7872d0e03: Hide writing progress when writing is cancelled by the user (authored by faridb).
Hide writing progress when writing is cancelled by the user
Aug 21 2019, 1:45 PM
faridb committed R596:f964c783eff1: Add back and close button to success widget (authored by faridb).
Add back and close button to success widget
Aug 21 2019, 1:45 PM
faridb committed R596:5479f39b7dc0: Fix finished signal not emitted by IsoVerifier (authored by faridb).
Fix finished signal not emitted by IsoVerifier
Aug 21 2019, 1:45 PM
faridb committed R596:ec1a7c8f4acc: Remove old ISO verification code (authored by faridb).
Remove old ISO verification code
Aug 21 2019, 1:45 PM
faridb committed R596:52af9e2ad77b: Emit finished signal from the verification method (authored by faridb).
Emit finished signal from the verification method
Aug 21 2019, 1:45 PM
faridb committed R596:7b0049334de9: Verify Netrunner ISO using SHA256 checksum input by the user (authored by faridb).
Verify Netrunner ISO using SHA256 checksum input by the user
Aug 21 2019, 1:45 PM
faridb committed R596:1de5782ab79f: Search for sum in SHA256SUMS file before calculating it (authored by faridb).
Search for sum in SHA256SUMS file before calculating it
Aug 21 2019, 1:45 PM
faridb committed R596:4466cf3a03d6: Fix IsoVerifier not emitting finished signal in some cases (authored by faridb).
Fix IsoVerifier not emitting finished signal in some cases
Aug 21 2019, 1:45 PM
faridb committed R596:38fb6dd5e264: Verify Ubuntu ISO image using SHA256SUMS file (authored by faridb).
Verify Ubuntu ISO image using SHA256SUMS file
Aug 21 2019, 1:45 PM
faridb committed R596:7d186f55bf72: Show warning message on ISO verification failure (authored by faridb).
Show warning message on ISO verification failure
Aug 21 2019, 1:45 PM
faridb committed R596:5c80c9909a5b: Verify ISO image using SHA256SUMS file (Kubuntu) (authored by faridb).
Verify ISO image using SHA256SUMS file (Kubuntu)
Aug 21 2019, 1:45 PM
faridb committed R596:3db8aa571100: Include missing library (authored by faridb).
Include missing library
Aug 21 2019, 1:45 PM
faridb committed R596:55948db87b8d: Verify ISO image using .sig file (Arch Linux & Neon) (authored by faridb).
Verify ISO image using .sig file (Arch Linux & Neon)
Aug 21 2019, 1:45 PM
faridb committed R596:241c920c8ed9: Set writing flag to false when writing is complete (authored by faridb).
Set writing flag to false when writing is complete
Aug 21 2019, 1:45 PM
faridb committed R596:23f6408624b8: Do not compile KAuth specific methods on Windows (authored by faridb).
Do not compile KAuth specific methods on Windows
Aug 21 2019, 1:45 PM
faridb committed R596:e294c8c44fee: Remove main dialog (authored by faridb).
Remove main dialog
Aug 21 2019, 1:45 PM
faridb committed R596:d4d8aed437c8: Add manifest to require administrator previleges on Windows (authored by faridb).
Add manifest to require administrator previleges on Windows
Aug 21 2019, 1:45 PM
faridb committed R596:06d0e05872fd: Reimplement close event of the main window (authored by faridb).
Reimplement close event of the main window
Aug 21 2019, 1:45 PM
faridb committed R596:dfec65f4008f: Implement drag & drop in MainWindow (authored by faridb).
Implement drag & drop in MainWindow
Aug 21 2019, 1:45 PM
faridb committed R596:c1bef22f3c57: Clean KAuth helper (authored by faridb).
Clean KAuth helper
Aug 21 2019, 1:45 PM
faridb committed R596:af201abd687d: Enable external progress bar on supported platforms (authored by faridb).
Enable external progress bar on supported platforms
Aug 21 2019, 1:45 PM
faridb committed R596:250e56ac53c0: Use new signals and slots syntax (authored by faridb).
Use new signals and slots syntax
Aug 21 2019, 1:45 PM
faridb added a reverting change for R596:6d91c46340e7: Use a preprocessor definition to enable KAuth: R596:65aa25a19285: Revert "Use a preprocessor definition to enable KAuth".
Aug 21 2019, 1:45 PM
faridb committed R596:65aa25a19285: Revert "Use a preprocessor definition to enable KAuth" (authored by faridb).
Revert "Use a preprocessor definition to enable KAuth"
Aug 21 2019, 1:45 PM
faridb committed R596:ec9ccc9d2f7f: Use KAuth to write ISO image on Linux (authored by faridb).
Use KAuth to write ISO image on Linux
Aug 21 2019, 1:45 PM
faridb committed R596:6d91c46340e7: Use a preprocessor definition to enable KAuth (authored by faridb).
Use a preprocessor definition to enable KAuth
Aug 21 2019, 1:45 PM
faridb committed R596:ad0be0d43b28: Add missing Windows specific cpp file to CMakeLists (authored by faridb).
Add missing Windows specific cpp file to CMakeLists
Aug 21 2019, 1:45 PM
faridb committed R596:95fd261198a2: Add missing Q_OBJECT macro (authored by faridb).
Add missing Q_OBJECT macro
Aug 21 2019, 1:45 PM
faridb committed R596:1ee91722b442: Use correct variable name (authored by faridb).
Use correct variable name
Aug 21 2019, 1:45 PM
faridb committed R596:fe08133924b4: Implement ISO image writing in the new UI (authored by faridb).
Implement ISO image writing in the new UI
Aug 21 2019, 1:45 PM
faridb committed R596:3ac8e1c85260: Use KAuth on Linux only (authored by faridb).
Use KAuth on Linux only
Aug 21 2019, 1:45 PM
faridb committed R596:8eb5261d11ed: Disable KAuth if not writing ISO image on Linux (authored by faridb).
Disable KAuth if not writing ISO image on Linux
Aug 21 2019, 1:45 PM
faridb committed R596:e85a918d25dc: Use human-readable format for USB device size (authored by faridb).
Use human-readable format for USB device size
Aug 21 2019, 1:45 PM
faridb committed R596:aa230bcedeac: Add confirmation screen (authored by faridb).
Add confirmation screen
Aug 21 2019, 1:45 PM
faridb committed R596:526b981bc17e: Enable the create button if an ISO and a USB device are selected (authored by faridb).
Enable the create button if an ISO and a USB device are selected
Aug 21 2019, 1:45 PM
faridb committed R596:95dfbbc37129: Populate the usb devices list after the main window is shown (authored by faridb).
Populate the usb devices list after the main window is shown
Aug 21 2019, 1:45 PM
faridb committed R596:9f2b591a35f1: Use ISO image supplied as a command line argument (authored by faridb).
Use ISO image supplied as a command line argument
Aug 21 2019, 1:45 PM
faridb committed R596:5b8935b4560d: Update usb devices list by monitoring usb devices (authored by faridb).
Update usb devices list by monitoring usb devices
Aug 21 2019, 1:45 PM
faridb committed R596:0117a2a175ca: Put the logo above the central QStackedWidget (authored by faridb).
Put the logo above the central QStackedWidget
Aug 21 2019, 1:45 PM
faridb committed R596:720ccbf80466: Avoid empty spaces when resizing the window (authored by faridb).
Avoid empty spaces when resizing the window
Aug 21 2019, 1:45 PM
faridb committed R596:516d7f6578dd: Use a QStackedWidget as the central widget for the main window (authored by faridb).
Use a QStackedWidget as the central widget for the main window
Aug 21 2019, 1:45 PM
faridb committed R596:3e3543a42848: Add main window with ISO & USB selection screen (authored by faridb).
Add main window with ISO & USB selection screen
Aug 21 2019, 1:45 PM
faridb committed R596:476e992c4b64: Add button to select ISO image file (authored by faridb).
Add button to select ISO image file
Aug 21 2019, 1:45 PM
faridb committed R596:03054b6fbdc0: Dynamically link to libudev (authored by faridb).
Dynamically link to libudev
Aug 21 2019, 1:45 PM

Aug 14 2019

faridb committed R993:8cf9e31e5b64: Add ISO Image Writer to the list of enabled projects (authored by faridb).
Add ISO Image Writer to the list of enabled projects
Aug 14 2019, 8:04 PM
faridb added a comment to M113: KDE USB creator.
In M113#3794, @ngraham wrote:

The UI for the latest implementation is very good. I have only one suggestion. When no valid USB disks are mounted, instead of displaying a blank combobox with no entries, instead hide the combobox and show a centered label that says, "Please plug in a USB disk"

Aug 14 2019, 2:24 PM · KDE Applications, Neon

Aug 11 2019

faridb added a reviewer for D23096: Add blueprint for KDE ISO Image Writer: Craft.
Aug 11 2019, 2:33 PM
faridb requested review of D23096: Add blueprint for KDE ISO Image Writer.
Aug 11 2019, 2:31 PM

Jun 2 2019

faridb added a comment to M113: KDE USB creator.

The flash drive selector is on another screen to avoid using dialog windows extensively. The user will be allowed to proceed to the flash drive selection screen only after selecting a valid ISO image.

Jun 2 2019, 2:03 PM · KDE Applications, Neon

May 13 2019

faridb added a comment to M113: KDE USB creator.

I am working on the KDE ISO Image Writer as part of GSoC and based on this discussion I created the following mockups:

May 13 2019, 8:37 PM · KDE Applications, Neon

May 12 2019

faridb added a comment to D21037: Add deselect action.

Can you show a screenshot of a detail view affected by such problem?

May 12 2019, 5:59 PM · Dolphin
faridb added a comment to D21037: Add deselect action.
  1. You can already deselect everything by pressing an empty space in the view, if you are a mouse user.

This is not always possible. For example, if you're using the details view mode and there is not empty space to click (when the scrollbar is active).

May 12 2019, 12:18 PM · Dolphin

May 5 2019

faridb updated the summary of D21037: Add deselect action.
May 5 2019, 8:24 PM · Dolphin
faridb requested review of D21037: Add deselect action.
May 5 2019, 8:22 PM · Dolphin

Apr 2 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

The highlight effect provided by PlasmaCore.IconItem is only visible when used with dark or colourful icons:

Apr 2 2019, 9:06 PM · Plasma

Mar 28 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • Revert "[Task Manager] Make mute/unmute behaviour configurable"
Mar 28 2019, 10:05 PM · Plasma

Mar 27 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I like this change I'd just prefer it if you could post screenshots in the test plan section?

I added a screen recording to the test plan.

Mar 27 2019, 9:10 PM · Plasma
faridb updated the test plan for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
Mar 27 2019, 8:55 PM · Plasma

Mar 25 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Enable ability to mute tasks by default
  • [Task Manager] Change wording in config ui
Mar 25 2019, 10:54 PM · Plasma

Mar 24 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Make mute/unmute behaviour configurable
Mar 24 2019, 10:57 PM · Plasma
faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Also, it would be nice if you also work on making the volume indicators smaller and always in the corner.

Mar 24 2019, 9:42 PM · Plasma
faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Remove unnecessary braces
Mar 24 2019, 9:10 PM · Plasma

Mar 17 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Yes, you could accidentally mute an application when using Icons-Only Task Manager.
As you can see below, the audio indicator is pretty close to the centre of the task button, which is where you would usually click to activate that task:

Mar 17 2019, 6:47 PM · Plasma
faridb requested review of D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
Mar 17 2019, 11:36 AM · Plasma

Aug 18 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I've got it to work by using Document::waitUntilLoaded() but it waits until the full image has been loaded which renders the sorting by image size quite slow. Any suggestions?

Document::size() should be available in state MetaInfoLoaded, it's not necessary to load the whole image.
If the meta info is not retrieved automatically for all images in the current directory maybe we need a way to trigger this.
Sorting by Date actually works with EXIF info (if available), so I think the meta info should be loaded already.

Aug 18 2018, 12:14 PM

Aug 13 2018

faridb added a comment to D13344: Add possibility to sort by rating.
I used DocumentFactory::instance()->load() **but then sorting by image size only works after the document's info have been loaded (i.e you have to explicitly click on each photo to load its info and then the sorting by image size would work).
**
Aug 13 2018, 5:30 PM
faridb added a comment to D13344: Add possibility to sort by rating.

@faridb Are you still around?

While proofreading the release notes I had the idea to add "Sort by image size" (Bug 263059 actually, which will probably mean comparing the image's area), but wanted to give you the opportunity first if you are interested in becoming a regular contributor. Let me know ;)

Aug 13 2018, 5:18 PM

Jun 23 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I removed the code which explicitly triggers sorting when the file's data is changed because it seems like using the rating role solved that problem. I did some tests and the sorting refreshes automatically when the rating of an image is changed without manually calling invalidate().

Jun 23 2018, 9:30 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Revert "Invalidate current sorting when item rating is changed"
Jun 23 2018, 9:21 PM

Jun 22 2018

faridb added a dependent revision for D13669: Make mapping between sorting enum and model columns explicit: D13344: Add possibility to sort by rating.
Jun 22 2018, 6:01 PM
faridb added a dependency for D13344: Add possibility to sort by rating: D13669: Make mapping between sorting enum and model columns explicit.
Jun 22 2018, 6:01 PM
faridb added a comment to D13344: Add possibility to sort by rating.

@rkflx Thanks for your work! I rebased on D13669.

Jun 22 2018, 5:32 PM
faridb updated the summary of D13344: Add possibility to sort by rating.
Jun 22 2018, 5:24 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Remove D13669 from this revision
Jun 22 2018, 5:23 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Revert "Fallback to sorting according to file item text (temporary fix)"
  • Use rating role instead of column
Jun 22 2018, 5:20 PM

Jun 19 2018

faridb added a comment to D13344: Add possibility to sort by rating.
  • Import header file only when needed
  • Use if instead of else if when using return
  • Avoid multiple conversions from QVarient to int

@faridb LGTM, but we should still solve the issue Peter discovered, i.e. try to always sort by name for the secondary criterion (not only accidentally ;)

Jun 19 2018, 11:05 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Fallback to sorting according to file item text (temporary fix)
Jun 19 2018, 10:43 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Import header file only when needed
  • Use if instead of else if when using return
  • Avoid multiple conversions from QVarient to int
Jun 19 2018, 1:16 PM

Jun 7 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I would suggest to always use the filename as the only secondary criterion

When the ratings are the same, the files are sorted using the default sort method of QSortFilterProxyModel which seems to use the filename by default. (Dolphin uses custom code for the sorting which falls back to the filename as a default sorting column). Commit: eb8adc49ab0b.

Jun 7 2018, 8:43 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Fallback to default sort method in case ratings are the same
  • Disable sort by rating when no semantic info backend is available
  • Invalidate current sorting when item rating is changed
Jun 7 2018, 8:08 PM

Jun 5 2018

faridb updated the summary of D13344: Add possibility to sort by rating.
Jun 5 2018, 1:25 PM
faridb updated the diff for D13312: Fix 'Loading...' action not showing.
  • Add TODO note to flag this as a temporary fix
Jun 5 2018, 1:21 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Remove unnecessary QVariant validity check
  • Fix coding style issue
Jun 5 2018, 9:10 AM

Jun 4 2018

faridb updated the test plan for D13344: Add possibility to sort by rating.
Jun 4 2018, 11:10 PM
faridb requested review of D13344: Add possibility to sort by rating.
Jun 4 2018, 11:09 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

Write a small test case app, similar to what's in the forum post.

I actually tried to reproduce the bug by clearing a QMenu multiple times in a row but no luck, until I followed your suggestion and I used a QTimer to clear the menu which caused the exact same bug. It seems like it only happens when the menu is cleared through a slot triggered outside of the main event loop.

Jun 4 2018, 10:15 PM
faridb updated the diff for D13312: Fix 'Loading...' action not showing.

Include a TODO note to flag this fix as temporary

Jun 4 2018, 10:05 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

I kept digging and I found that it might be related to this code (in KIPIInterface::loadOnePlugin() which is in app/kipiinterface.cpp):

QMetaObject::invokeMethod(this, "loadOnePlugin", Qt::QueuedConnection);

If loadOnePlugin() is called synchronously the Share menu works fine (without D13289 or D13312). Could it be some sort of thread issue? But then why does the problem disappear when compositing is disabled?

Jun 4 2018, 11:25 AM

Jun 3 2018

faridb added a comment to D13312: Fix 'Loading...' action not showing.

BTW, I'm mostly testing in a VM. Are you testing on real hardware?

Yes, I am doing the tests on real hardware (with Arch Linux | KDE Plasma 5.12.5 | KDE Frameworks 5.46.0 | Qt 5.11.0 | Linux 4.16.13)

Jun 3 2018, 11:19 PM
faridb closed D13289: Fix share menu not showing the first time it is used.
Jun 3 2018, 7:26 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

Calling d->updateMenu() twice seems to fix both D13289 and D13312. If not the menu is updated correctly but it's invisible while still working (i.e. you can click invisible menu actions and they would work even if it doesn't show on screen).

Jun 3 2018, 7:24 PM
faridb added reviewers for D13312: Fix 'Loading...' action not showing: Gwenview, rkflx.
Jun 3 2018, 7:17 PM