faridb (Farid Boudedja)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 29 2018, 1:12 PM (50 w, 6 d)
Availability
Available

Recent Activity

Mon, May 13

faridb added a comment to M113: KDE USB creator.

I am working on the KDE ISO Image Writer as part of GSoC and based on this discussion I created the following mockups:

Mon, May 13, 8:37 PM · KDE Applications, Neon

Sun, May 12

faridb added a comment to D21037: Add deselect action.

Can you show a screenshot of a detail view affected by such problem?

Sun, May 12, 5:59 PM · Dolphin
faridb added a comment to D21037: Add deselect action.
  1. You can already deselect everything by pressing an empty space in the view, if you are a mouse user.

This is not always possible. For example, if you're using the details view mode and there is not empty space to click (when the scrollbar is active).

Sun, May 12, 12:18 PM · Dolphin

Sun, May 5

faridb updated the summary of D21037: Add deselect action.
Sun, May 5, 8:24 PM · Dolphin
faridb requested review of D21037: Add deselect action.
Sun, May 5, 8:22 PM · Dolphin

Apr 2 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

The highlight effect provided by PlasmaCore.IconItem is only visible when used with dark or colourful icons:

Apr 2 2019, 9:06 PM · Plasma

Mar 28 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • Revert "[Task Manager] Make mute/unmute behaviour configurable"
Mar 28 2019, 10:05 PM · Plasma

Mar 27 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I like this change I'd just prefer it if you could post screenshots in the test plan section?

I added a screen recording to the test plan.

Mar 27 2019, 9:10 PM · Plasma
faridb updated the test plan for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
Mar 27 2019, 8:55 PM · Plasma

Mar 25 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Enable ability to mute tasks by default
  • [Task Manager] Change wording in config ui
Mar 25 2019, 10:54 PM · Plasma

Mar 24 2019

faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Make mute/unmute behaviour configurable
Mar 24 2019, 10:57 PM · Plasma
faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Also, it would be nice if you also work on making the volume indicators smaller and always in the corner.

Mar 24 2019, 9:42 PM · Plasma
faridb updated the diff for D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
  • [Task Manager] Remove unnecessary braces
Mar 24 2019, 9:10 PM · Plasma

Mar 17 2019

faridb added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Yes, you could accidentally mute an application when using Icons-Only Task Manager.
As you can see below, the audio indicator is pretty close to the centre of the task button, which is where you would usually click to activate that task:

Mar 17 2019, 6:47 PM · Plasma
faridb requested review of D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
Mar 17 2019, 11:36 AM · Plasma

Aug 18 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I've got it to work by using Document::waitUntilLoaded() but it waits until the full image has been loaded which renders the sorting by image size quite slow. Any suggestions?

Document::size() should be available in state MetaInfoLoaded, it's not necessary to load the whole image.
If the meta info is not retrieved automatically for all images in the current directory maybe we need a way to trigger this.
Sorting by Date actually works with EXIF info (if available), so I think the meta info should be loaded already.

Aug 18 2018, 12:14 PM

Aug 13 2018

faridb added a comment to D13344: Add possibility to sort by rating.
I used DocumentFactory::instance()->load() **but then sorting by image size only works after the document's info have been loaded (i.e you have to explicitly click on each photo to load its info and then the sorting by image size would work).
**
Aug 13 2018, 5:30 PM
faridb added a comment to D13344: Add possibility to sort by rating.

@faridb Are you still around?

While proofreading the release notes I had the idea to add "Sort by image size" (Bug 263059 actually, which will probably mean comparing the image's area), but wanted to give you the opportunity first if you are interested in becoming a regular contributor. Let me know ;)

Aug 13 2018, 5:18 PM

Jun 23 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I removed the code which explicitly triggers sorting when the file's data is changed because it seems like using the rating role solved that problem. I did some tests and the sorting refreshes automatically when the rating of an image is changed without manually calling invalidate().

Jun 23 2018, 9:30 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Revert "Invalidate current sorting when item rating is changed"
Jun 23 2018, 9:21 PM

Jun 22 2018

faridb added a dependent revision for D13669: Make mapping between sorting enum and model columns explicit: D13344: Add possibility to sort by rating.
Jun 22 2018, 6:01 PM
faridb added a dependency for D13344: Add possibility to sort by rating: D13669: Make mapping between sorting enum and model columns explicit.
Jun 22 2018, 6:01 PM
faridb added a comment to D13344: Add possibility to sort by rating.

@rkflx Thanks for your work! I rebased on D13669.

Jun 22 2018, 5:32 PM
faridb updated the summary of D13344: Add possibility to sort by rating.
Jun 22 2018, 5:24 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Remove D13669 from this revision
Jun 22 2018, 5:23 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Revert "Fallback to sorting according to file item text (temporary fix)"
  • Use rating role instead of column
Jun 22 2018, 5:20 PM

Jun 19 2018

faridb added a comment to D13344: Add possibility to sort by rating.
  • Import header file only when needed
  • Use if instead of else if when using return
  • Avoid multiple conversions from QVarient to int

@faridb LGTM, but we should still solve the issue Peter discovered, i.e. try to always sort by name for the secondary criterion (not only accidentally ;)

Jun 19 2018, 11:05 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Fallback to sorting according to file item text (temporary fix)
Jun 19 2018, 10:43 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Import header file only when needed
  • Use if instead of else if when using return
  • Avoid multiple conversions from QVarient to int
Jun 19 2018, 1:16 PM

Jun 7 2018

faridb added a comment to D13344: Add possibility to sort by rating.

I would suggest to always use the filename as the only secondary criterion

When the ratings are the same, the files are sorted using the default sort method of QSortFilterProxyModel which seems to use the filename by default. (Dolphin uses custom code for the sorting which falls back to the filename as a default sorting column). Commit: eb8adc49ab0b.

Jun 7 2018, 8:43 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Fallback to default sort method in case ratings are the same
  • Disable sort by rating when no semantic info backend is available
  • Invalidate current sorting when item rating is changed
Jun 7 2018, 8:08 PM

Jun 5 2018

faridb updated the summary of D13344: Add possibility to sort by rating.
Jun 5 2018, 1:25 PM
faridb updated the diff for D13312: Fix 'Loading...' action not showing.
  • Add TODO note to flag this as a temporary fix
Jun 5 2018, 1:21 PM
faridb updated the diff for D13344: Add possibility to sort by rating.
  • Remove unnecessary QVariant validity check
  • Fix coding style issue
Jun 5 2018, 9:10 AM

Jun 4 2018

faridb updated the test plan for D13344: Add possibility to sort by rating.
Jun 4 2018, 11:10 PM
faridb requested review of D13344: Add possibility to sort by rating.
Jun 4 2018, 11:09 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

Write a small test case app, similar to what's in the forum post.

I actually tried to reproduce the bug by clearing a QMenu multiple times in a row but no luck, until I followed your suggestion and I used a QTimer to clear the menu which caused the exact same bug. It seems like it only happens when the menu is cleared through a slot triggered outside of the main event loop.

Jun 4 2018, 10:15 PM
faridb updated the diff for D13312: Fix 'Loading...' action not showing.

Include a TODO note to flag this fix as temporary

Jun 4 2018, 10:05 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

I kept digging and I found that it might be related to this code (in KIPIInterface::loadOnePlugin() which is in app/kipiinterface.cpp):

QMetaObject::invokeMethod(this, "loadOnePlugin", Qt::QueuedConnection);

If loadOnePlugin() is called synchronously the Share menu works fine (without D13289 or D13312). Could it be some sort of thread issue? But then why does the problem disappear when compositing is disabled?

Jun 4 2018, 11:25 AM

Jun 3 2018

faridb added a comment to D13312: Fix 'Loading...' action not showing.

BTW, I'm mostly testing in a VM. Are you testing on real hardware?

Yes, I am doing the tests on real hardware (with Arch Linux | KDE Plasma 5.12.5 | KDE Frameworks 5.46.0 | Qt 5.11.0 | Linux 4.16.13)

Jun 3 2018, 11:19 PM
faridb closed D13289: Fix share menu not showing the first time it is used.
Jun 3 2018, 7:26 PM
faridb added a comment to D13312: Fix 'Loading...' action not showing.

Calling d->updateMenu() twice seems to fix both D13289 and D13312. If not the menu is updated correctly but it's invisible while still working (i.e. you can click invisible menu actions and they would work even if it doesn't show on screen).

Jun 3 2018, 7:24 PM
faridb added reviewers for D13312: Fix 'Loading...' action not showing: Gwenview, rkflx.
Jun 3 2018, 7:17 PM
faridb requested review of D13312: Fix 'Loading...' action not showing.
Jun 3 2018, 7:12 PM
faridb reopened D13289: Fix share menu not showing the first time it is used.
Jun 3 2018, 2:10 PM
faridb added a comment to D13289: Fix share menu not showing the first time it is used.

I looked into the problem of Loading... not showing and I found out that it's because of my bugfix. My change caused d->updateMenu() to be called only when the loading is finished, thus not showing Loading....

Jun 3 2018, 12:11 PM

Jun 2 2018

faridb abandoned D13283: Add possibility to sort folders first.

Yes, you are right. Implementing this feature could probably break other aspects of Gwenview that assume that folders are sorted before files.

Jun 2 2018, 11:23 PM
faridb added a comment to D13289: Fix share menu not showing the first time it is used.

Thanks for the suggestions! I will try that.

Jun 2 2018, 11:14 PM
faridb added a comment to D13213: Add possibility to sort by descending order.

@rkflx Thanks for reviewing and accepting the patch! This is my second patch and your feedback and your advices are encouraging me to keep contributing :-).

Jun 2 2018, 10:53 PM · Gwenview
faridb added a comment to D13283: Add possibility to sort folders first.

I think there is a way to make the browsing feature work even if Folders First is disabled. For example, skip the next element if it's a folder and go directly to the next document after it. Would that be an acceptable behaviour?

Jun 2 2018, 10:38 PM
faridb added a comment to D13289: Fix share menu not showing the first time it is used.

I could not find a way to test if Loading... was showing correctly because the plugins were loading almost instantaneously.

Jun 2 2018, 10:26 PM
faridb updated the diff for D13213: Add possibility to sort by descending order.

I made the changes you requested in your inline comments.

Jun 2 2018, 9:54 PM · Gwenview
faridb added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Jun 2 2018, 8:45 PM · Gwenview
faridb updated the summary of D13197: Prompt to install kipi-plugins when the share button is clicked .
Jun 2 2018, 8:40 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Jun 2 2018, 8:27 PM · Gwenview
faridb requested review of D13289: Fix share menu not showing the first time it is used.
Jun 2 2018, 7:54 PM
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Jun 2 2018, 6:25 PM · Gwenview
faridb accepted D13251: Remove superfluous code for empty KIPI toolbar button.
Jun 2 2018, 2:10 PM
faridb added a dependent revision for D13213: Add possibility to sort by descending order: D13283: Add possibility to sort folders first.
Jun 2 2018, 12:16 PM · Gwenview
faridb requested review of D13283: Add possibility to sort folders first.
Jun 2 2018, 12:16 PM
faridb updated the diff for D13213: Add possibility to sort by descending order.

Thanks for your detailed feedback! I have made the changes you have requested in your inline comments.
I have also added the ability to sort folders first but I will create a separate revision for that.

Jun 2 2018, 10:38 AM · Gwenview

Jun 1 2018

faridb added a comment to D13252: Update KIPI toolbar button after installation of kipi-plugins.

@rkflx Thanks for the clarification. Now, I see why it's necessary.

Jun 1 2018, 9:55 PM
faridb accepted D13252: Update KIPI toolbar button after installation of kipi-plugins.

Thanks! This will make D13197 much cleaner.

Jun 1 2018, 9:45 AM

May 30 2018

faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Fixed the coding style issue

May 30 2018, 6:59 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Made the changes to use mInstallPluginAction instead of the action's text.
It also solved the bug I was having with the Plugins menu.

May 30 2018, 6:38 PM · Gwenview
faridb added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Thanks! One more thought: instead of comparing the action's text, could we compare the action itself, to see if it's mInstallPluginAction?

May 30 2018, 6:11 PM · Gwenview
faridb requested review of D13213: Add possibility to sort by descending order.
May 30 2018, 1:40 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Fixed coding style issues

May 30 2018, 8:44 AM · Gwenview

May 29 2018

faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Use an internationalised string instead of a hard-coded one

May 29 2018, 9:11 PM · Gwenview
faridb added inline comments to D13197: Prompt to install kipi-plugins when the share button is clicked .
May 29 2018, 4:40 PM · Gwenview
faridb requested review of D13197: Prompt to install kipi-plugins when the share button is clicked .
May 29 2018, 2:08 PM · Gwenview