| mgallien |
| Elisa |
Currently the sidebar text is huge and the sidebar itself adjusts its width with
the window's own width. This results in sidebar items' text getting elided with
most window sizes.
This patch reduces the text size a bit and fixes the size, resolving both problems.
BUG: 406481
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I don't think it's my place to review this, but wanted to say I've been testing out Elisa these past few days and also felt like the sidebar text size would be better if it were smaller. Looks really nice in the screenshot!
| src/qml/ContentView.qml | ||
|---|---|---|
| 184–186 | Part of this was necessary to get the view to collapse to icons only and text on hover when Elisa windows is quite small. Maybe you can keep some kind of threshold to only have two width: the full one with icon and text and the collapsed one with icon and text on hover. | |
You are welcome to contribute. There is no prerequisite for anybody to contribute as long as you want to be involved and you follow the KDE community way of doing things.
| src/qml/ContentView.qml | ||
|---|---|---|
| 184–186 | Hmm, even without my patch, I'm not sure that feature actually works. With unpatched git master, no matter how small I make the window (including using quarter-tiling to override the minimum size), the sidebar never collapses to become an icons-only view with tooltips. | |
| src/qml/ContentView.qml | ||
|---|---|---|
| 184–186 | You need to hide the playlist to get a smaller minimal size. In this case, you can resize it smaller. | |
Collapse the View Selector sidebar to be icons-only when the playlist is hidden and the window is made narrow
Thanks @filipf. I really, really like Elisa, and the code is very high quality, but with adequate low hanging UI fruit. It's a VDG hacker's dream come true. :)
Exactly, I also really like what I'm seeing so far and have been looking at how I could contribute.
Thank you :) I don't have a detailed experience of the program yet, but I caught one thing that I felt silly posting a diff for (and it seemed inappropriate to do a git push). Here it should be "tracks" instead of "track" I think: https://lxr.kde.org/source/extragear/multimedia/elisa/src/musiclistenersmanager.cpp#0380
I have a feeling it's fine to push a commit directly that corrects the grammar on a comment. :) But no patch is too small, I say!