Differential D15872

Fix Oxygen background gradient for QML modules
ClosedPublic
Actions

Authored by hwti on Oct 1 2018, 9:21 AM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
VDG
Plasma
Commits
R295:3fe124c7f411: Fix Oxygen background gradient for QML modules
Summary

We need to make the QQuickWidget transparent, so we see the window background, which can be a gradient with Oxygen, instead of a solid color which doesn't match the top and bottom of the window.

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hwti created this revision.Oct 1 2018, 9:21 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 1 2018, 9:21 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
hwti requested review of this revision.Oct 1 2018, 9:21 AM
filipf added a subscriber: filipf.Apr 4 2019, 8:54 PM

Ping.

Is this actually what's been causing the following problem?

davidedmundson accepted this revision.Apr 4 2019, 10:34 PM
davidedmundson added a subscriber: davidedmundson.

We are really bad at letting reviews get lost and unnoticed. I'm really sorry!

Tagging is on Saturday, so best to merge next week for proper testing.

This revision is now accepted and ready to land.Apr 4 2019, 10:34 PM
Closed by commit R295:3fe124c7f411: Fix Oxygen background gradient for QML modules (authored by hwti, committed by ngraham). · Explain WhyApr 5 2019, 2:11 AM
This revision was automatically updated to reflect the committed changes.
ngraham reopened this revision.Apr 5 2019, 2:14 AM
ngraham added a subscriber: ngraham.

Oh, I think I misunderstood your comment, @davidedmundson. You were saying we should merge this after tagging, duh. Reverted for now, and I'll re-merge it after tagging.

This revision is now accepted and ready to land.Apr 5 2019, 2:14 AM
ngraham closed this revision.Apr 8 2019, 5:18 PM

5.57 is now tagged, so I've landed this.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleqml.cpp (6 lines)

Diff 55450

View Options

src/kcmoduleqml.cpp

Loading...