Feed Advanced Search

Yesterday

filipf added a comment to D20797: [dict] Modernize configuration window.

Why doesn't mouse wheel scrolling with with ScrollView?

Wed, Apr 24, 10:39 PM · Plasma
filipf updated the task description for T10586: Modernize widget configuration settings.
Wed, Apr 24, 10:08 PM · VDG
filipf added a task to D20797: [dict] Modernize configuration window: T10586: Modernize widget configuration settings.
Wed, Apr 24, 10:08 PM · Plasma
filipf added a revision to T10586: Modernize widget configuration settings: D20797: [dict] Modernize configuration window.
Wed, Apr 24, 10:08 PM · VDG
filipf added reviewers for D20797: [dict] Modernize configuration window: dfaure, ngraham, VDG, Plasma.
Wed, Apr 24, 10:07 PM · Plasma
filipf requested review of D20797: [dict] Modernize configuration window.
Wed, Apr 24, 10:06 PM · Plasma
filipf added a task to D20048: [color-wallpaper] Align with the master FormLayout: T10586: Modernize widget configuration settings.
Wed, Apr 24, 9:18 PM · Plasma
filipf added a revision to T10586: Modernize widget configuration settings: D20048: [color-wallpaper] Align with the master FormLayout.
Wed, Apr 24, 9:18 PM · VDG
filipf updated the task description for T10586: Modernize widget configuration settings.
Wed, Apr 24, 9:17 PM · VDG
filipf accepted D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
Wed, Apr 24, 8:44 PM · Plasma

Tue, Apr 23

filipf added a comment to D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.

Tried it out, looks good and is efficient.

Tue, Apr 23, 8:42 PM · Plasma
filipf added a comment to D19797: [fifteen-puzzle] Modernize settings window.

Oh whoops, I had completely forgotten that you already had this revision open, sorry :(

Tue, Apr 23, 6:24 PM · Plasma
filipf added inline comments to D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
Tue, Apr 23, 12:05 PM · Plasma
filipf abandoned D19797: [fifteen-puzzle] Modernize settings window.
Tue, Apr 23, 7:56 AM · Plasma

Fri, Apr 19

filipf committed R119:1c6644a42b7a: Hook up the main form layout with child form layouts (authored by filipf).
Hook up the main form layout with child form layouts
Fri, Apr 19, 9:24 PM
filipf closed D20313: Hook up the main form layout with child form layouts.
Fri, Apr 19, 9:24 PM · Plasma
filipf added a comment to D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.

Seems to make more sense for when the full path is shown, but my intuition is that right elision is more useful when it's just the folder name being shown.

Fri, Apr 19, 4:40 PM · Dolphin

Thu, Apr 18

filipf committed R119:60181eca4414: [Kickoff] Make the tabbar separator width consistent with tab selection line (authored by filipf).
[Kickoff] Make the tabbar separator width consistent with tab selection line
Thu, Apr 18, 11:11 PM
filipf closed D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line.
Thu, Apr 18, 11:11 PM · Plasma
filipf added a comment to D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line.

Sidenote: units.smallSpacing wasn't a good solution, it ended being 5 pixels wide on my laptop and 4 pixels wide on my PC. 4 pixels works consistently on both machines, and with various resolutions and scaling.

Thu, Apr 18, 10:32 PM · Plasma
filipf added reviewers for D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line: VDG, ngraham.
Thu, Apr 18, 10:24 PM · Plasma
filipf requested review of D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line.
Thu, Apr 18, 10:23 PM · Plasma
filipf added a comment to D20313: Hook up the main form layout with child form layouts.

I'll land this tomorrow night since it's a prerequisite for fixing the PoTD plugin.

Thu, Apr 18, 9:14 PM · Plasma
filipf accepted D20612: [Kickoff] Modernize settings window layout.
Thu, Apr 18, 9:05 PM · Plasma
filipf added a comment to D20672: Add an icon for Thunderbolt KCM.

Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.

Thu, Apr 18, 9:02 PM · Frameworks
filipf accepted D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage".

Makes more sense.

Thu, Apr 18, 9:01 PM · Frameworks
filipf added inline comments to D20612: [Kickoff] Modernize settings window layout.
Thu, Apr 18, 8:58 PM · Plasma
filipf accepted D20612: [Kickoff] Modernize settings window layout.

Nice! The last label is getting cut off for me with the default window size, but not sure what could be done about it.

Thu, Apr 18, 8:44 PM · Plasma
filipf added a comment to D20612: [Kickoff] Modernize settings window layout.

Some other comments:

Thu, Apr 18, 3:29 PM · Plasma
filipf added a comment to D20612: [Kickoff] Modernize settings window layout.
In D20612#452054, @GB_2 wrote:

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Just use implicitWidth and implicitHeight.

Thu, Apr 18, 2:41 PM · Plasma

Wed, Apr 17

filipf committed R123:9094e982ff0c: Redesign the theme preview window (authored by filipf).
Redesign the theme preview window
Wed, Apr 17, 7:07 AM
filipf closed D19077: Redesign the theme preview window.
Wed, Apr 17, 7:07 AM · Plasma

Tue, Apr 16

filipf requested changes to D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues.

Here's what works:

Tue, Apr 16, 1:53 PM · Plasma
filipf added a comment to D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues.

Looks like you'll need to use twinFormLayouts. One unfortunate thing is you can go "ha, I'll have all the layouts adjust to this specific one (with the longest label)". You'll need to have them all interlinked with one another because label length can change based on translation.

Tue, Apr 16, 11:27 AM · Plasma

Mon, Apr 15

filipf added reviewers for D20585: [FormLayout] RFC: Use even top and bottom spacing for separator: mart, Kirigami, ngraham.
Mon, Apr 15, 10:20 PM · Kirigami
filipf requested review of D20585: [FormLayout] RFC: Use even top and bottom spacing for separator.
Mon, Apr 15, 10:18 PM · Kirigami
filipf added a comment to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.

Thanks @filipf. I really, really like Elisa, and the code is very high quality, but with adequate low hanging UI fruit. It's a VDG hacker's dream come true. :)

Mon, Apr 15, 9:48 PM
filipf updated the diff for D19077: Redesign the theme preview window.

add authorship info, @GB_2 you can do the same

Mon, Apr 15, 9:39 PM · Plasma
filipf added a comment to D19077: Redesign the theme preview window.
In D19077#450746, @GB_2 wrote:

Fix "No Preview" icon

Mon, Apr 15, 8:06 PM · Plasma
filipf updated the diff for D19077: Redesign the theme preview window.

set sourceSize width and height (wow that's even better than mipmap)

Mon, Apr 15, 4:23 PM · Plasma
filipf added a comment to D19077: Redesign the theme preview window.

Also the scaled down image quality isn't that great, can I use mipmap?

Mon, Apr 15, 4:16 PM · Plasma
filipf updated the diff for D19077: Redesign the theme preview window.

somewhat smarter code

Mon, Apr 15, 4:14 PM · Plasma
filipf added a comment to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.

I don't think it's my place to review this, but wanted to say I've been testing out Elisa these past few days and also felt like the sidebar text size would be better if it were smaller. Looks really nice in the screenshot!

Mon, Apr 15, 3:31 PM
filipf added a comment to D19077: Redesign the theme preview window.

I think that looks great!

Mon, Apr 15, 3:17 PM · Plasma
filipf added a comment to D19077: Redesign the theme preview window.

No preview thumbnail looks like this:

Mon, Apr 15, 3:07 PM · Plasma
filipf updated the diff for D19077: Redesign the theme preview window.
  • add a dummy "No preview available" rectangle when there is no preview image
  • adjust shadows to mimick GridDelegate
Mon, Apr 15, 3:06 PM · Plasma
filipf added a comment to D20569: RFC: Use more compact OSD.

+1 on making the OSD more efficient, I think it's the right direction to be going in.

Mon, Apr 15, 8:30 AM · Plasma

Tue, Apr 9

filipf added a comment to D20313: Hook up the main form layout with child form layouts.

@mart before you suggested we should do something like:

Tue, Apr 9, 9:45 PM · Plasma
filipf accepted D20407: [Folder View] Improve label crispness.

Huge improvement, Nate, and an excellent find. The rest of the reviewers can also have a look at my before and after photos for proof:

Tue, Apr 9, 2:27 PM · Plasma
filipf accepted D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right.

Works as desired and is more efficient than anchoring to parent.right and then adding symmetrical units.smallSpacing * 6 right margin (since that's how the arrow is already anchored).

Tue, Apr 9, 12:09 PM · Plasma

Mon, Apr 8

filipf accepted D20392: Use more appropriate "Alternatives" icon and text.
Mon, Apr 8, 9:00 PM · Frameworks
filipf accepted D20342: Update KDE logo to be closer to original.

Looks good to me.

Mon, Apr 8, 7:23 PM · Frameworks
filipf added a comment to D20342: Update KDE logo to be closer to original.

So what I'm seeing is that the gradient has been toned down, which also results in a slight color change in general. FWIW I like the older version more because the new one seems flat(ter) in comparison. Not to long ago someone in VDG actually remarked that the official logo is kind of flat so if possible it would be cool IMO if we could add a gradient to it and keep these icons the way they were.

Mon, Apr 8, 6:38 PM · Frameworks
filipf accepted D19209: [sddm-kcm] Adjust Background label and button.
Mon, Apr 8, 5:16 PM · Plasma

Sat, Apr 6

filipf updated the diff for D20313: Hook up the main form layout with child form layouts.

Figured it out. We'll just export a formLayout alias property in all the individual plugins and everything will work.

Sat, Apr 6, 7:20 PM · Plasma
filipf planned changes to D20313: Hook up the main form layout with child form layouts.

twinFormLayouts: main.currentItem will stop working as soon as the wallpaper plugin in anything more complicated than having a single form layout. How do I specify that, yes, I want the currentItem, but only the form layout in that file?

Sat, Apr 6, 7:07 PM · Plasma
filipf added reviewers for D20313: Hook up the main form layout with child form layouts: Plasma, ngraham.
Sat, Apr 6, 6:36 PM · Plasma
filipf requested review of D20313: Hook up the main form layout with child form layouts.
Sat, Apr 6, 6:35 PM · Plasma

Fri, Apr 5

filipf committed R119:230ac60a3195: Fix incorrect vertical spacing between main layout and individual wallpaper… (authored by filipf).
Fix incorrect vertical spacing between main layout and individual wallpaper…
Fri, Apr 5, 11:59 PM
filipf closed D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.
Fri, Apr 5, 11:59 PM · Plasma
filipf added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything seems symmetric at least.

Fri, Apr 5, 9:22 PM · Plasma
filipf added a comment to D20249: Make the Configuration button more understandable.

Hey @trmdi rooty's not participating in KDE at this point so he won't be able to do the review.

Fri, Apr 5, 9:02 PM · Plasma
filipf awarded D20266: Add new notification plasmoid a Burninate token.
Fri, Apr 5, 4:27 PM · Plasma
filipf updated subscribers of D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

@hein what's your opinion on reducing the margin?

Fri, Apr 5, 3:27 PM · Plasma
filipf added a comment to D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.

Yep, looks like the correct solution to me. Nice find!

Fri, Apr 5, 11:32 AM · Plasma

Thu, Apr 4

filipf updated the summary of D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.
Thu, Apr 4, 10:38 PM · Plasma
filipf updated the diff for D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.

apparently anchoring the stack view wasn't the only solution; settings spacing to 0 achieves the same result and doesn't spew out an "anchors in a layout" error

Thu, Apr 4, 10:37 PM · Plasma
filipf added a comment to D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.

I know I'm not supposed to anchor items in a layout but this was the only solution I could find for now.

Thu, Apr 4, 10:15 PM · Plasma
filipf updated the test plan for D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.
Thu, Apr 4, 10:11 PM · Plasma
filipf added reviewers for D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins: hein, mart, Plasma, ngraham.
Thu, Apr 4, 10:09 PM · Plasma
filipf requested review of D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins.
Thu, Apr 4, 10:07 PM · Plasma
filipf added a reviewer for D15872: Fix Oxygen background gradient for QML modules: Plasma.
Thu, Apr 4, 9:46 PM · Frameworks
filipf added a comment to D15872: Fix Oxygen background gradient for QML modules.

Is this actually what's been causing the following problem?

Thu, Apr 4, 8:54 PM · Frameworks
filipf updated the diff for D19209: [sddm-kcm] Adjust Background label and button.

attempt to allow for commandeering of the revision

Thu, Apr 4, 8:31 PM · Plasma
filipf added a comment to D19209: [sddm-kcm] Adjust Background label and button.
In D19209#443418, @GB_2 wrote:

@rooty Can you please reopen this?

Thu, Apr 4, 8:24 PM · Plasma

Wed, Apr 3

filipf committed R120:4516ab53726c: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts (authored by filipf).
[image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts
Wed, Apr 3, 11:35 PM
filipf closed D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Wed, Apr 3, 11:35 PM · Plasma
filipf added a comment to D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious.
In D20144#442451, @GB_2 wrote:

Hmm, the separator line feels like a bit much to me. How about just units.largeSpacing or units.gridUnit between them?

This is it without separator, I personally think it looks weird with that gap:


Let's see what others think.

Wed, Apr 3, 2:48 PM · Plasma
filipf added a comment to D19591: Add Compression Quality slider for lossy formats.

Where is the check that this is done only for lossy formats? Here, PNG is saved uncompressed after this change.

Wed, Apr 3, 10:42 AM · Spectacle

Tue, Apr 2

filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Just throwing out another possible solution: the PlasmaComponents Highlight thingy:

Tue, Apr 2, 10:59 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
In D19873#442385, @hein wrote:

Looks solid to me. Is your concern re vertical spacing still valid?

Tue, Apr 2, 10:27 PM · Plasma
filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and conventional, I would recommend using the typical effect. :)

Tue, Apr 2, 10:18 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

I think it would be good if someone from Plasma could have a look if this is okay, I did do a lot of modifications.

Tue, Apr 2, 2:39 PM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

.

Tue, Apr 2, 2:36 PM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

git...

Tue, Apr 2, 2:27 PM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

rebase

Tue, Apr 2, 2:22 PM · Plasma
filipf committed R120:b40dabdc27e4: [color-wallpaper] Align with the master FormLayout (authored by filipf).
[color-wallpaper] Align with the master FormLayout
Tue, Apr 2, 2:16 PM
filipf closed D20048: [color-wallpaper] Align with the master FormLayout.
Tue, Apr 2, 2:16 PM · Plasma
filipf added a comment to D19077: Redesign the theme preview window.
In D19077#442288, @GB_2 wrote:

I like B too.
BTW, can "Background:" and the background selection button be centered like in a form layout?

Tue, Apr 2, 2:15 PM · Plasma
filipf added a comment to D19077: Redesign the theme preview window.
In D19077#442281, @GB_2 wrote:

Ping

Tue, Apr 2, 2:07 PM · Plasma
filipf resigned from D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is:

Tue, Apr 2, 1:35 PM · Plasma

Thu, Mar 28

filipf added a comment to D20086: Fix window height of Screen Locking KCM.

Good fix, the lack of implicitHeight was leading to confusion before if there are even any wallpapers present.

Thu, Mar 28, 12:08 PM · Plasma
filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

As for options overload, based on the reasoning above and the fact that we've recently split up the options and that we have space, I don't agree that this should be approached through the prism of UI clutter.

"We had so many options we went from one page to two pages, so now we can add more options!" :-)

Thu, Mar 28, 8:03 AM · Plasma

Wed, Mar 27

filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

Would something like this work?

Wed, Mar 27, 9:25 PM · Plasma
filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

it would be nice if the "playing audio" icon itself changed to reflect the current status.

The icon already shows the current status:

Well... sort of. :) What I meant (and should have clearly stated the first time) was that it should use the audio-volume-muted icon when muted, rather than just becoming semi-transparent.

Wed, Mar 27, 9:18 PM · Plasma
filipf committed R119:dd1840f0496f: [application-dashboard] Use appropriate search string (authored by filipf).
[application-dashboard] Use appropriate search string
Wed, Mar 27, 8:43 PM
filipf closed D20073: [application-dashboard] Use appropriate search string.
Wed, Mar 27, 8:43 PM · Plasma
filipf added a comment to D19994: Add microphone indicator.

Yeah you want to ignore virtual devices or I guess this audio effects for eaxmple app would trigger the indicator?

Wed, Mar 27, 6:55 PM · Plasma
filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

I made the suggestion to have an option not because there might be something wrong with the feature, but because there is a subset of users who have a harder time finding their way around the UI - the non-tech say people and/or (now that I think of it) perhaps those with impaired vision who might not register the changed icon.

Wed, Mar 27, 1:27 PM · Plasma
filipf added a comment to D20066: Use Meta+D to Show Desktop by default.
In D20066#439214, @zzag wrote:

Windows has this shortcut by default

Win+D?

Wed, Mar 27, 8:49 AM · KWin