Feed Advanced Search

Today

filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

Wed, Dec 11, 12:56 PM · Frameworks
filipf committed R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into account complementary color schemes (authored by filipf).
[PC3 ToolButton] Have the label take into account complementary color schemes
Wed, Dec 11, 12:50 PM
filipf closed D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Wed, Dec 11, 12:50 PM · Frameworks
filipf updated the test plan for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Wed, Dec 11, 12:48 PM · Frameworks
filipf added a comment to T10611: Set options for GTK apps in the respective KCMs.

Still works for Adwaita:

Wed, Dec 11, 9:25 AM · Plasma: KCM Redesign

Mon, Dec 9

filipf added a comment to D25814: [KColorScheme] Add SeparatorColor.

FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do.

To me, this image really shows how good the dark separators look. I don't think the fact that our UIs are more icon-heavy is a significant factor here. Unlike GNOME, we tend to use ToolButtons, which have no outline until hovered over. So in fact there are probably fewer lines with the separator color in our Toolbutton-heavy UIs compared to GNOME.

Mon, Dec 9, 10:15 PM · Frameworks
filipf accepted D25822: Add manual test for changing colorscope in components.

Thanks again :)

Mon, Dec 9, 8:34 PM · Frameworks
filipf added a comment to D25822: Add manual test for changing colorscope in components.

Nice. Does this fix or obsolete D25699?

Mon, Dec 9, 7:50 PM · Frameworks
filipf added a comment to D25822: Add manual test for changing colorscope in components.

Thanks! It will be easier to test now.

Mon, Dec 9, 7:49 PM · Frameworks
filipf updated subscribers of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110

Mon, Dec 9, 1:06 PM · Frameworks
filipf added a comment to D25820: SimpleScreenRecorder icon added.

I agree, I think brighter and slightly less saturated colors would look nice.

Mon, Dec 9, 4:37 AM · Breeze, Frameworks
filipf added a comment to D25814: [KColorScheme] Add SeparatorColor.

I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by matching it with window color I guess).

Mon, Dec 9, 4:34 AM · Frameworks
filipf awarded D25814: [KColorScheme] Add SeparatorColor a The World Burns token.
Mon, Dec 9, 4:26 AM · Frameworks

Sun, Dec 8

filipf added a comment to T12029: Plasma 5.18 Contest for wallpapers, promotional video, UI mockups, etc .

This is the wallpaper in question:

Sun, Dec 8, 7:51 PM · KDE Promo

Sat, Dec 7

filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

The labels are visible again with just the control.flat condition, but the prefix one might be needed as well for non-breeze themes.

There's a part missing though, the triangle (visible on https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is gone. That seems to be a feature lost with PC3 :-(

Sat, Dec 7, 10:33 PM · Frameworks
filipf updated the summary of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Sat, Dec 7, 9:49 PM · Frameworks

Fri, Dec 6

filipf added a comment to D25340: Added background colors to active and inactive icon view.

This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work?

Fri, Dec 6, 8:53 PM · Frameworks
filipf added a comment to D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.

Yeah, that might not be a bad idea. Our GridDelegates do not support more than 1 line of text right now if I'm not mistaken though.

Fri, Dec 6, 7:02 PM · Plasma
filipf added reviewers for D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme: Plasma, VDG.
Fri, Dec 6, 3:13 PM · Plasma
filipf requested review of D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
Fri, Dec 6, 3:13 PM · Plasma
filipf added inline comments to D25778: refactor(lookandfeelexplorer): Port mostly to QQC2.
Fri, Dec 6, 10:44 AM · Plasma

Thu, Dec 5

filipf accepted D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

+1 from me as well for the reasons listed in the commit message

Thu, Dec 5, 7:48 PM · Plasma
filipf committed R124:3095645414d9: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Thu, Dec 5, 5:04 PM
filipf committed R124:64fb5eb98eb8: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs (authored by filipf).
[Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs
Thu, Dec 5, 5:04 PM
filipf closed D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Thu, Dec 5, 5:04 PM · Plasma
filipf committed R119:7c11cb4685be: [Kickoff] Fix default avatar offset (authored by filipf).
[Kickoff] Fix default avatar offset
Thu, Dec 5, 11:05 AM

Wed, Dec 4

filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. The divider needs to be inside the application itself to make this possible, instead of in the titlebar.

If it's possible, fixing the color scheme and making it configurable should probably be the way to go.

Wed, Dec 4, 10:29 PM · Plasma
filipf added a comment to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

5.17 I say

Wed, Dec 4, 8:44 PM · Plasma
filipf committed R112:ca27d4688a90: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Wed, Dec 4, 7:54 PM
filipf committed R112:4550095c4771: [Applet] Replace missing icon (authored by filipf).
[Applet] Replace missing icon
Wed, Dec 4, 7:53 PM
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

add space before final )

Wed, Dec 4, 5:44 PM · Plasma
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

define condition without creating a variable

Wed, Dec 4, 5:41 PM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

So with the patch is it drawn when it is ticked in window decoration?

Wed, Dec 4, 1:32 PM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ?

Wed, Dec 4, 1:26 PM · Plasma
filipf updated the summary of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Wed, Dec 4, 12:17 PM · Plasma
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

don't break the sidebar

Wed, Dec 4, 12:14 PM · Plasma
filipf added a comment to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

So we also fix this by setting:

Wed, Dec 4, 11:04 AM · Plasma
filipf planned changes to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

I just realized this kills the sidebar when there's more than 1 kcm under a category :(

Wed, Dec 4, 10:42 AM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

But... the "Before" image looks better. :/

Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad IMO. Personally my preference is to restore consistency by moving in the opposite direction by always showing a separator between what I'm calling the window's "tools area" (which consists of its titlebar + menubar if visible + toolbar if visible). That's what T10201 is all about and I had thought we had some agreement on that. If we land this patch, then there's no separator below the Tools Area for these windows, going against the goal of T10201.

Wed, Dec 4, 10:35 AM · Plasma
filipf added reviewers for D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window: Plasma, VDG.
Wed, Dec 4, 2:29 AM · Plasma
filipf requested review of D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.
Wed, Dec 4, 2:28 AM · Plasma
filipf updated the summary of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Wed, Dec 4, 12:47 AM · Plasma
filipf added a reviewer for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs: Plasma.
Wed, Dec 4, 12:34 AM · Plasma
filipf requested review of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Wed, Dec 4, 12:33 AM · Plasma

Tue, Dec 3

filipf updated subscribers of T12308: Dolphin UI redesign.

I am absolutely in love with the dark version that has the dark separators. I think I might actually use a dark theme if it used dark separators like that!

Tue, Dec 3, 3:01 PM · VDG
filipf updated subscribers of T12308: Dolphin UI redesign.
Tue, Dec 3, 2:58 PM · VDG
filipf added a comment to D14581: support for multilevel kcms.

Hi, this patch triggered a bug in icon view: https://bugs.kde.org/show_bug.cgi?id=400876

Tue, Dec 3, 5:51 AM · Plasma

Mon, Dec 2

filipf updated the test plan for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Mon, Dec 2, 10:09 PM · Frameworks
filipf updated the test plan for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Mon, Dec 2, 10:07 PM · Frameworks
filipf added a reviewer for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes: Plasma.
Mon, Dec 2, 10:07 PM · Frameworks
filipf requested review of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Mon, Dec 2, 10:07 PM · Frameworks
filipf added a comment to T11925: Breeze Desktop Theme Transparency.

I like the idea of raising the contrast effect to 0.3, but if people object to that we should just keep it at 0.2.

Mon, Dec 2, 6:27 PM · VDG
filipf committed R120:beac5919274c: [System Tray] Clean up popup code (authored by filipf).
[System Tray] Clean up popup code
Mon, Dec 2, 4:58 PM
filipf closed D25614: [System Tray] Clean up popup code.
Mon, Dec 2, 4:58 PM · Plasma
filipf updated the diff for D25614: [System Tray] Clean up popup code.

onToggled instead of onClicked

Mon, Dec 2, 1:45 PM · Plasma
filipf added inline comments to D25614: [System Tray] Clean up popup code.
Mon, Dec 2, 10:16 AM · Plasma

Sat, Nov 30

filipf added a comment to T11915: Commission new official version of the KDE logo with the word "KDE" next to it or below it.

What about Fira Sans SemiBold like this?

Sat, Nov 30, 2:26 PM · VDG, KDE Promo

Fri, Nov 29

filipf committed R858:386248f6d454: [TabBar] Use window color instead of button color (authored by filipf).
[TabBar] Use window color instead of button color
Fri, Nov 29, 6:25 PM
filipf closed D25581: [TabBar] Use window color instead of button color.
Fri, Nov 29, 6:25 PM · Plasma
filipf added a comment to D25614: [System Tray] Clean up popup code.
Fri, Nov 29, 3:19 PM · Plasma
filipf added reviewers for D25614: [System Tray] Clean up popup code: Plasma, broulik.
Fri, Nov 29, 3:18 PM · Plasma
filipf requested review of D25614: [System Tray] Clean up popup code.
Fri, Nov 29, 3:17 PM · Plasma
filipf committed R120:37c1ec10888f: [System Tray] Restore old pin button size (authored by filipf).
[System Tray] Restore old pin button size
Fri, Nov 29, 3:06 PM
filipf closed D25602: [System Tray] Restore old pin button size.
Fri, Nov 29, 3:06 PM · Plasma

Thu, Nov 28

filipf updated the diff for D25602: [System Tray] Restore old pin button size.

use Layout.preferredHeight/Width instead of implicitHeight/Width

Thu, Nov 28, 7:49 PM · Plasma
filipf added reviewers for D25602: [System Tray] Restore old pin button size: Plasma, VDG.
Thu, Nov 28, 7:29 PM · Plasma
filipf requested review of D25602: [System Tray] Restore old pin button size.
Thu, Nov 28, 7:27 PM · Plasma
filipf committed R108:0ece47afa897: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Thu, Nov 28, 6:41 PM
filipf committed R108:fd69924e5153: [kcmkwin/kwindecoration] Better presentation of tabs (authored by filipf).
[kcmkwin/kwindecoration] Better presentation of tabs
Thu, Nov 28, 6:39 PM
filipf closed D25582: [kcmkwin/kwindecoration] Better presentation of tabs.
Thu, Nov 28, 6:39 PM · KWin
filipf updated subscribers of D25584: [TabBar] Add a border property.

Ah right, it will complain about a non-existing property.

Thu, Nov 28, 11:03 AM · Plasma
filipf added a comment to D25584: [TabBar] Add a border property.

With this patch:

Thu, Nov 28, 10:20 AM · Plasma
filipf added a comment to D25581: [TabBar] Use window color instead of button color.

Can you verify how the widgets QTabBar behaves in this scenario?

Thu, Nov 28, 9:34 AM · Plasma
filipf added a comment to D25015: Update breeze theme shadows.

My impression is that the rounding is currently just faked by the shadow. So when the shadow gets lighter, it becomes more obvious that the object itself isn't really rounded.

Thu, Nov 28, 1:06 AM · Frameworks
filipf added a comment to D25584: [TabBar] Add a border property.

Feels like at this point we should just break down and create an actual TabView control all at once. :p

Thu, Nov 28, 12:49 AM · Plasma
filipf added reviewers for D25584: [TabBar] Add a border property: Plasma, VDG.
Thu, Nov 28, 12:17 AM · Plasma
filipf requested review of D25584: [TabBar] Add a border property.
Thu, Nov 28, 12:16 AM · Plasma
filipf added a comment to D25582: [kcmkwin/kwindecoration] Better presentation of tabs.

A saner hack indeed. Probably 5.17-worthy. Can you apply the same thing to the plasma-pa KCM, if it also needs it?

Thu, Nov 28, 12:13 AM · KWin

Wed, Nov 27

filipf added a comment to D25582: [kcmkwin/kwindecoration] Better presentation of tabs.

P.S what would make this perfect is removing the border in the qqc2 styling of tabbars.

Wed, Nov 27, 11:53 PM · KWin
filipf added reviewers for D25582: [kcmkwin/kwindecoration] Better presentation of tabs: KWin, VDG.
Wed, Nov 27, 11:49 PM · KWin
filipf requested review of D25582: [kcmkwin/kwindecoration] Better presentation of tabs.
Wed, Nov 27, 11:48 PM · KWin
filipf added reviewers for D25581: [TabBar] Use window color instead of button color: Plasma, VDG.
Wed, Nov 27, 11:24 PM · Plasma
filipf requested review of D25581: [TabBar] Use window color instead of button color.
Wed, Nov 27, 11:23 PM · Plasma

Mon, Nov 25

filipf added a comment to D25514: Simpler theme deletion.

As far as I can tell theme names don't always match the folder names they reside in.

Mon, Nov 25, 4:30 PM · Plasma
filipf added reviewers for D25514: Simpler theme deletion: davidedmundson, Plasma.
Mon, Nov 25, 8:25 AM · Plasma
filipf requested review of D25514: Simpler theme deletion.
Mon, Nov 25, 8:24 AM · Plasma

Thu, Nov 21

filipf committed R123:1efecc9608cc: Improve package documentation (authored by filipf).
Improve package documentation
Thu, Nov 21, 10:24 PM
filipf closed D25415: Improve package documentation.
Thu, Nov 21, 10:24 PM · Plasma
filipf updated the diff for D25415: Improve package documentation.

minor indentation fix

Thu, Nov 21, 10:23 PM · Plasma
filipf added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

I'm thinking users might use PNGs with transparency for their avatars, which means they might not want to have a border around it.

Thu, Nov 21, 9:12 PM · Plasma

Wed, Nov 20

filipf updated the diff for D25415: Improve package documentation.

simpler dependencies list

Wed, Nov 20, 9:24 PM · Plasma
filipf added a comment to D25415: Improve package documentation.

Maybe I shouldn't list all those dependencies like that. The list would probably get outdated soon and maybe the deps can be listed more abstractly so there's fewer lines.

Wed, Nov 20, 11:41 AM · Plasma

Tue, Nov 19

filipf added a comment to D25006: Make sure -dpi value is valid.

Friendly ping.

Tue, Nov 19, 10:16 PM · Plasma
filipf added a comment to T9041: New "Home" tab for Kickoff.

I like bottom left. I think that highlight effect is more appropriate as it indicates that some category has been selected. The one in the top left feels more like the effect when you hover over items in a list (but nothing is simultaneously open).

Tue, Nov 19, 10:04 PM · Plasma, VDG
filipf added a comment to D25337: Change transparency to 10% and added blur.

I don't think legibility would be an issue, but it's true this wouldn't be consistent with other windows. The idea to also be able to control Konsole's transparency via some global setting sounds good.

Tue, Nov 19, 9:36 PM · Konsole
filipf added a comment to D25413: [Weather] Make compact representation temperature text match size of clock text.

and I should feel bad.

Tue, Nov 19, 9:33 PM · Plasma
filipf committed R120:f56e800c9634: Use the same avatar size in lock, login and logout screens (authored by filipf).
Use the same avatar size in lock, login and logout screens
Tue, Nov 19, 9:13 PM
filipf closed D25024: Use the same avatar size in lock, login and logout screens.
Tue, Nov 19, 9:13 PM · Plasma
filipf updated the summary of D25415: Improve package documentation.
Tue, Nov 19, 9:04 PM · Plasma
filipf added reviewers for D25415: Improve package documentation: Plasma, VDG, ngraham.
Tue, Nov 19, 9:04 PM · Plasma