As far as I'm concerned the patch is landable; I really like that it's developed into a more generic placeholder rather than one just for distro logos. Nice work @cblack, make sure to edit the commit title and message to reflect this though.

There is an example in the Fuzzy Clock config:

Logo size still looks too big to me; IMO these things shouldn't be too much in the users' face and the logo shouldn't overpower the clock. Also I think the second screenshot doesn't accurately represent new code.

I'm testing this out now and there seems to be only one obstacle left, see inline comment

In D22468#495727, @filipf wrote:

Yeah I may have improvised that with the Night Color KCM 😊

The HIG way (and looking at other places) is to put the value to the right of the slider.

In D22468#495721, @romangg wrote:

In D22468#495679, @filipf wrote:

Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise.

Only some minor things I noticed in the screenshots:

• can the margins on the view area be increased so that it's in line with where the text begins (red is what I'd remove)?
  

Do you know if there is an "official" margin value for that?

Looks like smallSpacing but not quite so I'm going to check it out live and report back.

Yeah I may have improvised that with the Night Color KCM 😊

Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

In D22426#495465, @ognarb wrote:

In D22426#494745, @guoyunhe wrote:

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget.

Where did you read that Unsplash images were CC0? The license is not CC0 and is in fact non-free. Or are the pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers licensed explicitly under CC0?

Failure messages do seem to be generated

remove message box on successful operation, use job error text when the operation fails

Unsplash has very good wallpapers; in my opinion this automatically becomes the most attractive POTD plugin.

Use KMessageBox to show information whether or not the sync and reset operations succeeded

In D22191#493949, @ngraham wrote:

In D22191#493928, @filipf wrote:

In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed.

But as far as I can tell the operations won't fail. They're all conditional on values being existent or not and if things aren't in order they won't get carried out.

Famous last words. :) You never know what situations users will get themselves into. Maybe they discover the feature while testing with a live CD where the root filesystem isn't writable, for example.

In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed.

.

better solution for fontconfig copy operations check

• Merge branch 'master' into sddm-theme-syncing

Use Kirigami.SearchField instead of Kirigami.ActionTextField

Ping, with D22230 landed this should also follow quite soon.

In D22191#490399, @cfeck wrote:

See also bug 403953 and bug 408863.

If keeping the new menu style we have to wait until all those patches get merged in Plasma.

Ahoj. Visually both the placement and the chosen icon seem good, but I would also say we need a tooltip.

sddmauthhelper.cpp

• don't needlesslydefine SDDM user twice
• revert to copying files only if entry is not empty

use DescriptiveLabel for subtitle/artist info

@hein would you want me to use PlasmaExtras.DescriptiveLabel for the subtitle, same as in D22231? Makes us not have to specify opacity.

use DescriptiveLabel for subtitle

In D22191#489925, @ndavis wrote:

In D22191#489915, @GB_2 wrote:

I think then you would have to type in your password every time you change a setting.

Would you really? There couldn't be a service running with the right permissions that automatically synchronizes settings on logout/user switch/shutdown/when a change is detected? It seems like it should be possible, but I don't know what the security implications would be.

remove 2 unused imports

get rid of KDevelop files that accidentally got added to the diff

• Merge branch 'master' into sddm-theme-syncing

missed an import

also update the .ui file

• have explanation label use the "small" font
• minor cleanup

Nice, looks good and is a lot cleaner.

• don't hardcode SDDM user directory

_ code cleanup

• remove SDDM dir cache cleanup operations
• remove uncessary references to KCModule
• redo the .ui file

Can anyone from Plasma have a quick look if this is okay?

Definitely have to fix the hardcoding.

In D22106#487287, @mglb wrote:

Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76

Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color.

friendly ping

In D22128#487943, @ngraham wrote:

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

+100 for this goal. One thing we should definitely fix is scrollbars overlapping content. The rest I don't care too much tbh, but it would probably look better if we didn't separate the track and the bar from the content (as the default).

This was landed but arc is confused: https://cgit.kde.org/user-manager.git/commit/?id=f78202c2face8d64af63281fd4c4eb4237314cc5.

I lost the original clone, arc patch doesn't work; I have to update the current diff to land

Don't know, I removed both of the patches and the issue's still there. Yeah this was 2x scaling and the indicator should be 6px.

Awesome 😍

In D22108#487218, @ndavis wrote:

1+ visually. How does it look with a vertical panel?

I've been thinking about this OSD themes thing and I can't say I like it. I don't like the fact that you now need a different LnF to change them either, but to have another configurable theme thing seems like overkill.

In D22108#487140, @apol wrote:

Makes sense to me, but why are the computer icons different? ^^'

Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze:

Generally +1, but let's disable it for destructive kcms.

In T11124#190080, @ndavis wrote:

In T11124#189927, @fabianr wrote:

As soon as the official highlight effect(s) are defined, they need to be added to the HIG https://invent.kde.org/websites/hig-kde-org/issues/10

Will do.

@filipf What do you think we should do with comboboxes and toolbar buttons?

highlight effect: remove unused ID and bettery opacity values

Also implement the upcoming highlight style