Feed Advanced Search

Yesterday

filipf accepted D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

As far as I'm concerned the patch is landable; I really like that it's developed into a more generic placeholder rather than one just for distro logos. Nice work @cblack, make sure to edit the commit title and message to reflect this though.

Tue, Jul 16, 9:58 AM · Plasma

Mon, Jul 15

filipf added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

There is an example in the Fuzzy Clock config:

Mon, Jul 15, 9:54 PM · Plasma
filipf added a comment to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Logo size still looks too big to me; IMO these things shouldn't be too much in the users' face and the logo shouldn't overpower the clock. Also I think the second screenshot doesn't accurately represent new code.

Mon, Jul 15, 7:16 PM · Plasma
filipf added a comment to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

I'm testing this out now and there seems to be only one obstacle left, see inline comment

Mon, Jul 15, 5:54 PM · Plasma
filipf added inline comments to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Mon, Jul 15, 5:40 PM · Plasma
filipf added inline comments to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Mon, Jul 15, 5:29 PM · Plasma
filipf added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

Yeah I may have improvised that with the Night Color KCM 😊

The HIG way (and looking at other places) is to put the value to the right of the slider.

Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise.

Only some minor things I noticed in the screenshots:

  • can the margins on the view area be increased so that it's in line with where the text begins (red is what I'd remove)?

Do you know if there is an "official" margin value for that?

Looks like smallSpacing but not quite so I'm going to check it out live and report back.

Mon, Jul 15, 11:21 AM · Plasma
filipf added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

Yeah I may have improvised that with the Night Color KCM 😊

Mon, Jul 15, 9:45 AM · Plasma
filipf added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise.

Mon, Jul 15, 8:03 AM · Plasma
filipf added a comment to D22469: Don't use "Unlimited" number of lines in Icon View by default.

I agree with what you said. I'd suggest the value be bumped up to 3; it still looks good.

Mon, Jul 15, 7:42 AM · Dolphin

Sun, Jul 14

filipf added a comment to D22426: Add Unsplash POTD Provider.

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget.

Where did you read that Unsplash images were CC0? The license is not CC0 and is in fact non-free. Or are the pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers licensed explicitly under CC0?

Sun, Jul 14, 11:44 PM · Plasma

Fri, Jul 12

filipf added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.

Failure messages do seem to be generated

Fri, Jul 12, 10:58 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

remove message box on successful operation, use job error text when the operation fails

Fri, Jul 12, 10:56 PM · Plasma
filipf added a comment to D22426: Add Unsplash POTD Provider.

Unsplash has very good wallpapers; in my opinion this automatically becomes the most attractive POTD plugin.

Fri, Jul 12, 7:16 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

Use KMessageBox to show information whether or not the sync and reset operations succeeded

Fri, Jul 12, 5:40 PM · Plasma

Thu, Jul 11

filipf added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.

In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed.

But as far as I can tell the operations won't fail. They're all conditional on values being existent or not and if things aren't in order they won't get carried out.

Famous last words. :) You never know what situations users will get themselves into. Maybe they discover the feature while testing with a live CD where the root filesystem isn't writable, for example.

Thu, Jul 11, 5:26 AM · Plasma

Wed, Jul 10

filipf added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.

In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed.

Wed, Jul 10, 9:57 PM · Plasma
filipf added a dependency for D22363: Remove cursor theme option: D22191: Implement syncing of theme preferences between SDDM and Plasma.
Wed, Jul 10, 8:55 AM · Plasma
filipf added a dependent revision for D22191: Implement syncing of theme preferences between SDDM and Plasma: D22363: Remove cursor theme option.
Wed, Jul 10, 8:55 AM · Plasma
filipf added reviewers for D22363: Remove cursor theme option: ngraham, davidedmundson.
Wed, Jul 10, 2:23 AM · Plasma
filipf requested review of D22363: Remove cursor theme option.
Wed, Jul 10, 2:22 AM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

.

Wed, Jul 10, 1:58 AM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

better solution for fontconfig copy operations check

Wed, Jul 10, 1:57 AM · Plasma

Tue, Jul 9

filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.
  • Merge branch 'master' into sddm-theme-syncing
Tue, Jul 9, 2:35 PM · Plasma

Sat, Jul 6

filipf committed R120:b414ac1c7a09: [Lock screen] Follow KDE title & subtitle style (authored by filipf).
[Lock screen] Follow KDE title & subtitle style
Sat, Jul 6, 7:48 AM
filipf closed D22231: [Lock screen] Follow KDE title & subtitle style.
Sat, Jul 6, 7:48 AM · Plasma
filipf committed R108:f2bbb60419f8: [kcmkwin] Add a clear button to the Desktop Effects search field (authored by filipf).
[kcmkwin] Add a clear button to the Desktop Effects search field
Sat, Jul 6, 7:47 AM
filipf closed D22286: [kcmkwin] Add a clear button to the Desktop Effects search field.
Sat, Jul 6, 7:47 AM · KWin

Fri, Jul 5

filipf updated the summary of D22286: [kcmkwin] Add a clear button to the Desktop Effects search field.
Fri, Jul 5, 10:20 AM · KWin
filipf updated the diff for D22286: [kcmkwin] Add a clear button to the Desktop Effects search field.

Use Kirigami.SearchField instead of Kirigami.ActionTextField

Fri, Jul 5, 10:19 AM · KWin
filipf added reviewers for D22286: [kcmkwin] Add a clear button to the Desktop Effects search field: KWin, VDG.
Fri, Jul 5, 9:33 AM · KWin
filipf requested review of D22286: [kcmkwin] Add a clear button to the Desktop Effects search field.
Fri, Jul 5, 9:32 AM · KWin

Thu, Jul 4

filipf added a comment to D22231: [Lock screen] Follow KDE title & subtitle style.

Ping, with D22230 landed this should also follow quite soon.

Thu, Jul 4, 9:10 PM · Plasma
filipf committed R119:741ffda94294: [TaskManager] Follow KDE title & subtitle style (authored by filipf).
[TaskManager] Follow KDE title & subtitle style
Thu, Jul 4, 9:09 PM
filipf closed D22230: [TaskManager] Follow KDE title & subtitle style.
Thu, Jul 4, 9:09 PM · Plasma
filipf committed R119:76045bf20e07: [Kickoff] Redo tab bar separator's geometry (authored by filipf).
[Kickoff] Redo tab bar separator's geometry
Thu, Jul 4, 9:07 PM
filipf closed D22128: [Kickoff] Redo tab bar separator's geometry.
Thu, Jul 4, 9:07 PM · Plasma
filipf accepted D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
Thu, Jul 4, 8:22 PM · Frameworks

Wed, Jul 3

filipf added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.

See also bug 403953 and bug 408863.

Wed, Jul 3, 9:51 PM · Plasma
filipf added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

If keeping the new menu style we have to wait until all those patches get merged in Plasma.

Wed, Jul 3, 9:40 PM · Plasma
filipf added a comment to D22127: Add button to swap X and Y in Plot Setup dialog.

Ahoj. Visually both the placement and the chosen icon seem good, but I would also say we need a tooltip.

Wed, Jul 3, 9:37 PM · KDE Edu, Kalzium
filipf added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Wed, Jul 3, 9:34 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

sddmauthhelper.cpp

  • don't needlesslydefine SDDM user twice
  • revert to copying files only if entry is not empty
Wed, Jul 3, 9:33 PM · Plasma
filipf updated the diff for D22230: [TaskManager] Follow KDE title & subtitle style.

use DescriptiveLabel for subtitle/artist info

Wed, Jul 3, 11:39 AM · Plasma
filipf added a comment to D22230: [TaskManager] Follow KDE title & subtitle style.

@hein would you want me to use PlasmaExtras.DescriptiveLabel for the subtitle, same as in D22231? Makes us not have to specify opacity.

Wed, Jul 3, 11:17 AM · Plasma
filipf updated the diff for D22231: [Lock screen] Follow KDE title & subtitle style.

use DescriptiveLabel for subtitle

Wed, Jul 3, 11:11 AM · Plasma
filipf added reviewers for D22231: [Lock screen] Follow KDE title & subtitle style: Plasma, VDG, ngraham.
Wed, Jul 3, 9:06 AM · Plasma
filipf requested review of D22231: [Lock screen] Follow KDE title & subtitle style.
Wed, Jul 3, 9:05 AM · Plasma
filipf added reviewers for D22230: [TaskManager] Follow KDE title & subtitle style: Plasma, VDG, ngraham.
Wed, Jul 3, 9:00 AM · Plasma
filipf requested review of D22230: [TaskManager] Follow KDE title & subtitle style.
Wed, Jul 3, 8:58 AM · Plasma
filipf added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.
In D22191#489915, @GB_2 wrote:

I think then you would have to type in your password every time you change a setting.

Would you really? There couldn't be a service running with the right permissions that automatically synchronizes settings on logout/user switch/shutdown/when a change is detected? It seems like it should be possible, but I don't know what the security implications would be.

Wed, Jul 3, 7:52 AM · Plasma

Tue, Jul 2

filipf added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Tue, Jul 2, 12:25 PM · Plasma
filipf committed R123:edaae61c36de: Make includes more orderly (authored by filipf).
Make includes more orderly
Tue, Jul 2, 8:46 AM
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

remove 2 unused imports

Tue, Jul 2, 8:32 AM · Plasma
filipf added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Tue, Jul 2, 8:13 AM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

get rid of KDevelop files that accidentally got added to the diff

Tue, Jul 2, 8:12 AM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.
  • Merge branch 'master' into sddm-theme-syncing
Tue, Jul 2, 8:10 AM · Plasma

Mon, Jul 1

filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

missed an import

Mon, Jul 1, 11:49 PM · Plasma
filipf added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 11:46 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.

also update the .ui file

Mon, Jul 1, 11:46 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.
  • have explanation label use the "small" font
  • minor cleanup
Mon, Jul 1, 11:44 PM · Plasma
filipf updated subscribers of D22176: Rework system tray settings.

Nice, looks good and is a lot cleaner.

Mon, Jul 1, 10:24 PM · Plasma
filipf updated the test plan for D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 9:52 PM · Plasma
filipf updated the test plan for D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 9:52 PM · Plasma
filipf added inline comments to D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 9:52 PM · Plasma
filipf updated the diff for D22191: Implement syncing of theme preferences between SDDM and Plasma.
  • don't hardcode SDDM user directory

_ code cleanup

  • remove SDDM dir cache cleanup operations
  • remove uncessary references to KCModule
  • redo the .ui file
Mon, Jul 1, 9:49 PM · Plasma
filipf added a comment to D22128: [Kickoff] Redo tab bar separator's geometry.

Can anyone from Plasma have a quick look if this is okay?

Mon, Jul 1, 8:53 PM · Plasma
filipf planned changes to D22191: Implement syncing of theme preferences between SDDM and Plasma.

Definitely have to fix the hardcoding.

Mon, Jul 1, 3:27 PM · Plasma
filipf added reviewers for D22191: Implement syncing of theme preferences between SDDM and Plasma: Plasma, ngraham, davidedmundson, VDG.
Mon, Jul 1, 3:15 PM · Plasma
filipf requested review of D22191: Implement syncing of theme preferences between SDDM and Plasma.
Mon, Jul 1, 3:13 PM · Plasma

Sun, Jun 30

filipf committed R242:97272465a8b4: [TabBar] Remove exterior margins (authored by filipf).
[TabBar] Remove exterior margins
Sun, Jun 30, 10:50 PM
filipf closed D22108: [TabBar] Remove exterior margins.
Sun, Jun 30, 10:50 PM · Frameworks
filipf added a comment to D22106: [Separator] Match Breeze borders' color.
In D22106#487287, @mglb wrote:

Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76

Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color.

Sun, Jun 30, 10:04 PM · Kirigami
filipf added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

friendly ping

Sun, Jun 30, 10:03 PM · Frameworks

Fri, Jun 28

filipf committed R128:f78202c2face: Do not capitalize placeholder username (authored by filipf).
Do not capitalize placeholder username
Fri, Jun 28, 8:59 PM
filipf added a comment to D22128: [Kickoff] Redo tab bar separator's geometry.

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

Fri, Jun 28, 8:58 PM · Plasma
filipf added a comment to T9126: Breeze scrollbar look-and-feel unification.

+100 for this goal. One thing we should definitely fix is scrollbars overlapping content. The rest I don't care too much tbh, but it would probably look better if we didn't separate the track and the bar from the content (as the default).

Fri, Jun 28, 8:46 PM · VDG
filipf closed D22104: Do not capitalize placeholder username.

This was landed but arc is confused: https://cgit.kde.org/user-manager.git/commit/?id=f78202c2face8d64af63281fd4c4eb4237314cc5.

Fri, Jun 28, 8:40 PM · Plasma
filipf updated the diff for D22104: Do not capitalize placeholder username.

I lost the original clone, arc patch doesn't work; I have to update the current diff to land

Fri, Jun 28, 8:37 PM · Plasma
filipf added a comment to D22128: [Kickoff] Redo tab bar separator's geometry.

Don't know, I removed both of the patches and the issue's still there. Yeah this was 2x scaling and the indicator should be 6px.

Fri, Jun 28, 8:36 AM · Plasma

Thu, Jun 27

filipf added reviewers for D22128: [Kickoff] Redo tab bar separator's geometry: Plasma, VDG.
Thu, Jun 27, 10:07 PM · Plasma
filipf requested review of D22128: [Kickoff] Redo tab bar separator's geometry.
Thu, Jun 27, 10:03 PM · Plasma
filipf added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Awesome 😍

Thu, Jun 27, 4:07 PM · Plasma
filipf awarded D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders a Love token.
Thu, Jun 27, 4:02 PM · Plasma
filipf added a comment to D22108: [TabBar] Remove exterior margins.

1+ visually. How does it look with a vertical panel?

Thu, Jun 27, 3:50 PM · Frameworks
filipf added a comment to D20569: RFC: Use more compact OSD.

I've been thinking about this OSD themes thing and I can't say I like it. I don't like the fact that you now need a different LnF to change them either, but to have another configurable theme thing seems like overkill.

Thu, Jun 27, 11:30 AM · Plasma
filipf added a comment to D22108: [TabBar] Remove exterior margins.
In D22108#487140, @apol wrote:

Makes sense to me, but why are the computer icons different? ^^'

Thu, Jun 27, 10:54 AM · Frameworks

Wed, Jun 26

filipf added reviewers for D22108: [TabBar] Remove exterior margins: VDG, Plasma, ngraham.
Wed, Jun 26, 7:38 PM · Frameworks
filipf requested review of D22108: [TabBar] Remove exterior margins.
Wed, Jun 26, 7:38 PM · Frameworks
filipf added a comment to D22106: [Separator] Match Breeze borders' color.

Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze:

Wed, Jun 26, 5:49 PM · Kirigami
filipf added reviewers for D22106: [Separator] Match Breeze borders' color: Kirigami, VDG, ngraham.
Wed, Jun 26, 5:40 PM · Kirigami
filipf requested review of D22106: [Separator] Match Breeze borders' color.
Wed, Jun 26, 5:39 PM · Kirigami
filipf added reviewers for D22104: Do not capitalize placeholder username: Plasma, ngraham.
Wed, Jun 26, 3:19 PM · Plasma
filipf requested review of D22104: Do not capitalize placeholder username.
Wed, Jun 26, 3:19 PM · Plasma
filipf added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

Generally +1, but let's disable it for destructive kcms.

Wed, Jun 26, 2:38 PM · Frameworks

Tue, Jun 25

filipf added a comment to T11124: Unify highlight effect style.

As soon as the official highlight effect(s) are defined, they need to be added to the HIG https://invent.kde.org/websites/hig-kde-org/issues/10

Will do.

@filipf What do you think we should do with comboboxes and toolbar buttons?

Tue, Jun 25, 4:06 PM · VDG

Mon, Jun 24

filipf updated the diff for D20908: RFC: Redesign QML applet configuration windows.

highlight effect: remove unused ID and bettery opacity values

Mon, Jun 24, 3:02 PM · Plasma
filipf updated the diff for D20908: RFC: Redesign QML applet configuration windows.

Also implement the upcoming highlight style

Mon, Jun 24, 2:58 PM · Plasma
filipf committed R113:70243942ef1d: Ship color schemes with Oxygen (authored by filipf).
Ship color schemes with Oxygen
Mon, Jun 24, 2:33 PM
filipf closed D21702: Ship color schemes with Oxygen.
Mon, Jun 24, 2:33 PM · Plasma