If you want you can also look at the ones I tried to add here https://phabricator.kde.org/D18078

In T14211#260926, @ognarb wrote:

In T14211#260924, @GB_2 wrote:

In T14211#255944, @ngraham wrote:

I'm kinda confused. You mean that, the sidebar and the files view (content) should share the same colour? Like in Discover?

Yes.

Does not seem like a good idea to me. We should make an effort to help users distinguish the areas of the window more easily, like we already do with the titlebar and window content. Pretty much every platform has this separation. It's also more pleasing to the eye.

+1 personally I would like to see sidebar using a subtle grey and the content all white. This would give a nice visual hierarchy there white is the predominant color on the screen and this will also reduce the impression that Breeze is old-looking because it's too much grey.

Kinda like the Clock screenshot but with a sidebar even less greyish

In T11930#259816, @GB_2 wrote:

If this hasn't already been fixed then we should just hardcode the colors, looks the best and should be easy to do.

In D23257#677396, @davidre wrote:

I rebased it because of the rewrite that happened, can you check if everything is still ok @filipf

I think it should work same as when I submitted the patch. It would be good to add a comment though that this feature is only supported for for SDDM 0.19 and above.

In T11661#243532, @manueljlin wrote:

Does this apply to the new Kirigami dividers? We're slowly removing lines in some places but now we're adding it between every list item on the sidebars so this feels like one step forward and two steps back lol

Michael's made a good point about the longevity of this default setting. If it's been set to single click for 20 years and the majority (?) of the users still use double-click then it's ultimately a failure, regardless of whether or not the engineer arguments are valid.

Some simple statements applicable here and in other discussions:

In T8187#243291, @ngraham wrote:

Looks like it's time to re-open this ancient discussion. :)

It's probably a better place to discuss the matter than an MR anyway (https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/121).

https://invent.kde.org/plasma/plasma-workspace/commit/21bdc2a89d123932af2a1b04bd8e98ff868bf3eb

In D28154#672453, @ngraham wrote:

Now that D29394 has landed, you can add those images here!

In D29263#673135, @niccolove wrote:

I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?

Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI sheet that exposes theme.conf and then blur would be one option.

In D29765#671401, @broulik wrote:

Can we perhaps add infrastructure so that a theme can provide options?
For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls".
I'm not keen on duplicating the entire theme for a single option.

The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for focus-background and pressed.

don't delete user_manager.kdev4

Make as REUSE compliant as possible

In D29394#670076, @ngraham wrote:

The .license files could live in another folder. Maybe src/pics_sources?

In D29394#670030, @jriddell wrote:

Looks good for licence freedom

Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE.

So add cat.jpg.license files with SPDX header lines saying CC0 and add /LICENSES/CC0-1.0.txt

rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it)

Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header

actually remove Chip and Gecko(due to rename)

• rename Gecko to Chameleon because that wasn't a gecko
• remove Chip
• add Air Balloon, Dog, Fish, Owl, Pencils, Sushi
• WIP: licence files

Works well and looks good.

Some pictures I didn't include in case people like them:

• Remove all Unsplash and Pexels licensed photos to avoid complications.
• Use CC0 pictures from Pexels instead
• Licence files to be added

Is this okay now @mart and okay to land on 5.18?

IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to do CC0 but we'll still credit them. Thanks @ognarb and @jriddell.

If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current default, why do we go against that? And if it's just a matter of not touching defaults, can you guarantee users are going to be equally content with a left panel as a default?

After additional consideration, I'm not too happy with the car avatar but I did find this:

I'd also be interested if KDE Promo has any insights here. It doesn't seem (?) like we advertise it too much, but I know reviews often praise Plasma for its familiarity for Windows users. Given our major competitor does the opposite and that the majority of our new users are going to be Windows converts (and keeping in mind that the less technologically able people tend to not like unfamiliarity), it seems like a good market share to grab. Changing the layout could mean a boost for other competitors such as Zorin. Thoughts?

This is a major identity change better suited for Plasma 6. We've never had a vertical panel and are moreover defined by offering a layout familiar to Windows users.

We only use the biggest size in this repo.

Should I also land this for 5.18 (do I have to create a bug report first)?

Drop:

• Air Balloon
• Gamepad

In D29394#663012, @ngraham wrote:

Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154. Once this lands, @cblack can grab these and add them to that patch.

restore the inline message but change its text to note that layout changes have been restricted by the sysadmin

Replace PropertyAnimation with NumberAnimation

In D29394#662776, @ognarb wrote:

Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their photographies under a creative commons license (not the noncommercial and the no edit one)

probably don't want to include the .directory file

Better file naming

Alright, I believe the issue is with the fact that the avatar gallery is coded to always look for avatars in the system /usr/share dir as opposed to adjusting to testing conditions and using the local /usr/share dir.

The permissions are wrong if we do sudo make install (the photos folder ends up being root owned). But it doesn't show up with make install either. Will investigate more in the morning.

I've proposed some avatars in D29394.

Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels licence)
Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ (CC0 licence)
Car: https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974 (CC0 licence)
Cocktail: https://www.pexels.com/photo/sea-sky-beach-holiday-68672/ (CC0)
HotAirBalloon: https://www.pexels.com/photo/hot-air-balloon-on-mid-air-above-rock-formation-2893960/ (Pexels licence)
Joystick: https://www.pexels.com/photo/game-controller-159204/ (CC0 licence)
Keyboard: https://unsplash.com/photos/WzKPT0IuUrU (Unsplash licence)
Leopard: https://unsplash.com/photos/wYy3rvvgjAU (Unsplash licence)
Parrot: https://unsplash.com/photos/V9VDd-2s3aE (Unsplash licence)
RubikCube: https://unsplash.com/photos/liMvhbUq4Xg (Unsplash licence)
Sunflower: https://unsplash.com/photos/XtXdHH-Ib7c (Unsplash licence)
Shuttle: https://www.pexels.com/photo/flight-sky-earth-space-2159/ (CC0 licence)

In D22700#662134, @guoyunhe wrote:

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

move the code change to CurrentItemHighlight.qml

In D27688#661903, @ngraham wrote:

Ah, I didn't realize that Kamoso had moved to invent. You need to change the remote to point to the new gitlab URL: git remote set-url origin git@invent.kde.org:kde/kamoso.git

Then arc land should work as normal.

Ok, so the message can indeed still be turned on.

In D29366#661834, @ngraham wrote:

Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would be that your admin/technically competent grandson has enabled it for your own good and this shouldn't be highlighted?

Generally I think we can all agree on doing away with QQC1 and PC2, however...

I can't land this at all, do I have to clone from Invent?

Yeah we shouldn't be mixing Kirigami with Plasma.

Ditch OpacityAnimator and use PropertyAnimation

This kills the animation though... I found this comment in other code:
"//OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)"