[FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI
ClosedPublic

Authored by ngraham on Mon, Apr 22, 8:28 PM.

Details

Summary
  • Port to QQC2 and Kirigami+FormLayout
  • Use radio buttons to choose color vs image
  • Disable inactive controls appropriately
Test Plan

Everything still works.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mon, Apr 22, 8:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Apr 22, 8:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Apr 22, 8:28 PM
ngraham retitled this revision from [FifteenPuzzle] Modernize settings window to [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout.Mon, Apr 22, 8:35 PM
ngraham edited the summary of this revision. (Show Details)
filipf added a subscriber: filipf.Tue, Apr 23, 12:05 PM
filipf added inline comments.
applets/fifteenPuzzle/package/contents/ui/configAppearance.qml
71–74

You could have enabled: !useImageCheckBox.checked here

84

And then enabled: showNumeralsCheckBox.checked here

ngraham updated this revision to Diff 56840.Tue, Apr 23, 7:22 PM
ngraham marked 2 inline comments as done.

Improve it even more (hopefully)

ngraham edited the summary of this revision. (Show Details)Tue, Apr 23, 7:23 PM
ngraham edited the test plan for this revision. (Show Details)
GB_2 added a subscriber: GB_2.Tue, Apr 23, 8:09 PM
GB_2 added inline comments.
applets/fifteenPuzzle/package/contents/ui/configAppearance.qml
136

You could make it like this:
Tiles: [ ] Colored numbers: [ Button ]

Tried it out, looks good and is efficient.

One behavior thing though, I'm not getting any background option that's being defaulted to:

The "Color" option is not being remembered either (the color itself is, but not that you're using that option).

ngraham planned changes to this revision.Tue, Apr 23, 8:44 PM

Oh, duh.

ngraham updated this revision to Diff 56919.Wed, Apr 24, 8:37 PM

Remember checked state for Color radio button

ngraham updated this revision to Diff 56920.Wed, Apr 24, 8:39 PM
ngraham marked an inline comment as done.

Tweak UI according to review comments

ngraham edited the test plan for this revision. (Show Details)Wed, Apr 24, 8:40 PM
ngraham retitled this revision from [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout to [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
ngraham edited the summary of this revision. (Show Details)
GB_2 accepted this revision as: VDG, GB_2.Wed, Apr 24, 8:42 PM
This revision is now accepted and ready to land.Wed, Apr 24, 8:42 PM
filipf accepted this revision.Wed, Apr 24, 8:44 PM
This revision was automatically updated to reflect the committed changes.