Without rounding the result, sub-pixel rounding errors accumulate over time, making the
label blurry.
Details
- Reviewers
fvogt hein filipf - Group Reviewers
Plasma - Commits
- R119:05e59e1c77c4: [Folder View] Improve label crispness
Nice and crisp now:
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Huge improvement, Nate, and an excellent find. The rest of the reviewers can also have a look at my before and after photos for more proof:
Before:
After:
It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good)
Probably a side effect of the label width change(s).
This diff might not be entirely correct as the rounding error can accumulate across all columns, thus making the width of all cells combined greater than the container's width.
I just added a ton of items to the desktop and tested with all combinations of icon sizes and label widths; in no case did the content ever overflow the container. I didn't see any other visual artifacts, either.