Update

In D25611#569453, @fredrik wrote:

The decoration parts should already be padded. The commit message in the commit that introduced the atlas (6ad4c775d7840e64a07e27d6719a3ea7c3ee5eb8) even says so:
"The images are separated by a row of transparent texels to minimize artifacts from oversampling."

In D24660#567833, @cblack wrote:

I don't have exact steps, but you're bound to run into it if you snap CSD windows frequently. I don't experience equivalent behavior under Mutter so I'm assuming it's something to do with the window manager. You can tell when the window is snapping odd by the window content clipping.

In D25507#568086, @romangg wrote:

In D25507#567683, @zzag wrote:

I don't see any particular reason that holds us from doing that, but meh fair enogh. Could you please create a Phabricator task so we don't forget to refactor this code?

See D25558

I don't see any particular reason that holds us from doing that, but meh fair enogh. Could you please create a Phabricator task so we don't forget to refactor this code?

In D24660#567019, @cblack wrote:

I've been using this patch for a while, and here are some things I've noticed:

• Thumbnails include window shadow; this appears fine in alt-tab switcher but on panel switcher thumbnails they're drawn with a solid background.

Thank you for looking into this! The way conversion between Qt::ScreenOrientations and DeviceInterface::Transform is done seems to be wrong.

We also use KPluginTrader in PreviewBridge (declarative-plugin/previewbridge.cpp).

In T10611#208778, @ngraham wrote:

Could we sync that setting for those themes that do have this option?

In D25366#564093, @davidedmundson wrote:

Urgh, I'm sure this is the second case I've seen of this at least.

in AnimationEffect::postPaintScreen. Why?

In D20261#443859, @broulik wrote:

This is a bug in Quassel, a violation of the FDO spec, it should have ebeen quassel-tray-inactive or something

Window decorations (fixes https://bugs.kde.org/show_bug.cgi?id=414113)

Test plan:

• Install https://github.com/zzag/kwin-effects-yet-another-magic-lamp
• Change the animation speed in the compositor settings
• Minimize a window

I'm targeting 5.17.X and perhaps 5.12.X.

This still looks slightly over-engineered. You could put everything in one class and add a few convenience methods to make it a bit easier to use the new class.

Sweet! I wonder whether this KDED module can be used to synchronize the gtk-decoration-layout property with kwin's decoration button layout.

In D24457#562080, @davidedmundson wrote:

Let me try and explain my point again.

[...]

In another invocation of TopLevel::addDamage the argument is relative to the frame (when we're in the overridden implementation calling the base implementation)

In D24457#561907, @davidedmundson wrote:

When we call

Toplevel::addDamage(damage);

TopLevel::addDamage is relative to the frame

Okay, I see.