Feed Advanced Search

Today

zzag updated the diff for D25786: [nightcolor] Introduce inhibition API.

Use correct object path for PropertiesChanged signal.

Thu, Dec 12, 4:12 PM · KWin
zzag added a comment to D25923: [KCMs/Night Color] Remove "manual location entry" mode.

This mode can be useful for people concerned about privacy.

Thu, Dec 12, 3:35 PM · Plasma
zzag committed R108:31e664783f36: Revert "[effects/fallapart] Override scale, fade, and glide effect" (authored by zzag).
Revert "[effects/fallapart] Override scale, fade, and glide effect"
Thu, Dec 12, 1:51 PM
zzag added a reverting change for R108:1747e497e4a2: [effects/fallapart] Override scale, fade, and glide effect: R108:31e664783f36: Revert "[effects/fallapart] Override scale, fade, and glide effect".
Thu, Dec 12, 1:51 PM
zzag committed R108:8ab727766a51: [scenes/xrender] Correctly render client-side decorated clients (authored by zzag).
[scenes/xrender] Correctly render client-side decorated clients
Thu, Dec 12, 12:39 PM
zzag closed D25733: [scenes/xrender] Correctly render client-side decorated clients.
Thu, Dec 12, 12:39 PM · KWin
zzag committed R108:a7e18789cbd6: Fix crash in XRenderPictureData::~XRenderPictureData (authored by zzag).
Fix crash in XRenderPictureData::~XRenderPictureData
Thu, Dec 12, 12:06 PM
zzag closed D25768: Fix crash in XRenderPictureData::~XRenderPictureData.
Thu, Dec 12, 12:06 PM · KWin

Yesterday

zzag added a comment to D25904: [libkwineffects] Set original backend framebuffer for render targets.

backendFramebuffer is a good one.

Wed, Dec 11, 9:51 PM · KWin
zzag added a comment to D25907: [platforms/drm] Introduce Gl post-process output rotations.

A client may provide buffers with already rotated contents. Will such clients be a big problem with this patch series?

Wed, Dec 11, 9:49 PM · KWin
zzag added inline comments to D25906: [platforms/drm] Add hardware transformation API.
Wed, Dec 11, 9:47 PM · KWin
zzag accepted D25900: Inform Screens about size change.
Wed, Dec 11, 9:40 PM · KWin
zzag accepted D25901: Add modeSize getter.
Wed, Dec 11, 9:39 PM · KWin
zzag accepted D25909: [platforms/drm] Fix cursor output rotation.
Wed, Dec 11, 9:38 PM · KWin
zzag added a comment to D25904: [libkwineffects] Set original backend framebuffer for render targets.

Hmm, okay, fair enough. Can you rename setKWinFramebuffer to setDefaultFramebufferObject? It's not clear what "kwin framebuffer" is.

Wed, Dec 11, 9:37 PM · KWin
zzag accepted D25903: Cache output transformation first.
Wed, Dec 11, 8:15 PM · KWin
zzag added a comment to D25904: [libkwineffects] Set original backend framebuffer for render targets.

If we need to render something into a texture, a GLRenderTarget must be pushed on a stack, e.g.

Wed, Dec 11, 8:09 PM · KWin
zzag added inline comments to D25867: [platforms/drm] Do plane and object chore.
Wed, Dec 11, 5:26 PM · KWin

Tue, Dec 10

zzag added inline comments to D25663: Initial support for tablets on Wayland.
Tue, Dec 10, 10:03 PM · KWin
zzag added inline comments to D25663: Initial support for tablets on Wayland.
Tue, Dec 10, 5:00 PM · KWin
zzag added inline comments to D25663: Initial support for tablets on Wayland.
Tue, Dec 10, 4:53 PM · KWin
zzag accepted D25835: [kcms/launchfeedback] Port to KConfig notifiers.
Tue, Dec 10, 9:49 AM · Plasma
zzag accepted D25834: [effects/startupfeedback] Port to KConfigWatcher.
Tue, Dec 10, 9:42 AM · KWin
zzag accepted D25830: [platforms/drm] Do EglGbmBackend chore.
Tue, Dec 10, 8:57 AM · KWin

Fri, Dec 6

zzag updated the diff for D25786: [nightcolor] Introduce inhibition API.

Actually we don't need showStatusOsd() anymore.

Fri, Dec 6, 3:31 PM · KWin
zzag requested review of D25786: [nightcolor] Introduce inhibition API.
Fri, Dec 6, 3:27 PM · KWin
zzag committed R108:1747e497e4a2: [effects/fallapart] Override scale, fade, and glide effect (authored by zzag).
[effects/fallapart] Override scale, fade, and glide effect
Fri, Dec 6, 9:05 AM
zzag closed D19723: [effects/fallapart] Override scale, fade, and glide effect.
Fri, Dec 6, 9:05 AM · KWin

Thu, Dec 5

zzag added inline comments to D25764: Provide a fake approach to tablet event propagation.
Thu, Dec 5, 5:24 PM · KWin
zzag requested review of D25768: Fix crash in XRenderPictureData::~XRenderPictureData.
Thu, Dec 5, 5:10 PM · KWin
zzag added inline comments to D25764: Provide a fake approach to tablet event propagation.
Thu, Dec 5, 4:24 PM · KWin
zzag added a comment to D25763: Turn switch statement into a hash.
Thu, Dec 5, 3:59 PM · KWin
zzag updated the summary of D25733: [scenes/xrender] Correctly render client-side decorated clients.
Thu, Dec 5, 2:51 PM · KWin
zzag updated the diff for D25733: [scenes/xrender] Correctly render client-side decorated clients.

Map only the buffer shape, the decoration rect and the shadow region are in window coordinates

Thu, Dec 5, 2:50 PM · KWin
zzag committed R114:e60c22ff27c6: Unset X-Plasma-MainScript for wallpaper plugins (authored by zzag).
Unset X-Plasma-MainScript for wallpaper plugins
Thu, Dec 5, 2:24 PM
zzag closed D25760: Unset X-Plasma-MainScript for wallpaper plugins.
Thu, Dec 5, 2:24 PM · Plasma
zzag requested review of D25760: Unset X-Plasma-MainScript for wallpaper plugins.
Thu, Dec 5, 12:07 PM · Plasma

Wed, Dec 4

zzag added a comment to D25735: Remove deprecated method.

Heh, it seems you see this revision as one monolithic "remove usages of some deprecated functions and methods" and I see it as "use QWeakPointer::toStrongRef() instead of deprecated QWeakPointer::data(), use qmlRegisterAnonymousType() instead of deprecated qmlRegisterType(), fix initialization of QFlags<T>."

Wed, Dec 4, 3:18 PM · KWin
zzag committed R108:d39485553630: Rename Toplevel::geom to Toplevel::m_frameGeometry (authored by zzag).
Rename Toplevel::geom to Toplevel::m_frameGeometry
Wed, Dec 4, 1:47 PM
zzag closed D25738: Rename Toplevel::geom to Toplevel::m_frameGeometry.
Wed, Dec 4, 1:47 PM · KWin
zzag requested review of D25738: Rename Toplevel::geom to Toplevel::m_frameGeometry.
Wed, Dec 4, 1:36 PM · KWin
zzag added a comment to D25735: Remove deprecated method.

This patch contains a few unrelated changes. Could you please put them in another patches? Also, this patch doesn't remove any methods. ;-)

Wed, Dec 4, 1:17 PM · KWin
zzag updated the diff for D25733: [scenes/xrender] Correctly render client-side decorated clients.

Update comment.

Wed, Dec 4, 12:09 PM · KWin
zzag requested review of D25733: [scenes/xrender] Correctly render client-side decorated clients.
Wed, Dec 4, 12:08 PM · KWin
zzag committed R108:d6469fb55dfc: [x11] Resize the shape helper window to correct size (authored by zzag).
[x11] Resize the shape helper window to correct size
Wed, Dec 4, 10:18 AM
zzag closed D25730: [x11] Resize the shape helper window to correct size.
Wed, Dec 4, 10:18 AM · KWin
zzag retitled D25730: [x11] Resize the shape helper window to correct size from Resize the shape helper window to correct size to [x11] Resize the shape helper window to correct size.
Wed, Dec 4, 8:44 AM · KWin
zzag requested review of D25730: [x11] Resize the shape helper window to correct size.
Wed, Dec 4, 8:41 AM · KWin
zzag committed R108:f14adfe545fe: [x11] Make geometry updates in X11Client more comprehensible (authored by zzag).
[x11] Make geometry updates in X11Client more comprehensible
Wed, Dec 4, 8:10 AM
zzag closed D25710: [x11] Make geometry updates in X11Client more comprehensible.
Wed, Dec 4, 8:10 AM · KWin

Tue, Dec 3

zzag updated the task description for T12312: Split topic cpp files.
Tue, Dec 3, 5:47 PM · KWin
zzag committed R108:297876e55eef: Split group.cpp topic file (authored by zzag).
Split group.cpp topic file
Tue, Dec 3, 5:47 PM
zzag closed D25713: Split group.cpp topic file.
Tue, Dec 3, 5:47 PM · KWin
zzag committed R108:30c14d6e4303: Merge manage.cpp with x11client.cpp (authored by zzag).
Merge manage.cpp with x11client.cpp
Tue, Dec 3, 5:47 PM
zzag closed D25712: Merge manage.cpp with x11client.cpp.
Tue, Dec 3, 5:47 PM · KWin
zzag updated the task description for T12313: Refactor AbstractEglTexture.
Tue, Dec 3, 11:20 AM · KWin
zzag updated the task description for T12313: Refactor AbstractEglTexture.
Tue, Dec 3, 11:00 AM · KWin
zzag created T12313: Refactor AbstractEglTexture.
Tue, Dec 3, 10:45 AM · KWin
zzag updated the task description for T12312: Split topic cpp files.
Tue, Dec 3, 10:16 AM · KWin
zzag added a revision to T12312: Split topic cpp files: D25713: Split group.cpp topic file.
Tue, Dec 3, 10:16 AM · KWin
zzag added a task to D25713: Split group.cpp topic file: T12312: Split topic cpp files.
Tue, Dec 3, 10:16 AM · KWin
zzag requested review of D25713: Split group.cpp topic file.
Tue, Dec 3, 10:15 AM · KWin
zzag updated the task description for T12312: Split topic cpp files.
Tue, Dec 3, 10:08 AM · KWin
zzag added a revision to T12312: Split topic cpp files: D25712: Merge manage.cpp with x11client.cpp.
Tue, Dec 3, 10:07 AM · KWin
zzag added a task to D25712: Merge manage.cpp with x11client.cpp: T12312: Split topic cpp files.
Tue, Dec 3, 10:07 AM · KWin
zzag requested review of D25712: Merge manage.cpp with x11client.cpp.
Tue, Dec 3, 10:07 AM · KWin
zzag created T12312: Split topic cpp files.
Tue, Dec 3, 9:58 AM · KWin
zzag accepted D25708: Don't use nullptr to flags.

IT seems that it was a error during modernize code by using nullptr

Tue, Dec 3, 8:22 AM · Frameworks
zzag requested review of D25710: [x11] Make geometry updates in X11Client more comprehensible.
Tue, Dec 3, 7:50 AM · KWin

Mon, Dec 2

zzag added a reverting change for R108:9151bb7b9e71: [scenes/opengl] Provide correct viewport rect to clamp(): R108:6e000314b348: Revert the fix for the texture bleeding issue.
Mon, Dec 2, 6:00 PM
zzag added a reverting change for R108:ac4dce1c20a1: [scene] Fix decoration texture bleeding: R108:6e000314b348: Revert the fix for the texture bleeding issue.
Mon, Dec 2, 6:00 PM
zzag committed R108:6e000314b348: Revert the fix for the texture bleeding issue (authored by zzag).
Revert the fix for the texture bleeding issue
Mon, Dec 2, 6:00 PM
zzag added a reverting change for R108:754b72d15582: [x11] Name client pixmap instead of frame pixmap: R108:6e000314b348: Revert the fix for the texture bleeding issue.
Mon, Dec 2, 6:00 PM
zzag committed R108:9151bb7b9e71: [scenes/opengl] Provide correct viewport rect to clamp() (authored by zzag).
[scenes/opengl] Provide correct viewport rect to clamp()
Mon, Dec 2, 2:27 PM
zzag added a comment to D25611: [scene] Fix decoration texture bleeding.

The QSG code looks quite simple, but they go via another QImage buffer.

QPainter p(&tmp);
p.setCompositionMode(QPainter::CompositionMode_Source);
 
int w = r.width(); //Dave <- image.width+padding*2
int h = r.height();
int iw = image.width();
int ih = image.height();
p.drawImage(1, 1, image);
p.drawImage(1, 0, image, 0, 0, iw, 1);
p.drawImage(1, h - 1, image, 0, ih - 1, iw, 1);
p.drawImage(0, 1, image, 0, 0, 1, ih);
p.drawImage(w - 1, 1, image, iw - 1, 0, 1, ih);
p.drawImage(0, 0, image, 0, 0, 1, 1);
p.drawImage(0, h - 1, image, 0, ih - 1, 1, 1);
p.drawImage(w - 1, 0, image, iw - 1, 0, 1, 1);
p.drawImage(w - 1, h - 1, image, iw - 1, ih - 1, 1, 1);

Assuming Qt copes with rendering into the image it reads from we could have done the same.
We have the extra complexity of partial updates, but if we have the clipRect set correctly that should just quietly no-op

Mon, Dec 2, 2:24 PM · KWin
zzag closed D25616: [scenes/opengl] Discard cached Lanczos textures for all toplevels.
Mon, Dec 2, 1:14 PM · KWin
zzag committed R108:0c7196769d6f: [scenes/opengl] Discard cached Lanczos textures for all toplevels (authored by zzag).
[scenes/opengl] Discard cached Lanczos textures for all toplevels
Mon, Dec 2, 1:14 PM
zzag committed R108:ac4dce1c20a1: [scene] Fix decoration texture bleeding (authored by zzag).
[scene] Fix decoration texture bleeding
Mon, Dec 2, 1:11 PM
zzag closed D25611: [scene] Fix decoration texture bleeding.
Mon, Dec 2, 1:11 PM · KWin
zzag committed R108:754b72d15582: [x11] Name client pixmap instead of frame pixmap (authored by zzag).
[x11] Name client pixmap instead of frame pixmap
Mon, Dec 2, 1:11 PM
zzag closed D25610: [x11] Name client pixmap instead of frame pixmap.
Mon, Dec 2, 1:11 PM · KWin
zzag updated the diff for D25610: [x11] Name client pixmap instead of frame pixmap.

Adjust shape

Mon, Dec 2, 9:35 AM · KWin
zzag accepted D25666: Port away from overloaded KCModule signal.

Nvm, 5.64.

Mon, Dec 2, 7:36 AM · KWin
zzag added a comment to D25666: Port away from overloaded KCModule signal.

When was KCModule::markAsChanged introduced?

Mon, Dec 2, 7:35 AM · KWin
zzag accepted D25667: warnings--.
Mon, Dec 2, 7:32 AM · KWin

Sun, Dec 1

zzag accepted D25649: [platforms/drm] Refactor updateTransform.
Sun, Dec 1, 12:02 PM · KWin
zzag committed R108:f21f61db3813: Update KAboutData (authored by zzag).
Update KAboutData
Sun, Dec 1, 10:47 AM
zzag closed D25646: Update KAboutData.
Sun, Dec 1, 10:47 AM · KWin
zzag requested review of D25646: Update KAboutData.
Sun, Dec 1, 9:56 AM · KWin

Sat, Nov 30

zzag updated the diff for D25611: [scene] Fix decoration texture bleeding.

Rename a variable

Sat, Nov 30, 11:06 PM · KWin
zzag added inline comments to D25611: [scene] Fix decoration texture bleeding.
Sat, Nov 30, 10:35 PM · KWin
zzag updated the diff for D25611: [scene] Fix decoration texture bleeding.

Add the rotate() function back

Sat, Nov 30, 10:22 PM · KWin
zzag added inline comments to D25611: [scene] Fix decoration texture bleeding.
Sat, Nov 30, 10:20 PM · KWin
zzag added inline comments to D25611: [scene] Fix decoration texture bleeding.
Sat, Nov 30, 7:56 PM · KWin
zzag added inline comments to D25624: Don't use qmlRegisterType with QT-5.14.
Sat, Nov 30, 12:31 PM · Plasma
zzag updated the diff for D25610: [x11] Name client pixmap instead of frame pixmap.

Sneaky comment update

Sat, Nov 30, 12:28 PM · KWin
zzag committed R108:651d5862fe2c: [scenes/opengl] Drop unused enum type (authored by zzag).
[scenes/opengl] Drop unused enum type
Sat, Nov 30, 12:20 PM
zzag closed D25619: [scenes/opengl] Drop unused enum type.
Sat, Nov 30, 12:20 PM · KWin

Fri, Nov 29

zzag requested review of D25619: [scenes/opengl] Drop unused enum type.
Fri, Nov 29, 7:30 PM · KWin
zzag requested review of D25616: [scenes/opengl] Discard cached Lanczos textures for all toplevels.
Fri, Nov 29, 7:13 PM · KWin