[server] Make double-buffered properties in xdg-shell double-buffered
d0b3eab864a2
Actions

Authored by zzag on Sep 5 2019, 10:57 AM.

Description

[server] Make double-buffered properties in xdg-shell double-buffered

Summary:
So far all double-buffered properties in our implementation of xdg-shell
weren't actually double-buffered. When a property setter is invoked, we
pray to the God hoping that the client committed associated surface.

This change introduces private SurfaceRole class. The new class provides
a way for SurfaceInterface to commit pending state of associated shell
surface.

The chosen architecture allows us to do more in the future. For example,
we could use SurfaceRole to prevent associating several roles to a single
wl_surface object, e.g. xdg-toplevel to a pointer surface, etc.

Test Plan: This change breaks support for client-side decorated clients in KWin.

Reviewers: KWin

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D23745

Details

Committed

zzag	Nov 26 2019, 8:49 PM

Differential Revision

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

Parents

R127:c4a49fbf2d5d: Add missing include for Qt 5.14 build

Branches

Unknown

Tags

Unknown

zzag committed R127:d0b3eab864a2: [server] Make double-buffered properties in xdg-shell double-buffered (authored by zzag).Nov 26 2019, 8:49 PM

Changes (16)

				Path	Packages
	M			autotests/client/test_xdg_shell_stable.cpp
	M			autotests/client/test_xdg_shell_v6.cpp
	M			src/server/CMakeLists.txt
	M			src/server/generic_shell_surface_p.h
	M			src/server/shell_interface.cpp
	M			src/server/surface_interface.cpp
	M			src/server/surface_interface.h
	M			src/server/surface_interface_p.h
	P			src/server/surfacerole.cpp Copied from src/tools/testserver/main.cpp
	P			src/server/surfacerole_p.h Copied from src/tools/testserver/main.cpp
	M			src/server/xdgshell_interface.cpp
	M			src/server/xdgshell_interface.h
	M			src/server/xdgshell_interface_p.h
	M			src/server/xdgshell_stable_interface.cpp
	M			src/server/xdgshell_v5_interface.cpp
	M			src/server/xdgshell_v6_interface.cpp

[server] Make double-buffered properties in xdg-shell double-bufferedd0b3eab864a2Actions

Description

Details

Changes (16)

R127:d0b3eab864a2

autotests/client/test_xdg_shell_stable.cpp

autotests/client/test_xdg_shell_v6.cpp

src/server/CMakeLists.txt

src/server/generic_shell_surface_p.h

src/server/shell_interface.cpp

src/server/surface_interface.cpp

src/server/surface_interface.h

src/server/surface_interface_p.h

src/server/surfacerole.cpp

src/server/surfacerole_p.h

src/server/xdgshell_interface.cpp

src/server/xdgshell_interface.h

src/server/xdgshell_interface_p.h

src/server/xdgshell_stable_interface.cpp

src/server/xdgshell_v5_interface.cpp

src/server/xdgshell_v6_interface.cpp

[server] Make double-buffered properties in xdg-shell double-buffered
d0b3eab864a2
Actions