[kcm/decoration] Port to KPluginLoader
AcceptedPublic

Authored by nicolasfella on Nov 25 2019, 10:15 PM.

Details

Summary

KPluginTrader's future is uncertain. KPluginLoader is enough here

Test Plan

Open deco KCM. Themes are listed

Diff Detail

Repository
R108 KWin
Branch
plug
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 19162
Build 19180: arc lint + arc unit
nicolasfella created this revision.Nov 25 2019, 10:15 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 25 2019, 10:15 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
nicolasfella requested review of this revision.Nov 25 2019, 10:15 PM
zzag added a subscriber: zzag.Nov 26 2019, 6:45 AM

We also use KPluginTrader in PreviewBridge (declarative-plugin/previewbridge.cpp).

dfaure accepted this revision.Mar 21 2020, 6:16 PM
dfaure added a subscriber: dfaure.

Yep, we don't need servicetypes (the 2nd argument to query). The subdir org.kde.kdecoration2 (first argument) is enough.

This revision is now accepted and ready to land.Mar 21 2020, 6:16 PM
zzag added a comment.Mar 23 2020, 8:35 AM

Please don't forget to port PreviewBridge.