Differential D23745

[server] Make double-buffered properties in xdg-shell double-buffered
ClosedPublic
Actions

Authored by zzag on Sep 5 2019, 7:00 PM.

Details

Reviewers

None

Group Reviewers

KWin

Maniphest Tasks

T11480: Make xdg-shell properties double-buffered

Commits

R127:d0b3eab864a2: [server] Make double-buffered properties in xdg-shell double-buffered

Summary

So far all double-buffered properties in our implementation of xdg-shell
weren't actually double-buffered. When a property setter is invoked, we
pray to the God hoping that the client committed associated surface.

This change introduces private SurfaceRole class. The new class provides
a way for SurfaceInterface to commit pending state of associated shell
surface.

The chosen architecture allows us to do more in the future. For example,
we could use SurfaceRole to prevent associating several roles to a single
wl_surface object, e.g. xdg-toplevel to a pointer surface, etc.

Test Plan

This change breaks support for client-side decorated clients in KWin.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Sep 5 2019, 7:00 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 5 2019, 7:00 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

zzag requested review of this revision.Sep 5 2019, 7:00 PM

Harbormaster completed remote builds in B16144: Diff 65472.Sep 5 2019, 7:00 PM

zzag added a task: T11480: Make xdg-shell properties double-buffered.Sep 5 2019, 7:01 PM

pray to the God hoping that the client committed associated surface.

Practically its nowhere near as bad as this sounds. We might send a configure event early, but it'll only ever have an application after a new commit.
The most that will be broken is unbatched configure calls - still worth doing though.

Api makes sense.

Only question is whether it'd more useful to have an api which helps track that we only have one role, or have an api where /all/ the objects attached to a surface (blur, plasma shell, etc.) can easily double buffer.

src/server/xdgshell_stable_interface.cpp
232	size of 0 has a special meaning. When a client initially sets the value to 0,0 we don't want to treat it as a change. Unless you add this logic into the setMaximumSize callback ShellClient will have to handle the 0,0 anyway.

In D23745#527309, @davidedmundson wrote:

Only question is whether it'd more useful to have an api which helps track that we only have one role, or have an api where /all/ the objects attached to a surface (blur, plasma shell, etc.) can easily double buffer.

Not sure about the latter, but we definitely need to track attached surface role.

Handle value of zero in set_max_size callback.

Harbormaster completed remote builds in B16231: Diff 65603.Sep 7 2019, 9:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2019, 12:40 PM

Closed by commit R127:d0b3eab864a2: [server] Make double-buffered properties in xdg-shell double-buffered (authored by zzag). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/client/test_xdg_shell_stable.cpp (16 lines)
M		autotests/client/test_xdg_shell_v6.cpp (8 lines)
M		src/server/CMakeLists.txt (1 line)
M		src/server/generic_shell_surface_p.h (6 lines)
M		src/server/shell_interface.cpp (6 lines)
M		src/server/surface_interface.h (1 line)
M		src/server/surface_interface.cpp (4 lines)
M		src/server/surface_interface_p.h (3 lines)
A	M	src/server/surfacerole.cpp (45 lines)
A	M	src/server/surfacerole_p.h (50 lines)
M		src/server/xdgshell_interface.h (12 lines)
M		src/server/xdgshell_interface.cpp (16 lines)
M		src/server/xdgshell_interface_p.h (6 lines)
M		src/server/xdgshell_stable_interface.cpp (152 lines)
M		src/server/xdgshell_v5_interface.cpp (72 lines)
M		src/server/xdgshell_v6_interface.cpp (161 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65472	f776305		Sep 5 2019, 7:00 PM	★	★
Diff 2	65603	f776305	Handle value of zero in set_max_size callback.	Sep 7 2019, 9:10 PM	★	★
Diff 3	70425	c4a49fb	R127:d0b3eab864a2d30c70982dbfb5519a4915f8be61	Nov 26 2019, 8:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2efdc3720b76	81f2b4515b9c	f77630523705	Vlad Zagorodniy	[server] Make double-buffered properties in xdg-shell double-buffered (Show More…)	Sep 5 2019, 10:57 AM

[server] Make double-buffered properties in xdg-shell double-bufferedClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 70425

autotests/client/test_xdg_shell_stable.cpp

autotests/client/test_xdg_shell_v6.cpp

src/server/CMakeLists.txt

src/server/generic_shell_surface_p.h

src/server/shell_interface.cpp

src/server/surface_interface.h

src/server/surface_interface.cpp

src/server/surface_interface_p.h

src/server/surfacerole.cpp

src/server/surfacerole_p.h

src/server/xdgshell_interface.h

src/server/xdgshell_interface.cpp

src/server/xdgshell_interface_p.h

src/server/xdgshell_stable_interface.cpp

src/server/xdgshell_v5_interface.cpp

src/server/xdgshell_v6_interface.cpp

[server] Make double-buffered properties in xdg-shell double-buffered
ClosedPublic
Actions

Revision Contents
Changeset List