Since v0.13.0 (17 Nov 2018) quassel uses new names for the systemtray
status icons. This patch updates the icon name ids.
Details
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- updatequasselicons
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10459 Build 10477: arc lint + arc unit
To test this quickly, please download the files (View Options>Show Raw File (Right)>Download File) and place them in the respective folders /usr/share/plasma/desktoptheme/{air,breeze}/icons/, then "rm .cache/plasma* -r", and restart "plasmashell --replace" e.g. via krunner.
I don't see how this could work. IconItem uses the first section as filename, for active-quassel-tray the word active and looks for an active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO spec, it should have ebeen quassel-tray-inactive or something, ordered from generic to most specific.
So much for blindly done patches relying on testing by actual users :)
Indeed, IconItem uses this logic:
m_svgIcon->setImagePath(QLatin1String("icons/") + sourceString.section(QLatin1Char('-'), 0, 0));
so this change will not work.
But I wonder if this isn't a rather once heuristically-driven assumption of Plasma, over anything specified at freedesktop.org?
I could not find anything related in both
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Icons/
as well as
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#file_formats
Where should/could Quassel developers be pointed to? (Besides, they also have some "-inverted" variant based on a config option, which somehow complicates things even more, besides the complexity of Plasma theming vs. normal icon theming ;) ).