Differential D25366

Fix the order of arguments passed to changeMaximize method
ClosedPublic
Actions

Authored by zzag on Nov 18 2019, 12:34 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:b97d9ad681e9: Fix the order of arguments passed to changeMaximize method
Summary

BUG: 413424
BUG: 412888
BUG: 413554
FIXED-IN: 5.17.4

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Nov 18 2019, 12:34 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 18 2019, 12:34 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 18 2019, 12:34 PM
zzag edited the summary of this revision. (Show Details)Nov 18 2019, 12:41 PM
davidedmundson accepted this revision.Nov 18 2019, 12:50 PM
davidedmundson added a subscriber: davidedmundson.

Urgh, I'm sure this is the second case I've seen of this at least.

Lets maybe add a changeMaximise(Qt::Orientations) overload and phase this out.

This revision is now accepted and ready to land.Nov 18 2019, 12:50 PM
zzag added a comment.EditedNov 18 2019, 1:08 PM
In D25366#564093, @davidedmundson wrote:

Urgh, I'm sure this is the second case I've seen of this at least.

Yeah, the first case was about the wrong order of parameters in Client::changeMaximize.

EDIT: It was Client not ShellClient.

Lets maybe add a changeMaximise(Qt::Orientations) overload and phase this out.

Do you want me to do it in this revision or another one?

zzag edited the summary of this revision. (Show Details)Nov 18 2019, 1:46 PM
davidedmundson added a comment.Nov 18 2019, 1:52 PM

Later is fine, there's no rush.

Closed by commit R108:b97d9ad681e9: Fix the order of arguments passed to changeMaximize method (authored by zzag). · Explain WhyNov 18 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgeometry.cpp (2 lines)

Diff 69926

View Options

geometry.cpp

Loading...