Diffusion KWin 9d4a32596cd3

Drop some custom list typedefs

Authored by zzag on Oct 16 2019, 9:11 AM.

Description

Drop some custom list typedefs

Summary:
Qt has its own thing where a type might also have corresponding list
alias, e.g. QObject and QObjectList, QWidget and QWidgetList. I don't
know why Qt does that, maybe for some historical reasons, but what
matters is that we copy this pattern here in KWin. While this pattern
might be useful with some long list types, for example

QList<QWeakPointer<TabBoxClient>> TabBoxClientList

in general, it causes more harm than good. For example, we've got two
new client types, do we need corresponding list typedefs for them? If
no, why do we have ClientList and so on?

Another problem with these typedefs is that you need to include utils.h
header in order to use them. A better way to handle such things is to
just forward declare a client class (if that's possible) and use it
directly with QList or QVector. This way translation units don't get
"bloated" with utils.h stuff for no apparent reason.

So, in order to make code more consistent and easier to follow, this
change drops some of our custom typedefs. Namely ConstClientList,
ClientList, DeletedList, UnmanagedList, ToplevelList, and GroupList.

Test Plan: Compiles.

Reviewers: KWin

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D24950

Details

Committed
zzagNov 27 2019, 1:54 PM
Differential Revision
D24950: Drop some custom list typedefs
Parents
R108:84d75cb56745: [x11] Add support for _GTK_FRAME_EXTENTS
Branches
Unknown
Tags
Unknown