fredrik (Fredrik Höglund)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2016, 1:06 PM (150 w, 4 d)
Availability
Available

Recent Activity

Wed, May 8

fredrik added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

That'd be a nice easy fix at least.

Here's a patch: https://phabricator.kde.org/P385

I think it might tear because we have the threaded render loop so it's got no reason to be in sync with kwin/anything - but it looks to me to work fine.

Wed, May 8, 10:01 PM · KWin
fredrik added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

Do we actually want the QtQuick rendering to sync to vblank in this case?
If not, the solution could be to set the swap interval for those drawables to zero.

Wed, May 8, 6:38 PM · KWin

Jan 31 2019

fredrik added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Jan 31 2019, 1:41 PM · KWin
fredrik accepted D18377: [effects/blur] Update blur to be more natural.

Looks good to me.

Jan 31 2019, 1:21 PM · KWin

Jan 27 2019

fredrik added a comment to D18377: [effects/blur] Update blur to be more natural.
In D18377#400445, @zzag wrote:

May it cause issues on GLES?

Jan 27 2019, 12:09 PM · KWin

Jan 26 2019

fredrik added a comment to D18377: [effects/blur] Update blur to be more natural.

I tried experimenting what fredrik suggested without luck so far.
@fredrik @zzag is this the correct approach? This gives the exact same result as not using sRGB textures.

Jan 26 2019, 10:52 AM · KWin

Jan 23 2019

fredrik added a comment to D18377: [effects/blur] Update blur to be more natural.
In D18377#398821, @zzag wrote:

Hmm, it looks like during each render pass we'll be wasting resources on "sRGB - linear RGB" conversions. Intermediate results should be in linear colorspace.

Jan 23 2019, 11:25 PM · KWin

Nov 26 2018

fredrik added a comment to D13575: [scenes/opengl] Pad decoration parts.
In D13575#366344, @zzag wrote:

So, if I understand you correctly, we could have either WindowQuadShadow/WindowQuadContents/WindowQuadDecoration/WindowQuadSubSurface or WindowQuadComposite(which is the union of the previously mentioned quads), depending on what an effect would like to do, right?

Nov 26 2018, 2:47 PM · KWin
fredrik added a comment to D13575: [scenes/opengl] Pad decoration parts.
In D13575#366246, @zzag wrote:

Another way to fix this problem is to render an untransformed window into an off-screen texture, then map it on the screen. The problem with this method is that we probably would need to get rid of different window quad types (e.g. WindowQuadShadow, WindowQuadDecoration, etc), which might break some effects, like the Screenshot. This would probably also fix T4441. We could maybe introduce different flags to control what parts of windows(e.g. shadows, etc) are rendered.

Difficult.

Nov 26 2018, 1:13 PM · KWin

Jun 19 2018

fredrik accepted D13479: [effects] Ignore previous state of WindowForceBlurRole.

It would be easy to change WindowForceBlurRole from a bool to an int, and have effects increment/decrement the value though.

Jun 19 2018, 11:47 AM · KWin

Jun 17 2018

fredrik added a comment to D13382: [RFC] Half pixel correction.
In D13382#279309, @zzag wrote:

My preferred long term solution to this problem would be to render the window untransformed to a texture, and transform that texture instead of the individual parts. This is something kwin will have to do anyway to implement wayland sub-surfaces in a conformant manner.

Yeah, it sounds better and would work for both X11 and Wayland. So, we don't need D13575, right?

Jun 17 2018, 5:05 PM · KWin
fredrik added a comment to D13382: [RFC] Half pixel correction.

My preferred long term solution to this problem would be to render the window untransformed to a texture, and transform that texture instead of the individual parts. This is something kwin will have to do anyway to implement wayland sub-surfaces in a conformant manner.

Jun 17 2018, 4:53 PM · KWin

Jun 7 2018

fredrik added a comment to D13382: [RFC] Half pixel correction.

Array textures wouldn't help in this case, because all layers must have the same size.

Jun 7 2018, 10:47 PM · KWin

Apr 22 2018

fredrik added a reviewer for D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer: davidedmundson.

Looks good to me, but I'd also check with @davidedmundson.

Apr 22 2018, 5:09 PM · KWin

Apr 21 2018

fredrik added a comment to T8484: Making settting up a development environment quick and easy.

@ervin I think you are confusing me with someone else here.

Apr 21 2018, 5:11 PM

Apr 11 2018

fredrik added a comment to D10747: Implement zwp_linux_dmabuf_v1.

Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a dummy only on non-Linunx systems? This way we could use the system one on Linux.

Apr 11 2018, 1:01 PM · Plasma on Wayland, Frameworks

Mar 27 2018

fredrik committed R242:612494e2b2e9: windowthumbnail: Use mipmap texture filtering (authored by fredrik).
windowthumbnail: Use mipmap texture filtering
Mar 27 2018, 2:57 PM
fredrik committed R242:42d3fde1eef6: windowthumbnail: Use gamma correct scaling (authored by fredrik).
windowthumbnail: Use gamma correct scaling
Mar 27 2018, 2:57 PM

Mar 19 2018

fredrik updated the diff for D10750: wayland: Add support for zwp_linux_dmabuf.

Fix issues pointed out by romangg.

Mar 19 2018, 11:47 PM · KWin
fredrik added a comment to D10750: wayland: Add support for zwp_linux_dmabuf.

An issue that this patch does not fully address is switching compositing backends at runtime.

Do we support that at all? The backend is set at startup. Don't think you can change this later on.

Mar 19 2018, 11:25 PM · KWin

Mar 18 2018

fredrik updated the diff for D10251: [RFC] Use mipmap filtering in window thumbnails.

Rebase on master.

Mar 18 2018, 12:42 PM · Frameworks, Plasma

Mar 17 2018

fredrik added a comment to D10251: [RFC] Use mipmap filtering in window thumbnails.

What's the state of this? Bug 391915 just cropped up

Mar 17 2018, 3:21 PM · Frameworks, Plasma

Mar 14 2018

fredrik accepted D11301: don't override m_canUseMipmaps.
Mar 14 2018, 12:44 AM · KWin

Mar 13 2018

fredrik added inline comments to D11262: KDE logout screen background color fix.
Mar 13 2018, 1:13 PM · Plasma

Mar 12 2018

fredrik updated the diff for D10750: wayland: Add support for zwp_linux_dmabuf.

Import the context.

Mar 12 2018, 2:07 PM · KWin

Mar 7 2018

fredrik updated the diff for D10747: Implement zwp_linux_dmabuf_v1.

Import the context.

Mar 7 2018, 11:06 PM · Plasma on Wayland, Frameworks

Mar 1 2018

fredrik added a comment to D10750: wayland: Add support for zwp_linux_dmabuf.

An issue that this patch does not fully address is switching compositing backends at runtime.

Mar 1 2018, 4:06 PM · KWin

Feb 23 2018

fredrik edited projects for D10750: wayland: Add support for zwp_linux_dmabuf, added: Plasma; removed KWin.

Concerning the tests: the ones requiring OpenGL work best if module vgem is loaded. That normally makes them pass. The tests regarding keyboard layout need env variable XDG_DEFAULT_LAYOUT being unset or on us.

Feb 23 2018, 3:36 PM · KWin

Feb 22 2018

fredrik requested review of D10750: wayland: Add support for zwp_linux_dmabuf.
Feb 22 2018, 5:40 PM · KWin
Restricted Application edited projects for D10747: Implement zwp_linux_dmabuf_v1, added: Plasma; removed Plasma on Wayland.
Feb 22 2018, 3:07 PM · Plasma on Wayland, Frameworks
fredrik requested review of D10747: Implement zwp_linux_dmabuf_v1.
Feb 22 2018, 2:27 PM · Plasma on Wayland, Frameworks

Feb 20 2018

fredrik committed R108:8f6509b9cb3f: Improve robustness in some QML paths (authored by fredrik).
Improve robustness in some QML paths
Feb 20 2018, 3:38 PM

Feb 19 2018

fredrik committed R108:82dcbd654f29: wayland: Add support for zwp_linux_dmabuf (authored by fredrik).
wayland: Add support for zwp_linux_dmabuf
Feb 19 2018, 3:35 PM

Feb 16 2018

fredrik committed R108:c49100861692: vulkan: Convert the window quads in QuadSplitter (authored by fredrik).
vulkan: Convert the window quads in QuadSplitter
Feb 16 2018, 5:03 PM
fredrik committed R108:dc8e9baddf73: vulkan: Add a VulkanDecorationThread (authored by fredrik).
vulkan: Add a VulkanDecorationThread
Feb 16 2018, 5:03 PM
fredrik committed R108:d474eb730ece: vulkan/window: Use the new QuadSplitter (authored by fredrik).
vulkan/window: Use the new QuadSplitter
Feb 16 2018, 5:03 PM
fredrik committed R108:c21ad7c310cb: vulkan: Introduce a new QuadSplitter class (authored by fredrik).
vulkan: Introduce a new QuadSplitter class
Feb 16 2018, 5:03 PM
fredrik committed R108:8a7db7830fe0: effects/cubeslide: Use the new CullMode property (authored by fredrik).
effects/cubeslide: Use the new CullMode property
Feb 16 2018, 5:03 PM
fredrik committed R108:dd2ba88836b0: effects/cubeslide: Support Vulkan compositing (authored by fredrik).
effects/cubeslide: Support Vulkan compositing
Feb 16 2018, 5:03 PM
fredrik committed R108:7d038309b936: vulkan: Use ScreenPaintData::cullMode() (authored by fredrik).
vulkan: Use ScreenPaintData::cullMode()
Feb 16 2018, 5:03 PM
fredrik committed R108:aa92f360ae7f: opengl: Use ScreenPaintData::cullMode() (authored by fredrik).
opengl: Use ScreenPaintData::cullMode()
Feb 16 2018, 5:03 PM
fredrik committed R108:952ecc496967: vulkan/utils: Add CullFront and CullBack pipeline traits (authored by fredrik).
vulkan/utils: Add CullFront and CullBack pipeline traits
Feb 16 2018, 5:03 PM
fredrik committed R108:5f9f8de42f3b: Add a CullMode property in ScreenPaintData (authored by fredrik).
Add a CullMode property in ScreenPaintData
Feb 16 2018, 5:03 PM
fredrik committed R108:7edee47f91d4: effects/wobblywindows: Support VulkanCompositing (authored by fredrik).
effects/wobblywindows: Support VulkanCompositing
Feb 16 2018, 5:03 PM
fredrik committed R108:cc64270683d8: effects/sheet: Support Vulkan compositing (authored by fredrik).
effects/sheet: Support Vulkan compositing
Feb 16 2018, 5:03 PM
fredrik committed R108:e1378fdd7439: effects/magiclamp: Support Vulkan compositing (authored by fredrik).
effects/magiclamp: Support Vulkan compositing
Feb 16 2018, 5:03 PM
fredrik committed R108:dd9c6bd5ae25: effects/flipswitch: Support Vulkan compositing (authored by fredrik).
effects/flipswitch: Support Vulkan compositing
Feb 16 2018, 5:03 PM
fredrik committed R108:15d321357970: effects/glide: Support Vulkan compositing (authored by fredrik).
effects/glide: Support Vulkan compositing
Feb 16 2018, 5:03 PM
fredrik committed R108:3284a9e18e6a: vulkan: Check fences before and after each paint pass (authored by fredrik).
vulkan: Check fences before and after each paint pass
Feb 16 2018, 5:03 PM
fredrik committed R108:1d253a3ca3f5: vulkan: Add a ShadowTextureManager (authored by fredrik).
vulkan: Add a ShadowTextureManager
Feb 16 2018, 5:03 PM
fredrik committed R108:0fc9a1c4cd11: vulkan: Implement VulkanShadow (authored by fredrik).
vulkan: Implement VulkanShadow
Feb 16 2018, 5:03 PM
fredrik committed R108:01344b7c2343: vulkan/window: Render shadows (authored by fredrik).
vulkan/window: Render shadows
Feb 16 2018, 5:03 PM
fredrik committed R108:a78d886c4154: vulkan: Implement the decoration renderer (authored by fredrik).
vulkan: Implement the decoration renderer
Feb 16 2018, 5:03 PM
fredrik committed R108:681a1327557b: vulkan: Add a DecorationImagesDescriptorSet (authored by fredrik).
vulkan: Add a DecorationImagesDescriptorSet
Feb 16 2018, 5:03 PM
fredrik committed R108:c831a639a7ec: vulkan/window: Render the decorations (authored by fredrik).
vulkan/window: Render the decorations
Feb 16 2018, 5:03 PM
fredrik committed R108:a62487aadad6: vulkan: Add offscreen render passes (authored by fredrik).
vulkan: Add offscreen render passes
Feb 16 2018, 5:03 PM
fredrik committed R108:f4d9142ce771: vulkan: Add a stagingImageAllocator in the scene (authored by fredrik).
vulkan: Add a stagingImageAllocator in the scene
Feb 16 2018, 5:03 PM
fredrik committed R108:94aa59664e57: vulkan/window: Render the window contents (authored by fredrik).
vulkan/window: Render the window contents
Feb 16 2018, 5:03 PM
fredrik committed R108:048dd4f5e088: vulkan: Advertise supported wl_shm formats (authored by fredrik).
vulkan: Advertise supported wl_shm formats
Feb 16 2018, 5:03 PM
fredrik committed R108:20a0d83dedd2: vulkan/scene: Add bool m_haveMaintenance1 (authored by fredrik).
vulkan/scene: Add bool m_haveMaintenance1
Feb 16 2018, 5:03 PM
fredrik committed R108:7fc5da61da21: vulkan/windowpixmap: Add support for wl_shm surfaces (authored by fredrik).
vulkan/windowpixmap: Add support for wl_shm surfaces
Feb 16 2018, 5:03 PM
fredrik committed R108:74f8b59e5ad6: vulkan/scene: Use the V-sync setting (authored by fredrik).
vulkan/scene: Use the V-sync setting
Feb 16 2018, 5:03 PM
fredrik committed R108:100a3dc53771: vulkan/scene: Use the Vulkan device setting (authored by fredrik).
vulkan/scene: Use the Vulkan device setting
Feb 16 2018, 5:03 PM
fredrik committed R108:a759f310d7c2: options: Add a Vulkan V-sync setting (authored by fredrik).
options: Add a Vulkan V-sync setting
Feb 16 2018, 5:03 PM
fredrik committed R108:acb0599ed318: options: Add a Vulkan device setting (authored by fredrik).
options: Add a Vulkan device setting
Feb 16 2018, 5:03 PM
fredrik committed R108:1f3be08c8fcc: kcmkwin/compositing: Add a Vulkan V-sync setting (authored by fredrik).
kcmkwin/compositing: Add a Vulkan V-sync setting
Feb 16 2018, 5:03 PM
fredrik committed R108:7416c9a7b94b: kcmkwin/compositing: Add a Vulkan device setting (authored by fredrik).
kcmkwin/compositing: Add a Vulkan device setting
Feb 16 2018, 5:03 PM
fredrik committed R108:7e943e9638d3: kcmkwin/compositing: Add a Vulkan compositing option (authored by fredrik).
kcmkwin/compositing: Add a Vulkan compositing option
Feb 16 2018, 5:03 PM
fredrik committed R108:f4f4cfbbb639: kcmkwin/compositing: Move the scale method combobox (authored by fredrik).
kcmkwin/compositing: Move the scale method combobox
Feb 16 2018, 5:03 PM
fredrik committed R108:b442f877ff8c: kcmkwin/compositing: Fix spacing issues (authored by fredrik).
kcmkwin/compositing: Fix spacing issues
Feb 16 2018, 5:03 PM
fredrik committed R108:2cae8ad3f571: Add the beginnings of a Vulkan compositing plugin (authored by fredrik).
Add the beginnings of a Vulkan compositing plugin
Feb 16 2018, 5:03 PM
fredrik committed R108:5356e6f06a41: cmake: define KWIN_VERSION_MAJOR/MINOR/PATCH (authored by fredrik).
cmake: define KWIN_VERSION_MAJOR/MINOR/PATCH
Feb 16 2018, 5:03 PM
fredrik committed R108:fbd85e5061cc: scene: Add a compositingFailed signal (authored by fredrik).
scene: Add a compositingFailed signal
Feb 16 2018, 5:03 PM
fredrik committed R108:c2d08ab2f902: Add a compositingfailed notification event (authored by fredrik).
Add a compositingfailed notification event
Feb 16 2018, 5:03 PM
fredrik committed R108:4697de4c766e: Add Vulkan versions of the core shaders (authored by fredrik).
Add Vulkan versions of the core shaders
Feb 16 2018, 5:03 PM
fredrik committed R108:a39b24ec410a: Add libkwinvulkanutils (authored by fredrik).
Add libkwinvulkanutils
Feb 16 2018, 5:03 PM
fredrik committed R108:778994b47808: Add GLCrossFadeVertex2D (authored by fredrik).
Add GLCrossFadeVertex2D
Feb 16 2018, 5:03 PM
fredrik committed R108:36b7921fa279: cmake: Find Vulkan (authored by fredrik).
cmake: Find Vulkan
Feb 16 2018, 5:03 PM
fredrik committed R108:6b80a34ca874: Move align() to utils.h (authored by fredrik).
Move align() to utils.h
Feb 16 2018, 5:03 PM

Feb 14 2018

fredrik committed R108:627b11ce495a: Added missing image format (authored by anemeth).
Added missing image format
Feb 14 2018, 10:24 PM
fredrik closed D10497: Added missing image format.
Feb 14 2018, 10:24 PM · KWin
fredrik accepted D10497: Added missing image format.

Nice find!

Feb 14 2018, 10:22 PM · KWin

Feb 13 2018

fredrik committed R108:cc0325af4152: Added noise blur effect (authored by anemeth).
Added noise blur effect
Feb 13 2018, 11:27 PM
fredrik closed D10281: Added noise blur effect.
Feb 13 2018, 11:27 PM · KWin
fredrik accepted D10281: Added noise blur effect.
Feb 13 2018, 11:11 PM · KWin
fredrik committed R127:6d0d8f448987: Implement zwp_linux_dmabuf_v1 (authored by fredrik).
Implement zwp_linux_dmabuf_v1
Feb 13 2018, 7:26 PM

Feb 12 2018

fredrik added a comment to D10281: Added noise blur effect.

Aside from the darkening issue, I think this looks good now.

Feb 12 2018, 10:51 PM · KWin
fredrik added inline comments to D10281: Added noise blur effect.
Feb 12 2018, 7:02 PM · KWin

Feb 9 2018

fredrik added a comment to D10281: Added noise blur effect.

@fredrik: I think with perlin noise blurred background will be foggy/cloudy + simplex noise is covered by a patent.

Feb 9 2018, 1:56 PM · KWin

Feb 4 2018

fredrik added inline comments to D10281: Added noise blur effect.
Feb 4 2018, 1:58 PM · KWin

Feb 3 2018

fredrik committed R108:f8ff40271e4d: Removed the "fastblur" path (authored by anemeth).
Removed the "fastblur" path
Feb 3 2018, 6:05 PM
fredrik closed D10181: Removed the "fastblur" path.
Feb 3 2018, 6:05 PM · KWin
fredrik accepted D10181: Removed the "fastblur" path.
Feb 3 2018, 6:03 PM · KWin

Feb 2 2018

fredrik added a comment to D10251: [RFC] Use mipmap filtering in window thumbnails.

Before and after:

Feb 2 2018, 3:40 PM · Frameworks, Plasma

Feb 1 2018

fredrik committed R108:0a22983beffe: Updated blur default value from 5/15 to 10/15 (authored by anemeth).
Updated blur default value from 5/15 to 10/15
Feb 1 2018, 6:59 PM
fredrik closed D10180: Updated blur default value from 5/15 to 10/15.
Feb 1 2018, 6:59 PM · KWin
fredrik added a comment to D10170: Added optional transparency/blur to menu frames.

I think the "blur" option should go. Blur should be controlled centrally by the desktop effect. In other words: BlurBehind should always be set to true, and then left to kwin to handle. Having an extra option here seems like micro-management. Why would you need blur behind plasma widgets (as handled by the desktop effect) and not behind menus ? (or vice versa). Also, right now, selecting "blur" in the style settings, but unselecting the desktop effect results in no blur behind menu, and hence inconsistency with what the style option says.

Feb 1 2018, 12:26 PM · Breeze, Plasma

Jan 31 2018

Restricted Application edited projects for D10181: Removed the "fastblur" path, added: KWin; removed Plasma.

Code wise this LGTM.

Jan 31 2018, 11:20 PM · KWin
fredrik accepted D10180: Updated blur default value from 5/15 to 10/15.
Jan 31 2018, 11:01 PM · KWin
Restricted Application edited projects for D10181: Removed the "fastblur" path, added: Plasma; removed KWin.
Jan 31 2018, 6:57 PM · KWin