Define property X-Plasma-MainScript for Plasma/Wallpaper
AbandonedPublic

Authored by zzag on Thu, Nov 7, 12:13 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This commit fixes Unknown property type for key "X-Plasma-MainScript"
warning that pops up when building a wallpaper plugin.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
property-def
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18550
Build 18568: arc lint + arc unit
zzag created this revision.Thu, Nov 7, 12:13 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Nov 7, 12:13 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Thu, Nov 7, 12:13 AM
zzag retitled this revision from Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper to Define property X-Plasma-MainScript for Plasma/Wallpaper.Thu, Nov 7, 12:57 AM
davidedmundson added a subscriber: davidedmundson.EditedThu, Nov 7, 12:04 PM

From wallpaper interface:

m_qmlObject->setSource(m_pkg.fileUrl("mainscript"));
packages.cpp
void QmlWallpaperPackage::initPackage(Plasma::Package *package)
{
    package->addFileDefinition("mainscript", QStringLiteral("ui/main.qml"), i18n("Main Script File"));
    package->setRequired("mainscript", true);

it seems hardcoded in p-f, at which point the warning itself is correct and it's the wallpapers themselves that are wrong.

zzag abandoned this revision.Thu, Nov 7, 12:19 PM

Okay, I see.