Fix coding style issues in Scene::paintSimpleScreen
Needs ReviewPublic

Authored by zzag on Mon, Oct 7, 10:45 AM.

Details

Reviewers
None
Group Reviewers
KWin
Maniphest Tasks
T10867: XDG WindowGeometry

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17407
Build 17425: arc lint + arc unit
zzag created this revision.Mon, Oct 7, 10:45 AM
Restricted Application added a project: KWin. · View Herald TranscriptMon, Oct 7, 10:45 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mon, Oct 7, 10:45 AM
fredrik added a subscriber: fredrik.Mon, Oct 7, 4:51 PM
fredrik added inline comments.
scene.cpp
258

The comment here is lost.

277

Why the change to qobject_cast<>?

zzag updated this revision to Diff 67445.Mon, Oct 7, 5:26 PM

Fredrik's comments.

zzag added inline comments.Mon, Oct 7, 5:29 PM
scene.cpp
258

Oops, fixed.

277

qobject_cast is considered to be a better choice because it's faster (I didn't benchmark it though) and doesn't need RTTI. However, in this case it is a leftover. Fixed.

zzag marked 4 inline comments as done.Mon, Oct 7, 5:30 PM