[kcmkwin/tabbox] Use an enum for role names
ClosedPublic
Actions

Authored by zzag on Nov 22 2019, 10:41 AM.

Details

Reviewers

apol

Group Reviewers

KWin

Commits

Summary

This way we have fewer magical constants.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Nov 22 2019, 10:41 AM

zzag retitled this revision from [kcmkwin/tabbox] Use enums for roles to [kcmkwin/tabbox] Use an enum for role names.Nov 22 2019, 10:53 AM

This revision is now accepted and ready to land.Nov 22 2019, 5:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcmkwin/kwintabbox/layoutpreview.h (8 lines)
M			kcmkwin/kwintabbox/layoutpreview.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70146	1f8e4bb		Nov 22 2019, 10:41 AM	★	★
Diff 2	70182	1f8e4bb	R108:07099676ef72622e1d9f49324889dfeee2984bf4	Nov 22 2019, 7:38 PM	★	★