[effects] Forward wheel events
ClosedPublic

Authored by davidedmundson on Wed, Nov 13, 5:38 PM.

Details

Summary

Effects::checkInputWindowEvent(QWheelEvent *e) existed but it was not
hooked up to anything and would never be called.

This patch adds the relevant handling in the wayland filter, X filter so
the existing method gets called.

EffectQuickView is updated to handle wheel events.

Test Plan

Used a ListView via an EffectQuickView in an effect.
I can now scroll with the mouse.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Wed, Nov 13, 5:38 PM
Restricted Application added a project: KWin. · View Herald TranscriptWed, Nov 13, 5:38 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Wed, Nov 13, 5:38 PM
zzag added a subscriber: zzag.Wed, Nov 13, 6:24 PM
zzag added inline comments.
plugins/platforms/x11/standalone/effects_mouse_interception_x11_filter.cpp
42

You forgot horizontal scroll events, i.e. button 6 and button 7.

zzag added inline comments.Wed, Nov 13, 6:26 PM
plugins/platforms/x11/standalone/effects_mouse_interception_x11_filter.cpp
42

button 6 - left
button 7 - right

Add horizontal mouse wheel.

We're using magic numbers as 6 and 7 aren't defined in
xcb headers. (though BUTTON_5 wasn't much better than 5
as a semantic description anyway)

Left and right values look backwards but it's copied from
Qt... I can't test that (which is why I hoped originally
to subtly just avoid dealing this situation!)

zzag accepted this revision.Thu, Nov 14, 12:30 PM
This revision is now accepted and ready to land.Thu, Nov 14, 12:30 PM
This revision was automatically updated to reflect the committed changes.