Thank you for looking into this! The way conversion between Qt::ScreenOrientations and DeviceInterface::Transform is done seems to be wrong.

Mixing both Qt::PortraitOrientation and Qt::InvertedPortraitOrientation doesn't make sense. Wouldn't it be better to introduce a screen transformation enum and use it instead of Qt::ScreenOrientations?

In D25507#567590, @zzag wrote:

Thank you for looking into this! The way conversion between Qt::ScreenOrientations and DeviceInterface::Transform is done seems to be wrong.

Mixing both Qt::PortraitOrientation and Qt::InvertedPortraitOrientation doesn't make sense. Wouldn't it be better to introduce a screen transformation enum and use it instead of Qt::ScreenOrientations?

Yes, it would be better I believe. But I wanted to first try to fix the current approach before thinking about replacing it.

I don't see any particular reason that holds us from doing that, but meh fair enogh. Could you please create a Phabricator task so we don't forget to refactor this code?

In D25507#567683, @zzag wrote:

I don't see any particular reason that holds us from doing that, but meh fair enogh. Could you please create a Phabricator task so we don't forget to refactor this code?

See D25558

In D25507#568086, @romangg wrote:

In D25507#567683, @zzag wrote:

I don't see any particular reason that holds us from doing that, but meh fair enogh. Could you please create a Phabricator task so we don't forget to refactor this code?

See D25558

Thanks.