Use normal list delegates
Feed Advanced Search
May 1 2020
May 1 2020
cblack updated the diff for D28888: Fix navigation regressions.
ngraham added a comment to D27960: Make it possible to scroll through the padding.
I'm afraid that for me there is no change from last time. :( If a two-finger scroll event is initiated to the left or right of the application screenshots component, the scroll behavior is really jerky and weird. Do you need a video or something?
Apr 30 2020
Apr 30 2020
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Fix preventing layer from pushing itself
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Add _private QtObject back and comment why
masonm added inline comments to D29294: Add support for layers to PagePoolAction..
nicolasfella added a comment to D29308: Fix excessive right padding in scrollable page.
Mobile before:
ngraham added a comment to D29308: Fix excessive right padding in scrollable page.
Probably a legacy of the now-removed overlay scrollbars on the desktop. Does this still work when overlay scrollbars are being used on mobile?
nicolasfella updated the test plan for D29308: Fix excessive right padding in scrollable page.
nicolasfella requested review of D29308: Fix excessive right padding in scrollable page.
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Code review changes 1
cblack added inline comments to D29294: Add support for layers to PagePoolAction..
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Handle checked status with exclusive groups
mart added inline comments to D29304: Introduce Theme::smallFont.
cblack updated the diff for D29304: Introduce Theme::smallFont.
Drop Rust-ism
cblack requested review of D29304: Introduce Theme::smallFont.
ngraham updated the diff for D29074: Make BasicListItem more useful by giving it a subtitle property.
Address review comments
cblack added inline comments to D29074: Make BasicListItem more useful by giving it a subtitle property.
ngraham updated the test plan for D29074: Make BasicListItem more useful by giving it a subtitle property.
mart added inline comments to D29074: Make BasicListItem more useful by giving it a subtitle property.
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Honor checkable state of Action
Apr 29 2020
Apr 29 2020
masonm requested review of D29294: Add support for layers to PagePoolAction..
cblack requested review of D29288: Improve PageRouter API.
nicolasfella requested review of D29276: Bundle icons for inline messages.
apol added a comment to D27960: Make it possible to scroll through the padding.
@ngraham can you test again? it works well for me (admittedly better than when I first submitted it).
apol updated the diff for D27960: Make it possible to scroll through the padding.
Rebase and improve test
Apr 28 2020
Apr 28 2020
cblack updated the diff for D29262: Less segfaulty PageRouterAttached.
Parent climbing
cblack requested review of D29262: Less segfaulty PageRouterAttached.
Merged.
cblack updated the diff for D29135: PageRouter: find parents of items better.
Coding style
Apr 26 2020
Apr 26 2020
Oops, thanks for catching this!
jbbgameich requested review of D29209: PlaceholderMessage: Remove Plasma units usage.
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
@apol done.
patrickelectric updated the diff for D29202: Remove unused QtConcurrent from colorutils.
patrickelectric updated the diff for D29202: Remove unused QtConcurrent from colorutils.
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
apol added a comment to D29202: Remove unused QtConcurrent from colorutils.
Then remove it from CMakeLists.txt as well?
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
It fails to build when QtConcurrent can't be found.
patrickelectric requested review of D29203: kirigami.pri: Add missing includes.
patrickelectric requested review of D29202: Remove unused QtConcurrent from colorutils.
cblack updated the diff for D28888: Fix navigation regressions.
Rebase
ndavis added a comment to D28888: Fix navigation regressions.
This needs to be rebased
Apr 24 2020
Apr 24 2020
ngraham added a comment to D28888: Fix navigation regressions.
That works, but wouldn't it be nicer if the border of the card just clipped the image?
cblack updated the diff for D28888: Fix navigation regressions.
Add left margin to image
ngraham added a comment to D28888: Fix navigation regressions.
Much better. But the left corners of the cards aren't rounded.
cblack updated the diff for D28888: Fix navigation regressions.
Address feedback
ngraham added a comment to D28888: Fix navigation regressions.
Much nicer! There appear to be issues with the left margin and the color of the search field's toolbar background though:
cblack updated the diff for D28888: Fix navigation regressions.
Swap collapsed header and image
cblack updated the diff for D28888: Fix navigation regressions.
Adjust listview
ngraham updated the test plan for D29074: Make BasicListItem more useful by giving it a subtitle property.
ngraham updated the diff for D29152: Allow PlaceholderMessage to be text-less.
Simplify
broulik added inline comments to D29152: Allow PlaceholderMessage to be text-less.
ngraham added a dependent revision for D29152: Allow PlaceholderMessage to be text-less: D29141: [kcmkwin/kwinrules] Port placeholder message to Kirigami.PlaceholderMessage.
ngraham requested review of D29152: Allow PlaceholderMessage to be text-less.
Apr 23 2020
Apr 23 2020
cblack updated the diff for D29135: PageRouter: find parents of items better.
Remove stray qDebug
cblack requested review of D29135: PageRouter: find parents of items better.
mart added a comment to D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen.
in the end, just centered vertically the sheet in 812238afdcb7
ahiemstra requested review of D29129: Remove implicitHeight from cards in main page.
ahiemstra added a dependent revision for D29127: Account for top and bottom margin in default card height: D29129: Remove implicitHeight from cards in main page.
ahiemstra requested review of D29127: Account for top and bottom margin in default card height.
ahiemstra added inline comments to D29092: Various fixes to new Cards.
ahiemstra updated the diff for D29092: Various fixes to new Cards.
- Use a slightly higher smoothing value.
ahiemstra added a comment to D29092: Various fixes to new Cards.
This has a ShadowedRectangle underneath and a transparent Rectangle with a border on top:
Is there nothing that can be done about that? I have to deal with similar issues when working with SVGs, so I'll understand if you can't. We'll just have to slightly shrink the rectangle underneath instead.
Apr 22 2020
Apr 22 2020
ngraham added a comment to D29057: Introduce PlaceholderMessage component.
Oops. Fixed in 4c6252526c122081f7ac699d2655dc80306fde78.
nicolasfella added inline comments to D29057: Introduce PlaceholderMessage component.
cblack requested review of D29106: Introduce RouterWindow control.
ndavis added inline comments to D29092: Various fixes to new Cards.
ndavis added a comment to D29092: Various fixes to new Cards.
This has a ShadowedRectangle underneath and a transparent Rectangle with a border on top:
