Differential D29135

PageRouter: find parents of items better
ClosedPublic
Actions

Authored by cblack on Apr 23 2020, 4:25 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:9b21a37d44e2: PageRouter: find parents of items better
Summary

The PageRouterAttached is now able to locate a parent PageRouter by travelling up the visual parent hierarchy as well as the regular QObject parent hierarchy.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 23 2020, 4:25 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 23 2020, 4:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 23 2020, 4:25 PM
cblack updated this revision to Diff 81018.Apr 23 2020, 4:32 PM

Remove stray qDebug

mart accepted this revision.Apr 28 2020, 4:13 PM
mart added a subscriber: mart.
mart added inline comments.
src/pagerouter.cpp
342

as frameworks style guidelines, always even for oneliners
if () {
}

This revision is now accepted and ready to land.Apr 28 2020, 4:13 PM
cblack updated this revision to Diff 81443.Apr 28 2020, 4:33 PM

Coding style

cblack marked an inline comment as done.Apr 28 2020, 4:33 PM
Closed by commit R169:9b21a37d44e2: PageRouter: find parents of items better (authored by cblack). · Explain WhyApr 28 2020, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/pagerouter.cpp (36 lines)

Diff 81444

View Options

src/pagerouter.cpp

Loading...