Less segfaulty PageRouterAttached
ClosedPublic
Actions

Authored by cblack on Apr 28 2020, 5:39 PM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

R169:e0107f5854dc: Less segfaulty PageRouterAttached

Summary

PageRouterAttached will have its router set when the PageRouter creates an object for a route instead of relying on tree climbing
All PageRouterAttached methods now check for null

Test Plan

make test

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

cblack requested review of this revision.Apr 28 2020, 5:39 PM

This revision is now accepted and ready to land.Apr 28 2020, 6:25 PM

Parent climbing

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/pagerouter.h (12 lines)
M			src/pagerouter.cpp (109 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81449	77eab72		Apr 28 2020, 5:39 PM	★	★
Diff 2	81466	77eab72	Parent climbing	Apr 28 2020, 7:29 PM	★	★
Diff 3	81468	77eab72	R169:e0107f5854dc2a731c0f99ecdeffdbb6dd3ab53c	Apr 28 2020, 7:35 PM	★	★