Differential D29100

Icon: improve icon rendering on multi-screen multi-dpi setups
ClosedPublic
Actions

Authored by apol on Apr 22 2020, 3:51 PM.

Details

Reviewers
davidedmundson
Commits
R169:6b76ce30811c: Icon: improve icon rendering on multi-screen multi-dpi setups
Summary

Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into account which window it's rendering to.
Otherwise it was assuming we were rendering on the primary screen and it would end up being unpredictable.

Test Plan

All looks correct, if I move emojier from a scaled screen to a non-scaled one, icons re-render properly.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 22 2020, 3:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 22 2020, 3:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 22 2020, 3:51 PM
davidedmundson accepted this revision.Apr 22 2020, 8:51 PM
This revision is now accepted and ready to land.Apr 22 2020, 8:51 PM
Closed by commit R169:6b76ce30811c: Icon: improve icon rendering on multi-screen multi-dpi setups (authored by apol). · Explain WhyApr 23 2020, 12:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/icon.cpp (11 lines)

Diff 80944

View Options

src/icon.cpp

Loading...