Differential D29141

[kcmkwin/kwinrules] Port placeholder message to Kirigami.PlaceholderMessage
ClosedPublic
Actions

Authored by ngraham on Apr 23 2020, 8:17 PM.

Details

Reviewers
iasensio
zzag
Group Reviewers
KWin
Maniphest Tasks
T13021: Make placeholder messages consistent
Commits
R108:f9faa94ccc8f: [kcmkwin/kwinrules] Port placeholder message to Kirigami.PlaceholderMessage
Summary

Depends on D29152

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 23 2020, 8:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 23 2020, 8:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Apr 23 2020, 8:17 PM
zzag accepted this revision.Apr 23 2020, 8:27 PM
This revision is now accepted and ready to land.Apr 23 2020, 8:27 PM
iasensio added a comment.Apr 23 2020, 8:35 PM

While you're at it, I think the item hintArea in RulesEditor.qml, line 49 can also be ported, since it's also a placeholder item.
It does not contain text but only an Add Properties button.

ngraham updated this revision to Diff 81052.Apr 23 2020, 9:22 PM

Port the other button too

ngraham edited the summary of this revision. (Show Details)Apr 24 2020, 1:43 PM
ngraham added a dependency: D29152: Allow PlaceholderMessage to be text-less.
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 81096.Apr 24 2020, 1:46 PM

Rebase and adjust to Kirigami patch

iasensio accepted this revision.Apr 24 2020, 2:15 PM

Perfect now, thanks!

Revision Contents
Changeset List

Diff 81100

View Options

CMakeLists.txt

Loading...
View Options

kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml

Loading...
View Options

kcmkwin/kwinrules/package/contents/ui/RulesList.qml

Loading...