Feed Advanced Search

Sun, Sep 13

marcboocha added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

Well Qstyle is had to make thus stuff like kvantumn. So this will help quite a bit

Sun, Sep 13, 7:35 AM · Kirigami, Plasma, KF6

Jul 3 2020

tosta added a comment to T13216: Make Koko a possible successor of Gwenview.

I think the image gallery (or image/video) app must be like Piktures is for Android.

Jul 3 2020, 10:41 AM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency

Jul 1 2020

ngraham added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

One idea I've been throwing around recently is using the Plasma theme for apps too, by making the QStyle load Plasma theme SVGs. This would eliminate the potential problem of Plasma dialogs having a different appearance from apps, because all of them would be using the same theme in the first place. It would also allow a single theme to apply to the entire system, producing a major consistency win, and these newly-all-encompassing systemwide Plasma themes are share-able via GHNS, which is not currently possible using binary QStyle widgets themes. In so doing, the Breeze QStyle would be essentially transformed into a theme engine. Alternatively I suppose we would fork it into a new one, or write a new one.

Jul 1 2020, 2:14 AM · Kirigami, Plasma, KF6

Jun 13 2020

ngraham added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

I wouldn't be in favor of making config windows have the plasma style. In other respect they would match the desktop style (e.g. titlebar) so that would just be weird IMO.

Jun 13 2020, 2:10 AM · Kirigami, Plasma, KF6

Jun 11 2020

mart added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

feasible technical solutions at the moment are

  • QQmlAbstractUrlInterceptor based solution: kinda error prone but easy to do
  • configuration windows in a separate process: quite complicated and error prone, would take a year to do
  • having config windows with the plasma style
Jun 11 2020, 1:12 PM · Kirigami, Plasma, KF6
ngraham added a comment to T13256: Come up with a solution for displaying QQC2 elements in Plasma.

Related to but necessarily a duplicate of T11558: kill plasma components in favour of qqc2-desktop-style. If we do T11558, we won't have to do this, but we can do this without having to do T11558.

Jun 11 2020, 5:39 AM · Kirigami, Plasma, KF6

Jun 9 2020

ngraham updated the task description for T13256: Come up with a solution for displaying QQC2 elements in Plasma.
Jun 9 2020, 5:49 PM · Kirigami, Plasma, KF6
ngraham claimed T13256: Come up with a solution for displaying QQC2 elements in Plasma.
Jun 9 2020, 5:46 PM · Kirigami, Plasma, KF6
ngraham updated the task description for T13256: Come up with a solution for displaying QQC2 elements in Plasma.
Jun 9 2020, 3:37 PM · Kirigami, Plasma, KF6
ngraham renamed T13256: Come up with a solution for displaying QQC2 elements in Plasma from Come up with a solution for QQC2 elements in Plasma to Come up with a solution for displaying QQC2 elements in Plasma.
Jun 9 2020, 3:37 PM · Kirigami, Plasma, KF6
ngraham triaged T13256: Come up with a solution for displaying QQC2 elements in Plasma as Normal priority.
Jun 9 2020, 3:35 PM · Kirigami, Plasma, KF6
ngraham closed D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
Jun 9 2020, 2:47 PM · Kirigami

Jun 8 2020

davidre added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

Ping

Jun 8 2020, 7:30 AM · Kirigami

Jun 1 2020

cblack abandoned D28643: WIP, RFC: Add ColorInfo class.
Jun 1 2020, 7:29 AM · Kirigami

May 30 2020

twitt added a comment to T13216: Make Koko a possible successor of Gwenview.

@ognarb thanks! It did not work out of the box, but it helped me make it run (I'm on arch linux and had to change the kirigami version to 2.4 and remove the usage of ImageColors to make it run)

May 30 2020, 4:43 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency
ognarb added a comment to T13216: Make Koko a possible successor of Gwenview.

@twitt The error you are getting is because you didn't source the prefix.sh with source prefix.sh then it should just work™.

May 30 2020, 2:39 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency
twitt added a comment to T13216: Make Koko a possible successor of Gwenview.

Recently I got into the source code of Gwenview. I was missing a crop tool that allows arbitrary rotations. While a rough implementation in Gwenview was quite easy, I never solved all problems to also retain the old behavior, which is why I not yet committed it. However, after getting a deeper look into the codebase of Gwenview, I agree that several things could be refactored or rewritten, although I still like the application itself. If someone could review/help, I would spent some time on polish or adding some new features.
Personally, I am not a fan of mixing mobile and desktop applications as it is difficult to implement a good usability that works with touch, mouse and keyboard at the same time. A prominent example might be Adobe Lightroom which still fails to have a unified user interfaces that works for mobile and desktop devices.
However I the mookups look cool and also very much like the name Koko for an image application. Unfortunately I never worked with QML and I was not even able to start it (error message: module "org.kde.koko" is not installed :/ ). According to the git log there were nearly no new features added within the last two years, so I am not sure if replacing Gwenview would help to gain activity.

May 30 2020, 12:40 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency

May 29 2020

manueljlin updated the task description for T13216: Make Koko a possible successor of Gwenview.
May 29 2020, 7:27 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency
manueljlin updated the task description for T13216: Make Koko a possible successor of Gwenview.
May 29 2020, 7:16 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency
niccolove updated the task description for T13216: Make Koko a possible successor of Gwenview.
May 29 2020, 6:25 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency
niccolove added projects to T13216: Make Koko a possible successor of Gwenview: VDG, Plasma: Mobile, Kirigami.
May 29 2020, 6:12 PM · Kirigami, Plasma: Mobile, VDG, Goal: Consistency

May 19 2020

mart accepted D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

looks good

May 19 2020, 11:01 AM · Kirigami

May 18 2020

cblack added a comment to D29694: Introduce Avatar component.

This is being moved to GitLab.

May 18 2020, 4:59 PM · Kirigami
cblack closed D29694: Introduce Avatar component.
May 18 2020, 4:58 PM · Kirigami
cblack abandoned D28873: Add SwipeNavigator component.

Moving to a GitLab MR

May 18 2020, 4:50 PM · Kirigami
cblack added a comment to D28873: Add SwipeNavigator component.
In D28873#672598, @mart wrote:

what should happen in this case?

May 18 2020, 4:49 PM · Kirigami
nicolasfella added a comment to D22868: Revamp Kirigami.AboutPage.

can this be closed?

May 18 2020, 3:59 PM · Kirigami
broulik abandoned D25984: Load translations.

Looks like D27595 fixes the issue

May 18 2020, 3:18 PM · Kirigami
ngraham closed D29785: Always use Window colorset for AbstractApplicationHeader.
May 18 2020, 1:45 PM · Kirigami
mart accepted D29785: Always use Window colorset for AbstractApplicationHeader.
May 18 2020, 1:17 PM · Kirigami
ngraham added a comment to D29785: Always use Window colorset for AbstractApplicationHeader.

Not all of the headers use toolbars, but I thought the idea was for them all to use a consistent base appearance? @mart?

May 18 2020, 1:16 PM · Kirigami
apol added a comment to D29785: Always use Window colorset for AbstractApplicationHeader.

I wonder if this should be specified in ToolBarApplicationHeader instead.

May 18 2020, 1:00 PM · Kirigami
mart added a comment to D28873: Add SwipeNavigator component.

what should happen in this case?

May 18 2020, 9:46 AM · Kirigami
mart added a comment to D28873: Add SwipeNavigator component.

can you add an example about it in /examples ?

May 18 2020, 9:44 AM · Kirigami

May 15 2020

ngraham added a comment to D28873: Add SwipeNavigator component.

Looking fiiiiine.

May 15 2020, 5:51 PM · Kirigami
ngraham updated the summary of D29785: Always use Window colorset for AbstractApplicationHeader.
May 15 2020, 5:47 PM · Kirigami
ngraham requested review of D29785: Always use Window colorset for AbstractApplicationHeader.
May 15 2020, 5:40 PM · Kirigami
cblack updated the test plan for D28873: Add SwipeNavigator component.
May 15 2020, 5:23 PM · Kirigami
cblack updated the diff for D28873: Add SwipeNavigator component.

Improve the small toolbar

May 15 2020, 5:14 PM · Kirigami
Zren added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

The plasma-framework patch is D29463

May 15 2020, 5:02 PM · Kirigami
cblack updated the diff for D28873: Add SwipeNavigator component.

Rebase on master

May 15 2020, 4:36 PM · Kirigami
cblack updated the diff for D29694: Introduce Avatar component.

Unsplit template and control for documentation purposes

May 15 2020, 4:11 PM · Kirigami
cblack added inline comments to D29694: Introduce Avatar component.
May 15 2020, 3:51 PM · Kirigami
cblack updated the diff for D29694: Introduce Avatar component.

Split into a template; make borders customisable

May 15 2020, 3:51 PM · Kirigami
cblack added inline comments to D29694: Introduce Avatar component.
May 15 2020, 3:19 PM · Kirigami
broulik added a comment to D27595: Watch for language change events, and forward those to the QML engine.

Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its startup time in "retranslate" :/

May 15 2020, 2:09 PM · Kirigami
mart added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
In D29462#668542, @mart wrote:

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

May 15 2020, 12:59 PM · Kirigami
mart requested changes to D29694: Introduce Avatar component.
May 15 2020, 12:56 PM · Kirigami
mart added a comment to D29694: Introduce Avatar component.

I would like this class to be splitted in Templates/controls, so different styles could make it look slightly sifferent (or anyways easier for the app developer to make one that looks just slightly different)
the root component should be a Control, with image/icon/initials in contentItem and background collor/border in background
the one in templates would not have a background the one in controls would instantiate the one in templates and give it one.

May 15 2020, 12:56 PM · Kirigami
mart added a comment to D28873: Add SwipeNavigator component.

yes, that screenshot is really broken.
to me is important that the tabbar tries to take all the space available before doing any eliding.
Probably whether starting to elide a lot and make the tabs actually scrollable, will depend case by case depending fro mthe app

May 15 2020, 12:01 PM · Kirigami

May 14 2020

ngraham added a comment to D28873: Add SwipeNavigator component.

When there isn't room to show all labels, eliding the labels or collapsing the inactive tabs to square-ish icons-only things that are still clickable/touchable would seem to make more sense to me. The above screenshot kind of looks like a visual glitch IMO.

May 14 2020, 10:28 PM · Kirigami
cblack added a comment to D28873: Add SwipeNavigator component.

In that window, there's plenty of space for the component to expand horizontally. I would prefer to avoid scrolling tabs; their interaction is usually not great.

May 14 2020, 10:20 PM · Kirigami
ngraham added a comment to D28873: Add SwipeNavigator component.
In D28873#671042, @mart wrote:

If i make the window narrow enough, that's what happens

perhaps it tabbar should scroll instead?

May 14 2020, 2:44 PM · Kirigami
mart added a comment to D28873: Add SwipeNavigator component.

If i make the window narrow enough, that's what happens

May 14 2020, 2:42 PM · Kirigami
mart closed D29637: Introduce ImageColors.
May 14 2020, 8:37 AM · Kirigami

May 13 2020

ratijastk added a comment to D29694: Introduce Avatar component.

Cool thing. Makes me think of Nintendo Mii, and their open source counterpart, bloke (which is not really used anywhere, but whatever).

May 13 2020, 8:32 PM · Kirigami
cblack updated the diff for D29694: Introduce Avatar component.

Avoid trying to display initials of non-Latin characters

May 13 2020, 6:48 PM · Kirigami
ngraham added a comment to D29694: Introduce Avatar component.

+1 overall.

May 13 2020, 6:26 PM · Kirigami
ngraham added a comment to D29694: Introduce Avatar component.

Cool stuff. The commit message needs to be expanded to explain where and how this will be used, and also needs to list key implentation feats (initials, colors).

I believe we use avatars in launcher menus, the user menu, and lock, login, logout (3L) screens. The 3L have no action involved with the avatar so there's no need to buttonify it in any way for that use case. Visually they're fine as is. Launcher menus and the kcm are obviously different. But the main question is actually what do we intend to do with not using Kirigami on the desktop? That makes this component only usable in kcms?

May 13 2020, 6:16 PM · Kirigami
cblack requested review of D29694: Introduce Avatar component.
May 13 2020, 6:04 PM · Kirigami

May 12 2020

ngraham closed D29692: Recommend better width calculation for PlaceholderMessage.
May 12 2020, 7:29 PM · Kirigami
ngraham updated the test plan for D29692: Recommend better width calculation for PlaceholderMessage.
May 12 2020, 7:29 PM · Kirigami
cblack accepted D29692: Recommend better width calculation for PlaceholderMessage.
May 12 2020, 7:28 PM · Kirigami
ngraham updated the summary of D29692: Recommend better width calculation for PlaceholderMessage.
May 12 2020, 7:27 PM · Kirigami
ngraham requested review of D29692: Recommend better width calculation for PlaceholderMessage.
May 12 2020, 7:25 PM · Kirigami
cblack accepted D29637: Introduce ImageColors.
May 12 2020, 5:25 PM · Kirigami
mart updated the diff for D29637: Introduce ImageColors.
  • adress feedbacks
May 12 2020, 9:37 AM · Kirigami

May 11 2020

cblack closed D29288: Improve PageRouter API.
May 11 2020, 4:22 PM · Kirigami
cblack added inline comments to D29637: Introduce ImageColors.
May 11 2020, 3:56 PM · Kirigami
mart accepted D29288: Improve PageRouter API.
May 11 2020, 3:41 PM · Kirigami
mart added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

May 11 2020, 3:40 PM · Kirigami
cblack added inline comments to D29637: Introduce ImageColors.
May 11 2020, 3:16 PM · Kirigami
mart updated the test plan for D29637: Introduce ImageColors.
May 11 2020, 3:08 PM · Kirigami
mart requested review of D29637: Introduce ImageColors.
May 11 2020, 3:06 PM · Kirigami

May 8 2020

ngraham added a revision to T9460: Consider a more user-friendly SpinBox control: D29534: Implement scroll and drag adjustment of values for SpinBox control.
May 8 2020, 8:29 PM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG
ratijastk added a member for Kirigami: ratijastk.
May 8 2020, 2:48 PM

May 7 2020

cblack added inline comments to D29288: Improve PageRouter API.
May 7 2020, 2:46 PM · Kirigami
cblack added inline comments to D29288: Improve PageRouter API.
May 7 2020, 1:52 PM · Kirigami
mart added inline comments to D29288: Improve PageRouter API.
May 7 2020, 1:49 PM · Kirigami

May 5 2020

Zren updated the summary of D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
May 5 2020, 11:20 PM · Kirigami
ngraham added reviewers for D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi: Kirigami, mart.
May 5 2020, 11:10 PM · Kirigami
Zren requested review of D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.
May 5 2020, 11:05 PM · Kirigami
nicolasfella closed D29435: Fix typo in examples.
May 5 2020, 8:11 PM · Kirigami

May 4 2020

ngraham accepted D29435: Fix typo in examples.
May 4 2020, 10:30 PM · Kirigami
nicolasfella requested review of D29435: Fix typo in examples.
May 4 2020, 10:27 PM · Kirigami
ngraham closed D29432: Use small font for BasicListItem subtitle.
May 4 2020, 10:15 PM · Kirigami
cblack accepted D29432: Use small font for BasicListItem subtitle.
May 4 2020, 10:12 PM · Kirigami
ngraham added a reviewer for D29432: Use small font for BasicListItem subtitle: VDG.
May 4 2020, 10:02 PM · Kirigami
ngraham updated the test plan for D29432: Use small font for BasicListItem subtitle.
May 4 2020, 9:59 PM · Kirigami
ngraham requested review of D29432: Use small font for BasicListItem subtitle.
May 4 2020, 9:50 PM · Kirigami
masonm closed D29294: Add support for layers to PagePoolAction..
May 4 2020, 7:35 PM · Kirigami
mart accepted D29294: Add support for layers to PagePoolAction..
May 4 2020, 6:56 PM · Kirigami
cblack closed D28888: Fix navigation regressions.
May 4 2020, 1:58 PM · Kirigami, Plasma
cblack closed D29106: Introduce RouterWindow control.
May 4 2020, 1:58 PM · Kirigami
mart accepted D28888: Fix navigation regressions.
May 4 2020, 12:05 PM · Kirigami, Plasma
ahiemstra closed D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style.
May 4 2020, 10:54 AM · Kirigami
mart accepted D29106: Introduce RouterWindow control.
May 4 2020, 9:10 AM · Kirigami
mart accepted D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style.
May 4 2020, 9:08 AM · Kirigami

May 1 2020

ndavis added a comment to D28888: Fix navigation regressions.

Thanks, this fixes the navigation issue after a page has been selected. The main grid view is still annoying though.

May 1 2020, 11:09 PM · Kirigami, Plasma
ndavis accepted D28888: Fix navigation regressions.
May 1 2020, 11:08 PM · Kirigami, Plasma