Differential D29304

Introduce Theme::smallFont
ClosedPublic
Actions

Authored by cblack on Apr 30 2020, 4:27 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:9368dcc28f66: Introduce Theme::smallFont
Summary

Like defaultFont, but smaller.

Test Plan

font.qml350 BDownload

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 30 2020, 4:27 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 30 2020, 4:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 30 2020, 4:27 PM
cblack updated this revision to Diff 81603.Apr 30 2020, 4:35 PM

Drop Rust-ism

mart added a subscriber: mart.Apr 30 2020, 4:35 PM
mart added inline comments.
src/libkirigami/basictheme.cpp
74

you can just do a temp smallfont and then setFont with it without the lambda

mart accepted this revision.Apr 30 2020, 4:35 PM
This revision is now accepted and ready to land.Apr 30 2020, 4:35 PM
Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by cblack). · Explain WhyApr 30 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81604

View Options

src/controls/Theme.qml

Loading...
View Options

src/libkirigami/basictheme.cpp

Loading...
View Options

src/libkirigami/platformtheme.h

Loading...
View Options

src/libkirigami/platformtheme.cpp

Loading...