User Details
User Details
- User Since
- Oct 7 2019, 7:17 PM (236 w, 4 d)
- Availability
- Available
May 4 2020
May 4 2020
Add support for layers to PagePoolAction.
Apr 30 2020
Apr 30 2020
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Fix preventing layer from pushing itself
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Add _private QtObject back and comment why
masonm added inline comments to D29294: Add support for layers to PagePoolAction..
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Code review changes 1
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Handle checked status with exclusive groups
masonm updated the diff for D29294: Add support for layers to PagePoolAction..
Honor checkable state of Action
Apr 29 2020
Apr 29 2020
masonm requested review of D29294: Add support for layers to PagePoolAction..
Apr 9 2020
Apr 9 2020
masonm committed R169:acd93a6e6369: Add unit tests for PagePool/PagePoolAction (authored by masonm).
Add unit tests for PagePool/PagePoolAction
Apr 8 2020
Apr 8 2020
masonm requested review of D28690: Add unit tests for PagePool/PagePoolAction.
Apr 3 2020
Apr 3 2020
masonm committed R169:1d777eef0b0b: Hotfix for D28468 to fix broken variable refs (authored by masonm).
Hotfix for D28468 to fix broken variable refs
Apr 2 2020
Apr 2 2020
masonm added a comment to D28496: Hotfix for D28468 to fix broken variable refs.
I am going to commit some unit tests for this so I don't miss something else :)
Apr 1 2020
Apr 1 2020
masonm requested review of D28496: Hotfix for D28468 to fix broken variable refs.
masonm updated the diff for D28468: Add property initializer support to PagePool.
- Rename variable and add comment
Mar 31 2020
Mar 31 2020
masonm requested review of D28468: Add property initializer support to PagePool.
Mar 19 2020
Mar 19 2020
masonm requested review of D28148: Fix broken paths in kirigami.qrc.in.
Mar 18 2020
Mar 18 2020
masonm requested review of D26956: Remove export header from static install.
Just following up on this change review—it all looks good to me. Can we merge it in?
Feb 8 2020
Feb 8 2020
masonm requested review of D27250: Add PagePoolAction to QRC file.
Feb 7 2020
Feb 7 2020
masonm requested review of D27225: Add support for static platformtheme plugins.
Feb 5 2020
Feb 5 2020
masonm planned changes to D27161: Add support for static platformtheme plugins.
I think there's issues with this. I had assumed it is fine to load static plugins regardless of from where, but in my testing there are issues so I think this needs to be an "either or" scenario instead of allowing static/dynamic plugins to intermix.
masonm requested review of D27161: Add support for static platformtheme plugins.
Feb 3 2020
Feb 3 2020
masonm requested review of D27135: Add PagePoolAction to QRC file.
Jan 28 2020
Jan 28 2020
masonm added a comment to D26956: Remove export header from static install.
It appears all the sources which reference the export header have an appropriate guard on them:
masonm added a comment to D26956: Remove export header from static install.
Ah, I'll take a closer look.
masonm requested review of D26956: Remove export header from static install.
Oct 7 2019
Oct 7 2019
masonm requested review of D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.