masonm (Mason McParlane)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2019, 7:17 PM (32 w, 6 d)
Availability
Available

Recent Activity

Mon, May 4

masonm committed R169:9c3c2d1a2379: Add support for layers to PagePoolAction. (authored by masonm).
Add support for layers to PagePoolAction.
Mon, May 4, 7:35 PM
masonm closed D29294: Add support for layers to PagePoolAction..
Mon, May 4, 7:35 PM · Kirigami

Thu, Apr 30

masonm updated the diff for D29294: Add support for layers to PagePoolAction..

Fix preventing layer from pushing itself

Thu, Apr 30, 11:45 PM · Kirigami
masonm updated the diff for D29294: Add support for layers to PagePoolAction..

Add _private QtObject back and comment why

Thu, Apr 30, 6:31 PM · Kirigami
masonm added inline comments to D29294: Add support for layers to PagePoolAction..
Thu, Apr 30, 6:26 PM · Kirigami
masonm updated the diff for D29294: Add support for layers to PagePoolAction..

Code review changes 1

Thu, Apr 30, 5:16 PM · Kirigami
masonm updated the diff for D29294: Add support for layers to PagePoolAction..

Handle checked status with exclusive groups

Thu, Apr 30, 4:48 PM · Kirigami
masonm updated the diff for D29294: Add support for layers to PagePoolAction..

Honor checkable state of Action

Thu, Apr 30, 2:23 PM · Kirigami

Wed, Apr 29

masonm requested review of D29294: Add support for layers to PagePoolAction..
Wed, Apr 29, 10:58 PM · Kirigami

Apr 9 2020

masonm committed R169:acd93a6e6369: Add unit tests for PagePool/PagePoolAction (authored by masonm).
Add unit tests for PagePool/PagePoolAction
Apr 9 2020, 12:38 PM
masonm closed D28690: Add unit tests for PagePool/PagePoolAction.
Apr 9 2020, 12:38 PM · Kirigami

Apr 8 2020

masonm requested review of D28690: Add unit tests for PagePool/PagePoolAction.
Apr 8 2020, 10:05 PM · Kirigami

Apr 3 2020

masonm committed R169:1d777eef0b0b: Hotfix for D28468 to fix broken variable refs (authored by masonm).
Hotfix for D28468 to fix broken variable refs
Apr 3 2020, 5:06 PM
masonm closed D28496: Hotfix for D28468 to fix broken variable refs.
Apr 3 2020, 5:06 PM · Kirigami

Apr 2 2020

masonm added a comment to D28496: Hotfix for D28468 to fix broken variable refs.

I am going to commit some unit tests for this so I don't miss something else :)

Apr 2 2020, 2:14 PM · Kirigami

Apr 1 2020

masonm requested review of D28496: Hotfix for D28468 to fix broken variable refs.
Apr 1 2020, 11:55 PM · Kirigami
masonm updated the diff for D28468: Add property initializer support to PagePool.
  • Rename variable and add comment
Apr 1 2020, 3:11 PM · Kirigami

Mar 31 2020

masonm requested review of D28468: Add property initializer support to PagePool.
Mar 31 2020, 6:10 PM · Kirigami

Mar 19 2020

masonm requested review of D28148: Fix broken paths in kirigami.qrc.in.
Mar 19 2020, 8:25 PM · Kirigami

Mar 18 2020

masonm requested review of D26956: Remove export header from static install.

Just following up on this change review—it all looks good to me. Can we merge it in?

Mar 18 2020, 9:11 PM · Kirigami

Feb 8 2020

masonm abandoned D27250: Add PagePoolAction to QRC file.
Feb 8 2020, 4:38 PM · Kirigami
masonm requested review of D27250: Add PagePoolAction to QRC file.
Feb 8 2020, 3:07 PM · Kirigami

Feb 7 2020

masonm requested review of D27225: Add support for static platformtheme plugins.
Feb 7 2020, 7:55 PM · Kirigami
masonm abandoned D27161: Add support for static platformtheme plugins.
Feb 7 2020, 7:35 PM · Kirigami

Feb 5 2020

masonm planned changes to D27161: Add support for static platformtheme plugins.

I think there's issues with this. I had assumed it is fine to load static plugins regardless of from where, but in my testing there are issues so I think this needs to be an "either or" scenario instead of allowing static/dynamic plugins to intermix.

Feb 5 2020, 7:39 PM · Kirigami
masonm requested review of D27161: Add support for static platformtheme plugins.
Feb 5 2020, 2:05 AM · Kirigami

Feb 3 2020

masonm requested review of D27135: Add PagePoolAction to QRC file.
Feb 3 2020, 4:46 PM · VDG, Kirigami

Jan 28 2020

masonm added a comment to D26956: Remove export header from static install.

It appears all the sources which reference the export header have an appropriate guard on them:

Jan 28 2020, 4:35 PM · Kirigami
masonm added a comment to D26956: Remove export header from static install.

Ah, I'll take a closer look.

Jan 28 2020, 3:12 AM · Kirigami
masonm requested review of D26956: Remove export header from static install.
Jan 28 2020, 12:22 AM · Kirigami

Oct 7 2019

masonm added a reviewer for D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation: VDG.
Oct 7 2019, 11:31 PM · Frameworks
masonm requested review of D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.
Oct 7 2019, 8:14 PM · Frameworks