Remove implicitHeight from cards in main page
ClosedPublic
Actions

Authored by ahiemstra on Apr 23 2020, 10:19 AM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

Summary

Card now has a correct default height.

Depends on D29127

Test Plan

Main page cards display correctly, both in single and double column mode.

Repository

R1014 Kirigami Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ahiemstra requested review of this revision.Apr 23 2020, 10:19 AM

This revision is now accepted and ready to land.Apr 23 2020, 10:23 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/data/contents/ui/MainPage.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80978	bf1dfba		Apr 23 2020, 10:19 AM	★	★
Diff 2	80980	9a6be71	R1014:40f6034f35c1565612205631b1b71448c875c793	Apr 23 2020, 10:30 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
ada69b031638	66a053abfcf4	bf1dfba83fee	Arjen Hiemstra	Remove implicitHeight from cards in main page (Show More…)	Apr 23 2020, 10:18 AM

	Status	Author	Revision
	Closed	ahiemstra	D29129 Remove implicitHeight from cards in main page
	Closed	ahiemstra	D29127 Account for top and bottom margin in default card height