This patch fixes navigation regressions caused by larger cards in the gallery.
- Keyboard focus is properly handled
- Cards collapse to a smaller form when a second page is present
- A home button is present to allow returning to the large-form cards
ndavis | |
mart |
VDG | |
Kirigami |
This patch fixes navigation regressions caused by larger cards in the gallery.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back to using real list items instead?
That's what I initially attempted, but non-deterministic behaviour was caused by swapping out a list of cards for a list of listitems.
I can understand that there are technical challenges, but, not to put too fine a point on it, this doesn't look very good:
if there can't be a super smooth transition between a listview and this thing (perhaps with a stackview, but i'm not sold) then there should always be just the cardlayout with the same cards look, just as a single column
btw may be worth trying to have a stackview that switches between this view and the one before based on page with (wideMode property of pagerow)
Close. There's extra spacing on the right for some reason, and I think the sidebar's background used to be white.
Much nicer! There appear to be issues with the left margin and the color of the search field's toolbar background though:
Also the text in the cards seems a too large to me. Maybe go down to a level 2 or 3 heading?
That works, but wouldn't it be nicer if the border of the card just clipped the image?
Also I just noticed that Sidebar Drawer view is a mess.
Thanks, this fixes the navigation issue after a page has been selected. The main grid view is still annoying though.