Fix excessive right padding in scrollable page
ClosedPublic

Authored by nicolasfella on Apr 30 2020, 5:46 PM.

Details

Summary

In this example

import QtQuick 2.5
import QtQuick.Layouts 1.1
import org.kde.kirigami 2.4 as Kirigami

Kirigami.ScrollablePage {

    Rectangle {
        width: parent.width
        height: 1000
        color: "red"
    }
}

the gap between the rectangle and the scrollbar was larger than the distance between the left edge of the rectangle and the window. This was caused by the extra rightPadding of the RefreshableScrollView. It also seems unnecessary to me since the ScrollView itself takes care of dodging the scroll bar (ScrollView.qml:21).

Test Plan

Before:

After:

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 30 2020, 5:46 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 30 2020, 5:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 30 2020, 5:46 PM
nicolasfella edited the test plan for this revision. (Show Details)Apr 30 2020, 5:48 PM

Probably a legacy of the now-removed overlay scrollbars on the desktop. Does this still work when overlay scrollbars are being used on mobile?

Mobile before:

Mobile after:

ngraham accepted this revision.Apr 30 2020, 6:08 PM
This revision is now accepted and ready to land.Apr 30 2020, 6:08 PM
This revision was automatically updated to reflect the committed changes.