Make it possible to scroll through the padding
Needs ReviewPublic

Authored by apol on Mar 9 2020, 11:43 PM.


Group Reviewers

Forwards wheel events happening on the padding to the WheelHandler that manages
the Flickable.

BUG: 418624

Test Plan

See test included, also on Discover

Diff Detail

R169 Kirigami
No Linters Available
No Unit Test Coverage
Build Status
Buildable 26060
Build 26078: arc lint + arc unit
apol created this revision.Mar 9 2020, 11:43 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 9 2020, 11:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mar 9 2020, 11:43 PM

This doesn't work well for me with a touchpad. The side padding regions clearly accept scroll events now, but the actual scroll behavior is jerky and inconsistent. :( Feels like events are getting dropped or interfering with one another.

ngraham requested changes to this revision.Mar 17 2020, 12:23 AM
This revision now requires changes to proceed.Mar 17 2020, 12:23 AM
apol updated this revision to Diff 81481.Apr 29 2020, 12:04 AM

Rebase and improve test

apol added a comment.Apr 29 2020, 12:08 AM

@ngraham can you test again? it works well for me (admittedly better than when I first submitted it).

Maybe something else got fixed too in the meantime.

I'm afraid that for me there is no change from last time. :( If a two-finger scroll event is initiated to the left or right of the application screenshots component, the scroll behavior is really jerky and weird. Do you need a video or something?