This patch creates the PlaceholderMessage, a re-usable component that can be used
to create all kinds of placeholder messages with a standardized appearance. It can be a
loading screen, an "there's no content in this view" message, an error message, and more.
Details
Details
- Reviewers
mart - Group Reviewers
VDG Kirigami - Maniphest Tasks
- T13021: Make placeholder messages consistent
T11227: Loading Look and Feel - Commits
- R169:5a434519aeb9: Introduce PlaceholderMessage component
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/controls/PlaceholderMessage.qml | ||
|---|---|---|
| 21 | @code{.qml} | |
| 41 | Split into own codeblock | |
| 68 | Ditto | |
| 101 | This is a QVariant, not a string. | |
| 105 | @see Icon::source | |
| 108 | You probably want to add a property for the fallback icon as well | |
| 111 | Not sure this will link properly. | |
| 142 | Use source instead of an alias to it for better readability | |
| src/controls/PlaceholderMessage.qml | ||
|---|---|---|
| 11 | as convention (sadly not used everywhere in the sources but at least in the "newer" files) use a namespace | |
| 108 | for consistency with qqc2 icons it should be ActionIconGroup | |
| 131 | remove this property. | |
| src/controls/PlaceholderMessage.qml | ||
|---|---|---|
| 119 | You can probably just make an alias to the button's action property. It got added in Qt 5.10, then it should take on the icon, text, visibility, trigger, etc of that action automatically. (helperAction sounds as if it were an implementation detail somehow) | |
| 142 | Probably just want to bind valid | |
| 149 | Layout.fillWidth: true instead, so it'll wrap properly? | |
| src/controls/PlaceholderMessage.qml | ||
|---|---|---|
| 26 | This needs to be 2.12 | |