Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions.

For the panic mode icon, how about leaving the wall itself black, and only the lock is orange?

Wonderful.

In D15718#330844, @smithjd wrote:

In D15718#330836, @ngraham wrote:

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default.

setfacl -d -m u::rwx ~ or umask 0022 will set default execute permissions on created files. You can set something less permissive on your downloads directory or plasma vault mount with setfacl -d u::rw or similar.

chmod -R 755 ~ will recursively give every file in your home directory execute permisions.

Whoops! I do indeed. Edited the original to be accurate. :)

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.

In D15717#330804, @borispek wrote:

Hi,

I'll need to know your real name and email address. Can you provide that information?

Boris Pek <tehnick-8@yandex.ru>

I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)

Whoops! Thanks for fixing those.

For the benefit of others, here's what they look like now:

Wow, pinch zooming is hugely improved with this new version. Nice work!

How about changing the outline or background of the text box to the Positive or Negative color from the active color theme? That way (for people with sensible color themes), the text box would show red if the value is invalid. I believe GNOME does something similar to this for their IP address validator, and in my experience it works quite nicely.

I gave this a try today and it works nicely! Awesome work! I'd still like some user interface improvements though, because gating these scaling options behind Force rasterization is not very user friendly: the connection between that setting and the scaling options is not likely to be apparent to any user who does not also happen to be a PDF expert or an Okular developer. :)

Ok, thanks for the info. I'll excuse myself now since the technical discussion is way over my head. I just wanted to express support for the idea behind this patch.

+1 for something rather than nothing. No comment on the technical aspect, but I'm adding more reviewers who can hopefully help un-wedge this patch.

Still +1, looks great!

Very much +1 on the end goal!

We're past 5.14 and into 5.15 territory now. Does this deserve another look?

What's the status of this?

How is this looking now that D15426 has gone in?

For what it's worth, I notice that ElementaryOS is already doing this:

+1; "Tap to Click" is by far the more commonly used and understood string.

(also, thank you for doing all this work!)

So this doesn't completely fix https://bugs.kde.org/show_bug.cgi?id=375765? More is needed?

Remove parent directory check entirely; it's not necessary

Oh wow, you're right. Let me fix balooctl to support that, then.

In D15589#330276, @abetts wrote:

If that's the case, do we have just a trash icon, without the folder?

In D15644#330281, @lsartorelli wrote:

Hi Nathaniel, thanks for all the support.
I can understand and agree with your concerns.
Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow

Ah but won't that menu become invisible once the menubar is disabled?

In D15683#329959, @safaalfulaij wrote:

Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.

Thanks anyway Michael!

Code change looks pretty sane to me.

In D15583#330085, @bruns wrote:

I think the whole startsWith is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded.

No problem, and don't let me rush you!

Now that's what I'm talkin' about. Those are awesome in my book. Other VDG folks, thoughts?

LGTM!

I like your depiction of the logical consequences of the firewall being depicted as a wall, @bruns. That seems great. I think a further exploration is warranted:

Thanks! Please also remove - Bug 395349 from the title and replace it with BUG: 395349 in the Summary section.

Can't we work out some agreement here? "Eye Candy" in an unambiguously better user-visible string than "Candy", and it would be a shame to not change it because of a disagreement that I'm sure we can resolve.

Awesome, thank you!

In D9336#329209, @michaelweghorn wrote:

In D9336#329040, @ngraham wrote:

Doesn't this make Okular much less touch-friendly by default?

Possibly. I did not have this in mind when creating this revision. How can I test this without a touch screen? Is using just the left mouse button on a "normal" computer a proper way to simulate this?

Whoops! I saw the name and didn't check the paths. Will land it for you.

Looks like @zzag landed this patch for you last month: https://bugs.kde.org/show_bug.cgi?id=366451#c21

@bcooksley, I think you'll need to land this since permissions to the websites- repos are quite restricted.

@bcooksley, I think you'll need to land this since permissions to the websites- repos are quite restricted.

Thank you for the patch! I see that this is your first KDE contribution, how exciting! This needs some work, so please don't get discouraged, and I'll help you where I can. Here are the problems that need to be solved in order for the patch to be landable:

Yeah, I think this would need some tweaks to be land-able at this point.

Yeah if you don't mind, let's do the arcconfig file in another patch. It's good practice to keep commits atomic. :)

Awesome, I'm impressed that you found this! What do you think about adding a link to https://community.kde.org/Get_Involved/Bug_Reporting into the template somewhere? Or should that be done somewhere in the main UI elsewhere?

We removed the shadow entirely for small sizes in cf0052c2968a7c3e110e24134dbe7ef13c835995. So this change would just be for large sizes now. Do you think this is still needed?

In T7983#160595, @fabianr wrote:

Open questions to me

• What is the default indicator for edges? e.g. in material design it‘s shadows and secondary indicators is different background color and/or opacity. We often use lines.

I like the brick wall metaphor, which does a good job of communicating the point, while being visually distinct from the shield.

• Address review comments and do it better

Actually it looks like we shouldn't even use it anyway for other reasons per the documentation: https://doc.qt.io/qt-5/qdir.html#separator

Cool, thanks for the status update. And if you ask your questions here, maybe whoever's in the know can have a shot at can answering them.

Works for me: fixes the bug and doesn't seem to regress things after a number of other move and zoom operations.

Doesn't this make Okular much less touch-friendly by default?

Any movement on Henrik's review comments?

Where are we at with this? What are the blockers to landing it?

That would only affect the speed of appearing and disappearing though, right? Not the total duration that is status on the screen.

Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15.

I'll keep setSortRole(Qt::DisplayRole) for explicitness if nobody objects.

@wbauer, thanks for the hint. I've tested this with xcursor-themes and verified that it works for me too.

In D15610#328910, @abetts wrote:

Maybe the amount of buttons is not really the issue, if they didn't have labels by default, we would have a lot more room. Thoughts?

Perfecto!

Thanks, this looks perfect for the 16px size! But we'll need the same change for the 22, 24, and 23 px sizes too. Could you do those, too?

Wow, that was fast.

In D15598#328774, @wbauer wrote:

Maybe it would be better to derive CursorThemesModel and IconThemesModel from QSortFilterProxyModel instead of QStandardItemModel, and keep the previous fix?

Address review comments

In D15611#328821, @cfeck wrote:

Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10.

Would KMessageWidget need the same change?

Shouldn't the duration respect the global setting rather than being hardcoded to 500ms?

Rebase on Plasma/5.14 branch