pstefan (Phil Stefan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 31 2015, 3:28 PM (228 w, 3 d)
Availability
Available

Recent Activity

Dec 1 2018

pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Fix transparency of home icon in go.svgz
Dec 1 2018, 9:11 PM · Frameworks
pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Fix stylesheet in go.svgz
Dec 1 2018, 4:15 PM · Frameworks
pstefan added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

I must have had a slightly older version of the patch because I swear I saw the ring using ViewBackground and the background using Background. I downloaded the patch again and everything looks fine there. go.svgz still has #31363b and #232629 as the default colors for the background and ring. Is this intentional?

They do not have a default color for me.

Here's what I'm seeing:

Dec 1 2018, 6:44 AM · Frameworks
pstefan added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

I must have had a slightly older version of the patch because I swear I saw the ring using ViewBackground and the background using Background. I downloaded the patch again and everything looks fine there. go.svgz still has #31363b and #232629 as the default colors for the background and ring. Is this intentional?

Dec 1 2018, 5:57 AM · Frameworks
pstefan added a comment to D15999: Add icons with added background to system.svgz.

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |
Dec 1 2018, 5:00 AM · Frameworks

Nov 30 2018

pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Remove hardcoded background color; Switch background to "ColorScheme-ViewBackground"
  • Reintroduce the outline border on top of the background. Opacity set to 0.3
  • Removed superfluous entries in the style properties
Nov 30 2018, 6:55 PM · Frameworks
pstefan added a comment to D15999: Add icons with added background to system.svgz.

It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the ColorScheme-Text class and the inner symbols should use the ColorScheme-Background class.

The opposite: the background is supposed to be dark with breeze dark, and light with breeze light.

In general, with dark themes you want white monochrome icons and the circle is now the dominant icon element, meaning it should get painted white.

But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark:

They would be weird looking and would be superfluous.

In the case of the SDDM theme I agree it's odd that the circles are colored differently than the input box, but the logout screen is more important.

Nov 30 2018, 5:19 AM · Frameworks

Nov 8 2018

pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Hardcoded background color
Nov 8 2018, 9:45 PM · Frameworks

Nov 5 2018

pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Fixed z order
Nov 5 2018, 10:28 AM · Frameworks
pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Added missing class attributes
Nov 5 2018, 10:26 AM · Frameworks

Nov 4 2018

pstefan updated the summary of D15999: Add icons with added background to system.svgz.
Nov 4 2018, 6:35 PM · Frameworks
pstefan updated the diff for D15999: Add icons with added background to system.svgz.
  • Sized down icons somewhat
  • Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, etc). 32px only for now
  • Made background darker
  • Removed outer circle
  • Merge branch 'master' of git://anongit.kde.org/plasma-framework
Nov 4 2018, 6:27 PM · Frameworks

Oct 8 2018

pstefan added a comment to D15999: Add icons with added background to system.svgz.
Oct 8 2018, 2:34 PM · Frameworks
pstefan added a comment to D15999: Add icons with added background to system.svgz.

Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:)

Could we make it adaptable to the color scheme? I don't know if the code applies, but they managed to do it here: https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg

They do however just leave the icon itself transparent, but perhaps that wouldn't work well with Breeze icons.

Oct 8 2018, 2:34 PM · Frameworks
pstefan added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

RE: D16031 I think the background circle for the avatar should either be dropped or flush with the white border.

Oct 8 2018, 2:23 PM · Plasma, VDG
pstefan added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

As other have pointed out the shadows for the buttons and username look out of place. Do they use the same radius/spread as those of the clock?

Oct 8 2018, 2:12 PM · Plasma

Oct 7 2018

pstefan updated the diff for D15999: Add icons with added background to system.svgz.

Fix z-layering issue for the "-translucent" icons.

Oct 7 2018, 3:45 PM · Frameworks
pstefan updated the summary of D15999: Add icons with added background to system.svgz.
Oct 7 2018, 10:07 AM · Frameworks
pstefan added a reviewer for D15999: Add icons with added background to system.svgz: VDG.
Oct 7 2018, 10:07 AM · Frameworks
pstefan requested review of D15999: Add icons with added background to system.svgz.
Oct 7 2018, 10:02 AM · Frameworks

Oct 1 2018

pstefan accepted D15853: Change drive-harddisk to more adaptable style.

Thank you for the changes!

Oct 1 2018, 4:25 AM · Frameworks

Sep 30 2018

pstefan requested changes to D15853: Change drive-harddisk to more adaptable style.

In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme.
You will have to run the scripts "apply-stylesheet.sh" and "currentColorFillFix.sh" –from here– with your files as arguments. You will need the program "xmlstarlet" as dependency.
Or, if these scripts do not work correctly, you'll have to do it by hand. I will take icons-dark/devices/16/drive-harddisk.svg as an example.
You'd need to copy line 2-9 from the old file to the new file. You would also need to change the fill to "fill:currentColor", and then add the "class="ColorScheme-Text" ". But if you are lucky the script will work and you won't need to do a thing :)

Sep 30 2018, 5:56 PM · Frameworks
pstefan added a comment to T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15.

Any update on the icon front, re: different background color? Right now my stylesheet class attribute in the icons is "ColorScheme-ViewBackground", which is a light color in the normal breeze color scheme. My thinking was that it would use the breeze dark color scheme on the login screen. Is that assumption correct or do I need to change that?

Sep 30 2018, 10:57 AM · Plasma, VDG

Sep 20 2018

pstefan added a comment to D15618: Add plus symbol to document-new.svg.

Should be fixed now!

Sep 20 2018, 1:56 PM · Frameworks
pstefan updated the diff for D15618: Add plus symbol to document-new.svg.

Add missing sizes

Sep 20 2018, 1:56 PM · Frameworks
pstefan requested review of D15618: Add plus symbol to document-new.svg.
Sep 20 2018, 1:06 PM · Frameworks

Sep 15 2018

pstefan closed T1431: Find out who might implement KCM designs as Invalid.

Long outdated and irrelevant

Sep 15 2018, 4:31 PM · Breeze

Aug 21 2018

pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • changed osd-sbs-right to osd-sbs-sright
Aug 21 2018, 2:32 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix.
Aug 21 2018, 2:23 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Reverse name change
Aug 21 2018, 1:52 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Moved all OSD icons into video.svgz and renamed some of them.
Aug 21 2018, 12:29 PM · Frameworks
pstefan abandoned D10937: Retouching of Screen Layout Selection OSD Icons.

Moved to D14971

Aug 21 2018, 10:40 AM · VDG, Frameworks
pstefan retitled D14971: Combine display OSD icon files and move to plasma icon theme from Combine display OSD icon files and mobe to plasma icon theme to Combine display OSD icon files and move to plasma icon theme.
Aug 21 2018, 10:40 AM · Frameworks
pstefan added reviewers for D14971: Combine display OSD icon files and move to plasma icon theme: ngraham, VDG.
Aug 21 2018, 10:39 AM · Frameworks
pstefan requested review of D14971: Combine display OSD icon files and move to plasma icon theme.
Aug 21 2018, 10:39 AM · Frameworks

Aug 14 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Sure, I can do that, but I'd like to get feedback on the final form first :)

Aug 14 2018, 3:06 PM · VDG, Frameworks
pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Sorry folks for the endless period of no activity. After some talking with ngraham I removed the laptop metaphor for a much more general standalone display. Also the projection screen was swapped out.

Aug 14 2018, 1:54 PM · VDG, Frameworks

May 10 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these?

I am linking these a lot. I am "almost" there with the designs. I would just ask that the center image of the sample window be simplified. I think it has a lot of detail. Maybe we can tone it down by removing some elements and making the window look more simple.

May 10 2018, 3:53 PM · VDG, Frameworks

May 9 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Hello again,

May 9 2018, 6:53 PM · VDG, Frameworks

Apr 5 2018

pstefan updated the diff for D10937: Retouching of Screen Layout Selection OSD Icons.
Apr 5 2018, 11:49 AM · VDG, Frameworks

Apr 4 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

I am glad you like them :)

Apr 4 2018, 8:21 PM · VDG, Frameworks
pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Latest revision:


I moved the window a bit up while maintaining the alignment, as requested. I had to remove the stand of the projector screen tho. Originally I "cheated" and moved the stand off-center to make it still visible. However, with the "header" of the projector screen shown, it was easily apparent that the stand wasn't centered anymore.

Apr 4 2018, 3:11 PM · VDG, Frameworks

Mar 16 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Those all look pretty great to me, honestly. A nice upgrade from the current icons.

For the pink column, does it look bad if you raise the projection screen so that it's only a little bit higher than the laptop on the large icons? It seems like there's room to raise it a bit and still keep the blue window aligned between them. I think it's okay if they're not aligned on the smaller versions.

Mar 16 2018, 10:19 PM · VDG, Frameworks
pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

An update:

Mar 16 2018, 9:27 PM · VDG, Frameworks

Mar 5 2018

pstefan updated the summary of D11057: Add a custom default avatar to the sddm-breeze theme..
Mar 5 2018, 1:44 PM · Plasma
pstefan requested review of D11057: Add a custom default avatar to the sddm-breeze theme..
Mar 5 2018, 1:38 PM · Plasma

Mar 2 2018

pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.
In D10937#216476, @mart wrote:

one point tough: those are only going to work at a single size, as they are more vulnerable to become blurry when resized, so they would need other size versions as well (small sizes probably being like before)

as they are part of the icon theme, one can't assume where and how they will be used (want it or not, app developers will just borrow them if they like it for whatever they want to represent) so the full sizes set is needed

Mar 2 2018, 12:39 PM · VDG, Frameworks

Mar 1 2018

pstefan updated the summary of D10937: Retouching of Screen Layout Selection OSD Icons.
Mar 1 2018, 7:16 PM · VDG, Frameworks
pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

Some different versions. Personally, I think the first or last version is best, however, the last would probably only work in conjunction to the other icons and not as stand alones.

Mar 1 2018, 7:16 PM · VDG, Frameworks
pstefan added a comment to D10937: Retouching of Screen Layout Selection OSD Icons.

But I don't like how the window and X icons in the other icons are now much lighter and smaller. I feel like they need to be a bit bigger and/or have thicker line weights to ensure that they don't recede too much in visual importance. Maybe not as big and thick as before, but maybe a bit bigger.

Mar 1 2018, 6:06 PM · VDG, Frameworks
pstefan requested review of D10937: Retouching of Screen Layout Selection OSD Icons.
Mar 1 2018, 11:25 AM · VDG, Frameworks

Aug 28 2016

pstefan closed T1433: Make a list with questions about branding as Resolved.
Aug 28 2016, 10:51 AM · Breeze
pstefan closed T1432: Finish wikipage regarding unified boot and login experience as Resolved.
Aug 28 2016, 10:50 AM · Breeze
pstefan removed a member for VDG: pstefan.
Aug 28 2016, 10:50 AM
pstefan removed a member for Plasma: Design: pstefan.
Aug 28 2016, 10:49 AM
pstefan removed a member for Breeze: pstefan.
Aug 28 2016, 10:49 AM

Aug 11 2016

pstefan added a comment to M58: From Grub to Shutdown, strict version.

I need this icon please

Aug 11 2016, 4:55 AM · Plasma: Design, VDG

Aug 10 2016

pstefan added a comment to M58: From Grub to Shutdown, strict version.

What am I showing when the user doesn't have a face set?

Aug 10 2016, 3:03 PM · Plasma: Design, VDG

Aug 4 2016

pstefan updated images of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:41 PM · Plasma: Design, VDG
pstefan updated images of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:39 PM · Plasma: Design, VDG
pstefan updated image descriptions of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:36 PM · Plasma: Design, VDG
pstefan updated images of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:34 PM · Plasma: Design, VDG
pstefan added a comment to T3364: Lockscreen.

I updated the mockup(s) to include metrics. Everything has basically the same metrics as shown in image 8 to 14 except some elements are added or removed depending on which screen we are talking about. Almost everything you mentioned should be answered in the description of image 8-14. The only thing missing is the OSD, which does not change.

Aug 4 2016, 4:30 PM · VDG, Plasma
pstefan updated images of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:23 PM · Plasma: Design, VDG
pstefan added a comment to M58: From Grub to Shutdown, strict version.

If there's a username box, what does the User Search button do?

That was a bug in the mockup. Well spotted! I added new mockups detailing the metrics of each part.

Aug 4 2016, 4:21 PM · Plasma: Design, VDG
pstefan updated images of M58: From Grub to Shutdown, strict version.
Aug 4 2016, 4:14 PM · Plasma: Design, VDG
pstefan closed mock M62: SDDM and Lock Screen Metrics.
Aug 4 2016, 4:13 PM · VDG
pstefan updated images of M62: SDDM and Lock Screen Metrics.
Aug 4 2016, 4:02 PM · VDG
pstefan updated the description for M62: SDDM and Lock Screen Metrics.
Aug 4 2016, 2:32 PM · VDG
pstefan created M62: SDDM and Lock Screen Metrics.
Aug 4 2016, 2:27 PM · VDG

Jul 14 2016

pstefan added a comment to M53: Discover .

Showing something fancy at the top of the drawer is kind of a pattern in Kirigami, inspired by the drawer in Android. It doesn't have to just show the logo, though. If you have a better idea, shoot :)

Jul 14 2016, 6:40 PM · VDG

Jul 7 2016

pstefan added an inline comment to M53: Discover .

In general I am not a fan of all the blue separator lines used. I think we should only use them as a highlight effects, to draw the attention of the user towards it. Using it too often and it become just meaningless noise. I think we can use a different, more neutral color for the same effect or often even get rid of them e.g. the Details view in picture 7 between "Kate" and the subtext.

Jul 7 2016, 12:51 PM · VDG

Jun 28 2016

pstefan added an inline comment to M45: GRUB.

Overall I like the mockup very much. It has some very good idea.
Some comments and suggestions below:

Jun 28 2016, 5:31 PM

Jun 18 2016

pstefan added a member for VDG: pstefan.
Jun 18 2016, 1:43 PM

Jan 31 2016

pstefan updated the task description for T1432: Finish wikipage regarding unified boot and login experience.
Jan 31 2016, 7:23 PM · Breeze
pstefan updated the task description for T1432: Finish wikipage regarding unified boot and login experience.
Jan 31 2016, 7:23 PM · Breeze
pstefan renamed T1433: Make a list with questions about branding from Make a list about questions about branding to Make a list with questions about branding.
Jan 31 2016, 7:22 PM · Breeze
pstefan created T1436: Create a Breeze Look&Feel package.
Jan 31 2016, 2:57 PM · Breeze
pstefan created T1435: List plasmoids with issues at small sizes.
Jan 31 2016, 2:56 PM · Breeze
pstefan created T1434: Projects' web pages.
Jan 31 2016, 2:55 PM · Breeze
pstefan created T1433: Make a list with questions about branding.
Jan 31 2016, 2:51 PM · Breeze
pstefan created T1432: Finish wikipage regarding unified boot and login experience.
Jan 31 2016, 2:49 PM · Breeze
pstefan created T1431: Find out who might implement KCM designs.
Jan 31 2016, 2:47 PM · Breeze
pstefan changed the status of T578: [Cleanup] Harmonize the colors in the plasma-breeze icons. from Resolved to Invalid.
Jan 31 2016, 2:45 PM · Breeze
pstefan moved T1430: [CERN Sprint]Make a list of missing features for discussion with developers from Backlog/Planned to Requ. CERN Sprint on the Breeze board.
Jan 31 2016, 2:45 PM · Breeze
pstefan moved T1429: [CERN Sprint] Drafts/Sketches for KCMs from Backlog/Planned to Requ. CERN Sprint on the Breeze board.
Jan 31 2016, 2:45 PM · Breeze
pstefan closed T578: [Cleanup] Harmonize the colors in the plasma-breeze icons. as Resolved.
Jan 31 2016, 2:45 PM · Breeze
pstefan moved T578: [Cleanup] Harmonize the colors in the plasma-breeze icons. from Work in Progress to Done on the Breeze board.
Jan 31 2016, 2:45 PM · Breeze
pstefan created T1430: [CERN Sprint]Make a list of missing features for discussion with developers.
Jan 31 2016, 2:44 PM · Breeze
pstefan created T1429: [CERN Sprint] Drafts/Sketches for KCMs.
Jan 31 2016, 2:38 PM · Breeze
pstefan moved T572: Add a dedicated trashcan icon from Done to Backlog/Planned on the Breeze board.
Jan 31 2016, 2:32 PM · Breeze
pstefan moved T572: Add a dedicated trashcan icon from Backlog/Planned to Done on the Breeze board.
Jan 31 2016, 2:26 PM · Breeze

Aug 18 2015

pstefan moved T578: [Cleanup] Harmonize the colors in the plasma-breeze icons. from Backlog/Planned to Work in Progress on the Breeze board.
Aug 18 2015, 7:14 PM · Breeze

Aug 17 2015

pstefan accepted R31:548622883776: Breeze Icons: update authors mimetype according to T570.

Looks good to me :)

Aug 17 2015, 10:44 AM
pstefan triaged T578: [Cleanup] Harmonize the colors in the plasma-breeze icons. as Low priority.
Aug 17 2015, 10:42 AM · Breeze
pstefan created T578: [Cleanup] Harmonize the colors in the plasma-breeze icons..
Aug 17 2015, 10:41 AM · Breeze

Aug 15 2015

pstefan created T575: Tweak radio buttons and checkboxes.
Aug 15 2015, 7:16 AM · Breeze
pstefan created T574: Breezeify the default user icon of SDDM.
Aug 15 2015, 7:11 AM · Breeze
pstefan updated the task description for T573: Find a way for Breeze windeco to guarantee contrast between different windows.
Aug 15 2015, 7:08 AM · Breeze
pstefan updated the task description for T573: Find a way for Breeze windeco to guarantee contrast between different windows.
Aug 15 2015, 7:07 AM · Breeze