It is not shown by default but when the user enables it, it should show something sensible.
Details
Details
- Reviewers
elvisangelaccio ngraham - Group Reviewers
Dolphin VDG - Commits
- R318:4de45ee5076b: Add proper labels to Trash Emptied notification
Before it was just a generic useless KDE logo with "Plasma Workspace" heading
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/trash/dolphintrash.cpp | ||
|---|---|---|
| 71 | Maybe "folder" is redundant? | |
| src/trash/dolphintrash.cpp | ||
|---|---|---|
| 71 | Agreed, we don't need the word "folder" in this string. In fact, the whole string is redundant since the title "Trash Emptied" already tells you everything you need to know. | |
| src/trash/dolphintrash.cpp | ||
|---|---|---|
| 71 | Yes but there must also be a main notification text | |
Comment Actions
user-trash looks like a folder at larger sizes. trash-empty might even be more semantically appropriate here, and it doesn't look like a folder at a large size. It does look a bit... spartan, though. Might be worth giving it a prettier version for the large sizes.
Or perhaps we could change user trash so that its large sizes don't look like a folder. It is after all rather odd to visually indicate that the trash is a folder. It should probably look like a trash can, not a folder.
Comment Actions
All right, ship it! Let's improve the icon in https://bugs.kde.org/show_bug.cgi?id=399613