Relabel "Mouse Click Emulation" to "Tap to Click"
ClosedPublic

Authored by sharvey on Sep 22 2018, 9:31 PM.

Details

Summary

Text change/usability improvement. Replace technical terms with user-friendly language.

BUG: 398938
FIXED-IN: 5.15.0

Test Plan
  • Recompile/reinclude touchpad KCM
  • Check for text change

Diff Detail

Repository
R119 Plasma Desktop
Branch
tap-to-click
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3130
Build 3148: arc lint + arc unit
sharvey created this revision.Sep 22 2018, 9:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 22 2018, 9:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Sep 22 2018, 9:31 PM
sharvey added inline comments.Sep 22 2018, 9:33 PM
kcms/touchpad/src/kcm/xlib/ui/tap.ui
31

I only changed lines 28-31... I don't know what the other changes are. I pulled plasma-desktop fresh from git. The change took mere minutes.

sharvey edited the summary of this revision. (Show Details)Sep 22 2018, 9:36 PM
sharvey updated this revision to Diff 42154.Sep 22 2018, 10:17 PM

Update "Mouse Click Emulation" to "Tap to Click"

sharvey marked an inline comment as done.Sep 22 2018, 10:18 PM
ngraham accepted this revision.Sep 22 2018, 10:40 PM
ngraham added subscribers: furkantokac, romangg.

+1; "Tap to Click" is by far the more commonly used and understood string.

Landing this in 5.15 because it's a string change. Hopefully @romangg or @furkantokac will have the new Libinput KCM ready for x11 by 5.15, but just in case, this can be the a consolation prize. :-)

This revision is now accepted and ready to land.Sep 22 2018, 10:40 PM
ngraham edited the summary of this revision. (Show Details)Sep 22 2018, 10:41 PM
ngraham closed this revision.Sep 22 2018, 10:42 PM